From: Felipe Contreras Date: Fri, 1 Jun 2012 08:54:25 +0000 (+0200) Subject: Re: Can't compile notmuch-delivery X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=5b00d6841bcfe5e8d5c76267aa3b8f305f07a564;p=notmuch-archives.git Re: Can't compile notmuch-delivery --- diff --git a/2e/6acb2b3e3ca6194c99cb860014c8025a93a0e0 b/2e/6acb2b3e3ca6194c99cb860014c8025a93a0e0 new file mode 100644 index 000000000..66ba71bf6 --- /dev/null +++ b/2e/6acb2b3e3ca6194c99cb860014c8025a93a0e0 @@ -0,0 +1,96 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 77F5A431FB6 + for ; Fri, 1 Jun 2012 01:54:29 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.799 +X-Spam-Level: +X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id sO6MyVZwpyNM for ; + Fri, 1 Jun 2012 01:54:29 -0700 (PDT) +Received: from mail-lb0-f181.google.com (mail-lb0-f181.google.com + [209.85.217.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id B569C431FAF + for ; Fri, 1 Jun 2012 01:54:28 -0700 (PDT) +Received: by lbbgk8 with SMTP id gk8so1645545lbb.26 + for ; Fri, 01 Jun 2012 01:54:25 -0700 (PDT) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; + h=mime-version:in-reply-to:references:date:message-id:subject:from:to + :cc:content-type:content-transfer-encoding; + bh=EJOjWaX1wtS+Yasafj3ljsDa2FVuiOtw585x3Pqoaz4=; + b=za/PwgY988dKN/33XNtKXreh3B/SPyl9fTn1smMNfgGWqc2NytPVii4kaTrOHOBPwT + yU/tlwCmjl41XqFogSWUxILnE9GyYuiIfv/BbrRFFI20rqtMuzZREy9H5X71uK6A7UKV + Z3vYOtQ5hMa1cZxeciHeNKRIpELlh7+r8cxhXZ7n2gxuBT2Grg/LTORqNVw28fIlaTD+ + XaG4ujC3D15I+xH6qFfDhLx1NxEM6TIZoibOxc6J6r2hRJVqdf/rVlCdwVJBYCOUOc5S + BWTJqI6YVAnvf51B4JACV5T15YdTU4q/2BEoa+2cT/F/BeCoyoo62QkTSPGGb14g636Y + CEkQ== +MIME-Version: 1.0 +Received: by 10.152.112.138 with SMTP id iq10mr1971435lab.13.1338540865719; + Fri, 01 Jun 2012 01:54:25 -0700 (PDT) +Received: by 10.112.107.65 with HTTP; Fri, 1 Jun 2012 01:54:25 -0700 (PDT) +In-Reply-To: +References: <20120531214259.GA18272@desktop> + +Date: Fri, 1 Jun 2012 10:54:25 +0200 +Message-ID: + +Subject: Re: Can't compile notmuch-delivery +From: Felipe Contreras +To: Tomi Ollila +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: quoted-printable +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Fri, 01 Jun 2012 08:54:29 -0000 + +On Fri, Jun 1, 2012 at 8:44 AM, Tomi Ollila wrote: +> On Fri, Jun 01 2012, Jostein Gogstad wrote: + +>> I'm trying to compile notmuch-deliver, but after I get this error: +>> +>> =C2=A0 CC =C2=A0 =C2=A0 main.o +>> =C2=A0 main.c: In function =E2=80=98main=E2=80=99: +>> =C2=A0 main.c:432: error: too few arguments to function =E2=80=98notmuch= +_database_open=E2=80=99 +>> =C2=A0 make[2]: *** [main.o] Error 1 +>> +>> Any ideas? Tried with the version that ships with 0.13, and the version +>> in HEAD (they seem similar though). +> +> Yes, commit 5fddc07d (*) changes notmuch_database_open() interface. Austi= +n +> or Ali may fix that some day... +> +> .. or Someone Else(TM)... patches welcome :D + +I'd say the one who breaks the API does the necessary changes in all +notmuch code, otherwise what's the point of having the code in the +same repo? This is how the Linux kernel does it. + +I would be in favor of reverting these changes, and possibly put them +in a separate branch, until they are ready (as in all notmuch code +compiles). + +Cheers. + +--=20 +Felipe Contreras