From: Blake Jones Date: Sun, 4 Nov 2012 03:15:54 +0000 (+1700) Subject: [PATCH 02/10] asctime: check for standards compliance (Solaris support) X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=589949cb62e17d9fa2654e50d3096b1afb75147e;p=notmuch-archives.git [PATCH 02/10] asctime: check for standards compliance (Solaris support) --- diff --git a/03/c8a260050287948ae31941d2a673b0768f427a b/03/c8a260050287948ae31941d2a673b0768f427a new file mode 100644 index 000000000..6e54a667b --- /dev/null +++ b/03/c8a260050287948ae31941d2a673b0768f427a @@ -0,0 +1,160 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 8631F431FD8 + for ; Sat, 3 Nov 2012 20:24:23 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id dfbYinEmaS26 for ; + Sat, 3 Nov 2012 20:24:22 -0700 (PDT) +Received: from foo.net (70-36-235-136.dsl.static.sonic.net [70.36.235.136]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 9C7FF431FB6 + for ; Sat, 3 Nov 2012 20:24:20 -0700 (PDT) +Received: from foo.net (localhost [127.0.0.1]) + by foo.net (8.14.5+Sun/8.14.5) with ESMTP id qA43GEAC025659; + Sat, 3 Nov 2012 20:16:14 -0700 (PDT) +Received: (from blakej@localhost) + by foo.net (8.14.5+Sun/8.14.5/Submit) id qA43GEpI025658; + Sat, 3 Nov 2012 20:16:14 -0700 (PDT) +From: Blake Jones +To: notmuch@notmuchmail.org +Subject: [PATCH 02/10] asctime: check for standards compliance (Solaris + support) +Date: Sat, 3 Nov 2012 20:15:54 -0700 +Message-Id: <1351998962-25135-3-git-send-email-blakej@foo.net> +X-Mailer: git-send-email 1.7.3.2 +In-Reply-To: <1351998962-25135-1-git-send-email-blakej@foo.net> +References: <1351998962-25135-1-git-send-email-blakej@foo.net> +X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0.2 + (foo.net [127.0.0.1]); Sat, 03 Nov 2012 20:16:14 -0700 (PDT) +X-Mailman-Approved-At: Sun, 04 Nov 2012 01:30:19 -0800 +Cc: Blake Jones +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 04 Nov 2012 03:24:24 -0000 + +Add checks to "configure" to see whether _POSIX_PTHREAD_SEMANTICS needs +to be defined to get the right number of arguments in the prototypes for +asctime_r(). Solaris' default implementation conforms to POSIX.1c +Draft 6, rather than the final POSIX.1c spec. The standards-compliant +version can be used by defining _POSIX_PTHREAD_SEMANTICS. + +This change also adds the file "compat/check_asctime.c", which +configure uses to perform its check, and modifies compat/compat.h to +define _POSIX_PTHREAD_SEMANTICS if configure detected it was needed. +--- + compat/check_asctime.c | 17 +++++++++++++++++ + compat/compat.h | 3 +++ + configure | 22 ++++++++++++++++++++-- + 3 files changed, 40 insertions(+), 2 deletions(-) + create mode 100644 compat/check_asctime.c + +diff --git a/compat/check_asctime.c b/compat/check_asctime.c +new file mode 100644 +index 0000000..a595110 +--- /dev/null ++++ b/compat/check_asctime.c +@@ -0,0 +1,17 @@ ++/* ++ * This compatibility check actually succeeds (on Solaris) if ++ * _POSIX_PTHREAD_SEMANTICS is not defined. But we need to define that to get ++ * the right version of getpwuid_r(), so we define it here to ensure that the ++ * compatibility check ends up doing the same thing as the rest of the code. ++ */ ++#define _POSIX_PTHREAD_SEMANTICS ++#include ++ ++int main() ++{ ++ struct tm tm; ++ ++ (void) asctime_r (&tm, NULL, 0); ++ ++ return (0); ++} +diff --git a/compat/compat.h b/compat/compat.h +index 8374d2f..b750501 100644 +--- a/compat/compat.h ++++ b/compat/compat.h +@@ -57,6 +57,9 @@ char* strcasestr(const char *haystack, const char *needle); + #if !STD_GETPWUID + #define _POSIX_PTHREAD_SEMANTICS + #endif ++#if !STD_ASCTIME ++#define _POSIX_PTHREAD_SEMANTICS ++#endif + + #ifdef __cplusplus + } +diff --git a/configure b/configure +index 3c18a45..047c011 100755 +--- a/configure ++++ b/configure +@@ -523,6 +523,17 @@ else + fi + rm -f compat/check_getpwuid + ++printf "Checking for standard version of asctime_r... " ++if ${CC} -o compat/check_asctime "$srcdir"/compat/check_asctime.c > /dev/null 2>&1 ++then ++ printf "Yes.\n" ++ std_asctime=1 ++else ++ printf "No (will define _POSIX_PTHREAD_SEMANTICS to get it).\n" ++ std_asctime=0 ++fi ++rm -f compat/check_asctime ++ + printf "int main(void){return 0;}\n" > minimal.c + + printf "Checking for rpath support... " +@@ -687,6 +698,11 @@ HAVE_STRCASESTR = ${have_strcasestr} + # to enable the standards-compliant version -- needed for Solaris) + STD_GETPWUID = ${std_getpwuid} + ++# Whether the asctime_r function is standards-compliant ++# (if not, then notmuch will compile with -D_POSIX_PTHREAD_SEMANTICS ++# to enable the standards-compliant version -- needed for Solaris) ++STD_ASCTIME = ${std_asctime} ++ + # Supported platforms (so far) are: LINUX, MACOSX, SOLARIS, FREEBSD, OPENBSD + PLATFORM = ${platform} + +@@ -733,11 +749,13 @@ CONFIGURE_CFLAGS = -DHAVE_GETLINE=\$(HAVE_GETLINE) \$(GMIME_CFLAGS) \\ + \$(TALLOC_CFLAGS) -DHAVE_VALGRIND=\$(HAVE_VALGRIND) \\ + \$(VALGRIND_CFLAGS) \\ + -DHAVE_STRCASESTR=\$(HAVE_STRCASESTR) \\ +- -DSTD_GETPWUID=\$(STD_GETPWUID) ++ -DSTD_GETPWUID=\$(STD_GETPWUID) \\ ++ -DSTD_ASCTIME=\$(STD_ASCTIME) + CONFIGURE_CXXFLAGS = -DHAVE_GETLINE=\$(HAVE_GETLINE) \$(GMIME_CFLAGS) \\ + \$(TALLOC_CFLAGS) -DHAVE_VALGRIND=\$(HAVE_VALGRIND) \\ + \$(VALGRIND_CFLAGS) \$(XAPIAN_CXXFLAGS) \\ + -DHAVE_STRCASESTR=\$(HAVE_STRCASESTR) \\ +- -DSTD_GETPWUID=\$(STD_GETPWUID) ++ -DSTD_GETPWUID=\$(STD_GETPWUID) \\ ++ -DSTD_ASCTIME=\$(STD_ASCTIME) + CONFIGURE_LDFLAGS = \$(GMIME_LDFLAGS) \$(TALLOC_LDFLAGS) \$(XAPIAN_LDFLAGS) + EOF +-- +1.7.9.2 +