From: Jameson Graef Rollins Date: Fri, 6 Apr 2012 15:13:59 +0000 (+1700) Subject: Re: [PATCH v3 0/6] Move --no-exclude to --exclude=(true|false|flag) X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=581cb7a2488e3ba8aa8d963d5f12801315b6a595;p=notmuch-archives.git Re: [PATCH v3 0/6] Move --no-exclude to --exclude=(true|false|flag) --- diff --git a/54/1a4c8351532229f021994f782859c46851f50d b/54/1a4c8351532229f021994f782859c46851f50d new file mode 100644 index 000000000..b9f543bff --- /dev/null +++ b/54/1a4c8351532229f021994f782859c46851f50d @@ -0,0 +1,97 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id D89FA431FB6 + for ; Fri, 6 Apr 2012 08:14:09 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -2.29 +X-Spam-Level: +X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id QiFwa0B3wCsZ for ; + Fri, 6 Apr 2012 08:14:09 -0700 (PDT) +Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu + [131.215.239.19]) + by olra.theworths.org (Postfix) with ESMTP id 7C673431FAE + for ; Fri, 6 Apr 2012 08:14:09 -0700 (PDT) +Received: from fire-doxen.imss.caltech.edu (localhost [127.0.0.1]) + by fire-doxen-postvirus (Postfix) with ESMTP id 0D7DD328072; + Fri, 6 Apr 2012 08:14:07 -0700 (PDT) +X-Spam-Scanned: at Caltech-IMSS on fire-doxen by amavisd-new +Received: from finestructure.net (unknown [76.89.193.65]) + (Authenticated sender: jrollins) + by fire-doxen-submit (Postfix) with ESMTP id 4A6BE2E50E2B; + Fri, 6 Apr 2012 08:14:04 -0700 (PDT) +Received: by finestructure.net (Postfix, from userid 1000) + id E1D7854F; Fri, 6 Apr 2012 08:14:03 -0700 (PDT) +From: Jameson Graef Rollins +To: Mark Walters , notmuch@notmuchmail.org +Subject: Re: [PATCH v3 0/6] Move --no-exclude to --exclude=(true|false|flag) +In-Reply-To: <1333716551-29153-1-git-send-email-markwalters1009@gmail.com> +References: <1333716551-29153-1-git-send-email-markwalters1009@gmail.com> +User-Agent: Notmuch/0.12+101~g4f44c8f (http://notmuchmail.org) Emacs/23.4.1 + (x86_64-pc-linux-gnu) +Date: Fri, 06 Apr 2012 08:13:59 -0700 +Message-ID: <87bon47v0o.fsf@servo.finestructure.net> +MIME-Version: 1.0 +Content-Type: multipart/signed; boundary="=-=-="; + micalg=pgp-sha256; protocol="application/pgp-signature" +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Fri, 06 Apr 2012 15:14:10 -0000 + +--=-=-= + +On Fri, Apr 06 2012, Mark Walters wrote: +> This is the latest version of the patch series (previous version at [1]). +> I think this version fixes all the problems raised by Austin in his review. + +Tested and reviewed and LGTM. + +Unfortunately, though, I just now noticed that the tests don't cover +count and show excludes. Since everything else looks good, let's just +make a new version of [0]. I suggest we name the new test script just +"excludes" and then add count and show tests there. That should be +pretty straightforward. + +Thanks again, Mark. + +jamie. + +[0] id:"1333716551-29153-5-git-send-email-markwalters1009@gmail.com" + +--=-=-= +Content-Type: application/pgp-signature + +-----BEGIN PGP SIGNATURE----- +Version: GnuPG v1.4.12 (GNU/Linux) + +iQIcBAEBCAAGBQJPfwg3AAoJEO00zqvie6q844cQAIon5/HeKzGPWMv3m5iN/2Dp +NpSzsvyZBUj4q3B062d7F+Y9LMrfj0wOkhVnXatNK2V3lbjhxiGL772qEnYzDzND +LRvp4f41ok87U/3MuCTC92htCFAm35tqCJN713RS1uykqA1sLwHFnd4GZ0lvisKX +Um0K5O7RilfuRDPSe7+Lmmu6mB8zrIMfLaMH+sS1cjtoLGSWVgLUhs7X3vuvfFZN +d2HMgmzE9h/05shm0wXKhEuPdJzlj/9bx2Hg92JJV3Bv9ZX2kQB9dFxQC9GdXAbm +hu5e33ZSow//o9FiIXq+loXiL1gkYzukC7kYEl5gRMUtJkWctxzrbaaENBOFH5hP +c0/UXYcovk52BaYNUCgZ9aGFTGbqNBfTYYdkuYbByFar3gk1dXqgJhdqtkFdG3oJ +bwwb8FxkxbiqiLjI+ULuQ1iP7iNo5hsO8PCWAYUdPQQJ1lnggDUyos0igDpkMRJZ +OIv0+d/Sy1dT0dn1iyAOgOyKvEC5JgDWex02qEjPnxg5RrXP6EzS0wvZS7igwV4C +yy7RUhFInKtCXYdhUIAPVHTxydhqpy2QV2IrXfU7uc6PRVXlRTci14W+SMJBc/72 +vrNumqJG2sIW34SnrSifEFvzPxMRrbCgs+EVbvQe9orAbF+oQyg028Eri9Ni72GZ +CRdF9GUDARlOc6Xz4E63 +=4OwQ +-----END PGP SIGNATURE----- +--=-=-=--