From: Pieter Praet Date: Fri, 24 Feb 2012 22:36:09 +0000 (+0100) Subject: Re: [PATCH 5/6] emacs: simplify `notmuch-show-get-messages-ids{, -search}' X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=56381553ce95dca11ae36a130c77affd2f4c7547;p=notmuch-archives.git Re: [PATCH 5/6] emacs: simplify `notmuch-show-get-messages-ids{, -search}' --- diff --git a/77/0521b0107a6d6999713111c572a5b9d05e90e6 b/77/0521b0107a6d6999713111c572a5b9d05e90e6 new file mode 100644 index 000000000..b5d17ebbb --- /dev/null +++ b/77/0521b0107a6d6999713111c572a5b9d05e90e6 @@ -0,0 +1,154 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 0ADDB416162 + for ; Fri, 24 Feb 2012 14:38:26 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id LS2CmYBBTH2V for ; + Fri, 24 Feb 2012 14:38:25 -0800 (PST) +Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com + [209.85.212.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 578AC416160 + for ; Fri, 24 Feb 2012 14:38:25 -0800 (PST) +Received: by wibhi8 with SMTP id hi8so2011057wib.26 + for ; Fri, 24 Feb 2012 14:38:24 -0800 (PST) +Received-SPF: pass (google.com: domain of pieter@praet.org designates + 10.180.102.35 as permitted sender) client-ip=10.180.102.35; +Authentication-Results: mr.google.com; + spf=pass (google.com: domain of pieter@praet.org + designates 10.180.102.35 as permitted sender) + smtp.mail=pieter@praet.org +Received: from mr.google.com ([10.180.102.35]) + by 10.180.102.35 with SMTP id fl3mr8802777wib.22.1330123104258 + (num_hops = 1); Fri, 24 Feb 2012 14:38:24 -0800 (PST) +Received: by 10.180.102.35 with SMTP id fl3mr7082071wib.22.1330123104199; + Fri, 24 Feb 2012 14:38:24 -0800 (PST) +Received: from localhost ([109.131.181.26]) + by mx.google.com with ESMTPS id p10sm6474682wic.0.2012.02.24.14.38.23 + (version=TLSv1/SSLv3 cipher=OTHER); + Fri, 24 Feb 2012 14:38:23 -0800 (PST) +From: Pieter Praet +To: Dmitry Kurochkin , + David Bremner +Subject: Re: [PATCH 5/6] emacs: simplify `notmuch-show-get-messages-ids{, + -search}' +In-Reply-To: <87d394jyvm.fsf@gmail.com> +References: <878vjtqhcg.fsf@praet.org> + <1330038554-10347-5-git-send-email-pieter@praet.org> + <87d394jyvm.fsf@gmail.com> +User-Agent: Notmuch/0.11.1+210~g6afc43e (http://notmuchmail.org) Emacs/23.3.1 + (x86_64-unknown-linux-gnu) +Date: Fri, 24 Feb 2012 23:36:09 +0100 +Message-ID: <874nufeu5i.fsf@praet.org> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Gm-Message-State: + ALoCoQkhARCZKdt+xKoHeFd0pHjEkH417qOt/M2b7K+KzVaJg/9+s2r0lMTEISH91yP8zuFixmau +Cc: Notmuch Mail +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Fri, 24 Feb 2012 22:38:26 -0000 + +On Fri, 24 Feb 2012 14:42:53 +0400, Dmitry Kurochkin wrote: +> On Fri, 24 Feb 2012 00:09:13 +0100, Pieter Praet wrote: +> > * emacs/notmuch-show.el +> > +> > (notmuch-show-get-messages-ids): +> > If provided with optional arg SEPARATOR, return a string consisting +> > of all Message-Id's, separated by SEPARATOR. Also improve original +> > docstring wrt default return value. +> > +> > (notmuch-show-get-messages-ids-search): +> > Removed, as its functionality is now in `notmuch-show-get-messages-ids'. +> > +> > (notmuch-show-tag-all): +> > Call `notmuch-show-get-messages-ids' with SEPARATOR arg instead of +> > `notmuch-show-get-messages-ids-search'. +> > --- +> +> There is another similar case in notmuch.el: +> `notmuch-show-get-messages-ids' and +> `notmuch-show-get-messages-ids-search'. There may be more. +> +> Please change them as well. +> + +You mean `notmuch-search-find-thread-id-region{,-search}' ? + +They aren't relevant to this series, so I'll submit a separate patch +for that (later). A quick `rgrep' doesn't reveal any others, but if +you happen to stumble across any, feel free to point them out. + +> Regards, +> Dmitry +> +> > emacs/notmuch-show.el | 18 +++++++++--------- +> > 1 files changed, 9 insertions(+), 9 deletions(-) +> > +> > diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el +> > index 5fc0e43..4b37c77 100644 +> > --- a/emacs/notmuch-show.el +> > +++ b/emacs/notmuch-show.el +> > @@ -1334,17 +1334,17 @@ (defun notmuch-show-get-message-id () +> > "Return the message id of the current message." +> > (concat "id:\"" (notmuch-show-get-prop :id) "\"")) +> > +> > -(defun notmuch-show-get-messages-ids () +> > - "Return all message ids of messages in the current thread." +> > +(defun notmuch-show-get-messages-ids (&optional separator) +> > + "Return a list of Message-Id's of all messages in the current buffer. +> > + +> > +If provided with optional argument SEPARATOR, return a string +> > +instead, consisting of all Message-Id's separated by SEPARATOR." +> > (let ((message-ids)) +> > (notmuch-show-mapc t +> > (lambda () (push (notmuch-show-get-message-id) message-ids))) +> > - message-ids)) +> > - +> > -(defun notmuch-show-get-messages-ids-search () +> > - "Return a search string for all message ids of messages in the +> > -current thread." +> > - (mapconcat 'identity (notmuch-show-get-messages-ids) " or ")) +> > + (if separator +> > + (mapconcat 'identity message-ids separator) +> > + message-ids))) +> > +> > ;; dme: Would it make sense to use a macro for many of these? +> > +> > @@ -1633,7 +1633,7 @@ (defun notmuch-show-tag-all (&rest tag-changes) +> > +> > TAG-CHANGES is a list of tag operations for `notmuch-tag'." +> > (interactive (notmuch-read-tag-changes nil notmuch-show-thread-id)) +> > - (apply 'notmuch-tag (notmuch-show-get-messages-ids-search) tag-changes) +> > + (apply 'notmuch-tag (notmuch-show-get-messages-ids " or ") tag-changes) +> > (notmuch-show-mapc t +> > (lambda () +> > (let* ((current-tags (notmuch-show-get-tags)) +> > -- +> > 1.7.8.1 +> > + + +Peace + +-- +Pieter