From: Damien Cassou Date: Thu, 22 Nov 2012 18:40:36 +0000 (+0100) Subject: Re: [PATCH 3/4] emacs: Make tags that appear in `notmuch-show' clickable X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=55dd708d51f1258b447f4c2db8dd06b130870596;p=notmuch-archives.git Re: [PATCH 3/4] emacs: Make tags that appear in `notmuch-show' clickable --- diff --git a/78/715d7c6f77845d093bfe1798fe08ddc45234d3 b/78/715d7c6f77845d093bfe1798fe08ddc45234d3 new file mode 100644 index 000000000..839e6f1c4 --- /dev/null +++ b/78/715d7c6f77845d093bfe1798fe08ddc45234d3 @@ -0,0 +1,113 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 1794E431FB6 + for ; Thu, 22 Nov 2012 10:40:59 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.798 +X-Spam-Level: +X-Spam-Status: No, score=-0.798 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id YLd9oNOd9zhf for ; + Thu, 22 Nov 2012 10:40:58 -0800 (PST) +Received: from mail-la0-f53.google.com (mail-la0-f53.google.com + [209.85.215.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 6223B431FAF + for ; Thu, 22 Nov 2012 10:40:58 -0800 (PST) +Received: by mail-la0-f53.google.com with SMTP id w12so7011140lag.26 + for ; Thu, 22 Nov 2012 10:40:56 -0800 (PST) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; + h=mime-version:in-reply-to:references:from:date:message-id:subject:to + :cc:content-type; + bh=riJeMc5Pj9RVZlyP5PGJXzRBRipVwf3NKXbtCArgKT8=; + b=j73rfxNFL8kPguTIDXbgHPjFeQLgnhgCYGsDlCo972BwlfjuahBZ4BoQV07LTEF/9C + nTFYFQ8G/sJd0yvNFZhBR8cr8UbDlePY4cph8g5VG6GgwvHK5BvyyjSIGsXK+lBczoJf + nIeti6F6ZANdqxkYj9q7+bkI7O8aFNTc/psILkbkmAd0go3BUstU2Ioqyj0rn8xrRRad + r5vRwiwbG6T3kWFhWnmY7TWfMG8KxbQAx7w/5P+Wb/5IdoDrJ8kFgG3zIU0oapPMkrBp + Q6vxMq7CKLDBfu+MyGE08Dm0pV3pgBOjruJTcxmqD9IVgY487pLoOT7ab04k0mPvJj13 + 7Yxg== +Received: by 10.152.108.42 with SMTP id hh10mr1273742lab.4.1353609656712; Thu, + 22 Nov 2012 10:40:56 -0800 (PST) +MIME-Version: 1.0 +Received: by 10.112.44.70 with HTTP; Thu, 22 Nov 2012 10:40:36 -0800 (PST) +In-Reply-To: <87a9uepl2t.fsf@qmul.ac.uk> +References: <1353266322-20318-1-git-send-email-damien.cassou@gmail.com> + <1353266322-20318-4-git-send-email-damien.cassou@gmail.com> + <87a9uepl2t.fsf@qmul.ac.uk> +From: Damien Cassou +Date: Thu, 22 Nov 2012 19:40:36 +0100 +Message-ID: + +Subject: Re: [PATCH 3/4] emacs: Make tags that appear in `notmuch-show' + clickable +To: Mark Walters +Content-Type: multipart/alternative; boundary=bcaec54fb9c6c0bd9404cf19ce0e +Cc: notmuch mailing list +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 22 Nov 2012 18:40:59 -0000 + +--bcaec54fb9c6c0bd9404cf19ce0e +Content-Type: text/plain; charset=ISO-8859-1 + +Hi, + +On Mon, Nov 19, 2012 at 12:06 AM, Mark Walters wrote: + +> This patch adds buttons for every tag in show mode which means that +> tabbing down to an attachment (or other button) is rather slower. As +> someone who is not going to use the tag buttons (at least not very +> often) Is it possible to avoid this? perhaps by making the button +> optional or making the button only mouse clickable? (Since the buttons +> in the headerline are not tabbable to then the latter might be +> reasonable.) +> + +you are perfectly right. In the upcoming patch I made the buttons so that +TAB won't stop at them ('skip t) but you can still activate them with RET +or a mouse click. Is that ok? + +-- +Damien Cassou +http://damiencassou.seasidehosting.st + +"Success is the ability to go from one failure to another without losing +enthusiasm." +Winston Churchill + +--bcaec54fb9c6c0bd9404cf19ce0e +Content-Type: text/html; charset=ISO-8859-1 + +
Hi,

On Mon, Nov 19, 2012 at 12:06 AM, Mark Walters <markwalters1009@gmail.com> wrote:
+ +
This patch adds buttons for every tag in show mode which means that
+tabbing down to an attachment (or other button) is rather slower. As
+someone who is not going to use the tag buttons (at least not very
+often) Is it possible to avoid this? perhaps by making the button
+optional or making the button only mouse clickable? (Since the buttons
+in the headerline are not tabbable to then the latter might be
+reasonable.)

you are perfectly right. In the upcoming patch I made the buttons so that TAB won't stop at them ('skip t) but you can still activate them with RET or a mouse click. Is that ok?
+ +
--
Damien Cassou
http://damiencassou.seasidehosting.st

"Success is the ability to go from one failure to another without losing enthusiasm."
+ +Winston Churchill
+
+ +--bcaec54fb9c6c0bd9404cf19ce0e--