From: Austin Clements Date: Wed, 18 Jul 2012 20:51:40 +0000 (+2000) Subject: Re: [PATCH 0/7] Various fixes for the Go bindings X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=5003f20dd9dc876b86f3b9d1828271fe63c20d2b;p=notmuch-archives.git Re: [PATCH 0/7] Various fixes for the Go bindings --- diff --git a/6d/f50378d79257111498f30b32c5780989255437 b/6d/f50378d79257111498f30b32c5780989255437 new file mode 100644 index 000000000..60834c321 --- /dev/null +++ b/6d/f50378d79257111498f30b32c5780989255437 @@ -0,0 +1,95 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 159DF431FC0 + for ; Wed, 18 Jul 2012 13:51:44 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id QI0Q9eMx2e0M for ; + Wed, 18 Jul 2012 13:51:43 -0700 (PDT) +Received: from dmz-mailsec-scanner-1.mit.edu (DMZ-MAILSEC-SCANNER-1.MIT.EDU + [18.9.25.12]) + by olra.theworths.org (Postfix) with ESMTP id 946FE431FAE + for ; Wed, 18 Jul 2012 13:51:43 -0700 (PDT) +X-AuditID: 1209190c-b7f806d000006b87-90-500721df9e0b +Received: from mailhub-auth-1.mit.edu ( [18.9.21.35]) + by dmz-mailsec-scanner-1.mit.edu (Symantec Messaging Gateway) with SMTP + id EE.97.27527.FD127005; Wed, 18 Jul 2012 16:51:43 -0400 (EDT) +Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) + by mailhub-auth-1.mit.edu (8.13.8/8.9.2) with ESMTP id q6IKpg1J004671; + Wed, 18 Jul 2012 16:51:42 -0400 +Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) + (authenticated bits=0) + (User authenticated as amdragon@ATHENA.MIT.EDU) + by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q6IKpepF007930 + (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); + Wed, 18 Jul 2012 16:51:41 -0400 (EDT) +Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77) + (envelope-from ) + id 1SrbDg-0001Ez-Jp; Wed, 18 Jul 2012 16:51:40 -0400 +Date: Wed, 18 Jul 2012 16:51:40 -0400 +From: Austin Clements +To: Adrien Bustany +Subject: Re: [PATCH 0/7] Various fixes for the Go bindings +Message-ID: <20120718205140.GW31670@mit.edu> +References: <1342636475-16057-1-git-send-email-adrien@bustany.org> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +Content-Disposition: inline +In-Reply-To: <1342636475-16057-1-git-send-email-adrien@bustany.org> +User-Agent: Mutt/1.5.21 (2010-09-15) +X-Brightmail-Tracker: + H4sIAAAAAAAAA+NgFmphleLIzCtJLcpLzFFi42IR4hRV1r2vyB5g8Gkmv8X6O2vZLK7fnMns + wOTx8cA9Jo9nq24xBzBFcdmkpOZklqUW6dslcGV8+7aIuWAvW8XL/fMZGxins3YxcnJICJhI + XH4/ixHCFpO4cG89WxcjF4eQwD5GiYZda5ghnA2MEhfXrGaCcE4ySczedIkdwlnCKHHhwGqw + fhYBVYlrryazgdhsAhoS2/YvB4uLCKhL7OhsB7OZBaQlvv1uZgKxhQWsJN68/sgOYvMK6EhM + +vwcrEZIwEli7bzHzBBxQYmTM5+wQPRqSdz49xKolwNszvJ/HCBhTgFniRtbH4ONERVQkZhy + chvbBEahWUi6ZyHpnoXQvYCReRWjbEpulW5uYmZOcWqybnFyYl5eapGuoV5uZoleakrpJkZw + YEvy7GB8c1DpEKMAB6MSD++DXawBQqyJZcWVuYcYJTmYlER5PwmxBwjxJeWnVGYkFmfEF5Xm + pBYfYpTgYFYS4X0gCJTjTUmsrEotyodJSXOwKInzXk656S8kkJ5YkpqdmlqQWgSTleHgUJLg + FQNGsJBgUWp6akVaZk4JQpqJgxNkOA/QcBeQGt7igsTc4sx0iPwpRkUpcV5VkIQASCKjNA+u + F5Z4XjGKA70izOsKUsUDTFpw3a+ABjMBDeYuZgMZXJKIkJICJpu1k42eVz6sLWfUCDqq3y4t + PiOB6fJkhVeCO2Y+bjFw/Ruzu8tp6ZwLQo/ThAv3m3hKFtW7PVWWSp2o2X3nlcbq1Qlr89Im + GmyYGarcfL4kIO5IilkY47YfZ0zYw1TfeIssu6W1fQ7Li08LD/0+qbe/yPCwk4zjVmP+efry + 050XP3s0+7WhsRJLcUaioRZzUXEiANdN180XAwAA +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 18 Jul 2012 20:51:44 -0000 + +This series looks good to me other than the few things I commented on. +It's nice to see the Go bindings get a bit of love! + +Quoth Adrien Bustany on Jul 18 at 9:34 pm: +> The following patches fix some serious memory management issues with +> the Go bindings, and add some missing functions as well. +> +> Adrien Bustany (7): +> go: Use iota in enum bindings +> go: Add missing MESSAGE_FLAG_EXCLUDED in Flag enum +> go: Allow notmuch objects to be garbage collected +> go: Make Destroy functions safe to call several times +> go: Partially bind notmuch_database_upgrade +> go: Bind notmuch_database_find_message_by_filename +> go: Bind notmuch_thread_t functions +> +> bindings/go/src/notmuch/notmuch.go | 471 ++++++++++++++++++++++++++++++++++-- +> 1 files changed, 447 insertions(+), 24 deletions(-) +>