From: Jani Nikula Date: Fri, 8 Mar 2013 06:26:33 +0000 (+0200) Subject: Re: [PATCH] build: fix out-of-tree builds X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=4c4a8b7a1dfeb92282bcb5e1857ec77ca044b826;p=notmuch-archives.git Re: [PATCH] build: fix out-of-tree builds --- diff --git a/c4/ee0cb49069b2811556725e6190f856acf93573 b/c4/ee0cb49069b2811556725e6190f856acf93573 new file mode 100644 index 000000000..be6c217c5 --- /dev/null +++ b/c4/ee0cb49069b2811556725e6190f856acf93573 @@ -0,0 +1,102 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id BA68B431FAF + for ; Thu, 7 Mar 2013 22:26:40 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id hrUtGpE0d6JG for ; + Thu, 7 Mar 2013 22:26:40 -0800 (PST) +Received: from mail-la0-f47.google.com (mail-la0-f47.google.com + [209.85.215.47]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id E3C97431FAE + for ; Thu, 7 Mar 2013 22:26:39 -0800 (PST) +Received: by mail-la0-f47.google.com with SMTP id fj20so1326420lab.20 + for ; Thu, 07 Mar 2013 22:26:38 -0800 (PST) +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=google.com; s=20120113; + h=x-received:from:to:subject:in-reply-to:references:user-agent:date + :message-id:mime-version:content-type:x-gm-message-state; + bh=GCARrx0a/jcuFuXkWouRbMpI5WJoS9tjagdDQB7Bgu0=; + b=RUFdCI4KkK2hB/adUjyTneDcfPgYJrvHoMJSR3ivuHj+88CdymVQZDJp0ZYiRlmqcM + Z5xF0+BkOla5HrWFG7BxqxrUxZINL/Tj2+ZMt9/J4U/cW7e/6KbrXkptplwHa1y1M0Dx + beNFL25KSW+3uw9/win1C9pfbCh3pCrC4r5qgxkQ6rMM3YIHc7J9NDOMBstjkjHLSGjB + Iv4FsImfufzdegfROdiccRW8b18YfylIo9MZC8AGOdFxJ/Qcv6YdGDmsGrSB5QZwUnZW + NXd9uWp4T5bK3rluW4IJE48CDhQyNcXlJ7VU835jQ0bcdC2e3lUaT0qyHpm17/z7Ms+j + WM2g== +X-Received: by 10.112.9.104 with SMTP id y8mr563285lba.132.1362723996856; + Thu, 07 Mar 2013 22:26:36 -0800 (PST) +Received: from localhost (dsl-hkibrasgw4-50df51-27.dhcp.inet.fi. + [80.223.81.27]) + by mx.google.com with ESMTPS id mq7sm1966866lab.1.2013.03.07.22.26.34 + (version=TLSv1.2 cipher=RC4-SHA bits=128/128); + Thu, 07 Mar 2013 22:26:35 -0800 (PST) +From: Jani Nikula +To: David Bremner , notmuch@notmuchmail.org +Subject: Re: [PATCH] build: fix out-of-tree builds +In-Reply-To: <87txombkra.fsf@zancas.localnet> +References: <1362692068-30142-1-git-send-email-jani@nikula.org> + <87txombkra.fsf@zancas.localnet> +User-Agent: Notmuch/0.15.2+45~g53c33be (http://notmuchmail.org) Emacs/24.2.1 + (x86_64-pc-linux-gnu) +Date: Fri, 08 Mar 2013 08:26:33 +0200 +Message-ID: <877glimmp2.fsf@nikula.org> +MIME-Version: 1.0 +Content-Type: text/plain +X-Gm-Message-State: + ALoCoQljFxHsQCYqhfrCvQVwiYUqDZGTuwjFUUve5sDtxaiCkIBeSpB+8WKuIiXw0KnwD2At3suy +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Fri, 08 Mar 2013 06:26:40 -0000 + +On Fri, 08 Mar 2013, David Bremner wrote: +> Jani Nikula writes: +>> --- +>> +>> David, does the perf test still work for you with these changes? +> +> make perf-test OPTIONS=--medium +> +> runs the time tests, but then fails with +> +> ./performance-test/notmuch-memory-test --medium +> make[1]: ./performance-test/notmuch-memory-test: Command not found +> make[1]: *** [memory-test] Error 127 +> make[1]: Leaving directory `/home/bremner/software/upstream/notmuch' +> make: *** [perf-test] Error 2 +> +> To be honest, the line +> +> TIME_TEST_SCRIPT :=$ $(srcdir)/$(dir)/notmuch-time-test +> +> looks pretty strange to me, but that seems to be the one that is working + +Oof, to be honest, that was a typo. The minimal change required to +*build* is: + +-include $(dir)/version.sh ++include $(srcdir)/$(dir)/version.sh + +and the rest was just a poor attempt at making perf test work too. I'll +look into it. + +Jani. +