From: Fabian Groffen <grobian@gentoo.org>
Date: Sat, 19 Jan 2008 10:46:59 +0000 (-0000)
Subject:    Merged from trunk 9205:9206
X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=4ba3d27d6dac5d4c4a59b3632b4228cd3da57841;p=portage.git

   Merged from trunk 9205:9206

   | 9206    | Check for quoted ${A}. Thanks to maekke for this patch.      |
   | zmedico |                                                              |

svn path=/main/branches/prefix/; revision=9207
---

diff --git a/pym/repoman/checks.py b/pym/repoman/checks.py
index b4f1b016e..2c8d25e2f 100644
--- a/pym/repoman/checks.py
+++ b/pym/repoman/checks.py
@@ -190,10 +190,21 @@ class Autotools(LineCheck):
 			return ("Direct calls to '%s'" % m.group(2)) + \
 				" instead of using autotools.eclass on line: %d"
 
+class EbuildQuotedA(LineCheck):
+	"""Ensure ebuilds have no quoting around ${A}"""
+
+	repoman_check_name = 'ebuild.minorsyn'
+	a_quoted = re.compile(r'.*\"\$(\{A\}|A)\"')
+
+	def check(self, num, line):
+		match = self.a_quoted.match(line)
+		if match:
+			return "Quoted \"${A}\" on line: %d"
+
 _constant_checks = tuple((c() for c in (Autotools,
 	EbuildWhitespace, EbuildQuote,
 	EbuildAssignment, EbuildUselessDodoc,
-	EbuildUselessCdS, EbuildNestedDie)))
+	EbuildUselessCdS, EbuildNestedDie, EbuildQuotedA)))
 
 def run_checks(contents, st_mtime):
 	checks = list(_constant_checks)