From: Justus Winter <4winter@informatik.uni-hamburg.de> Date: Mon, 30 Apr 2012 19:54:20 +0000 (+0200) Subject: Re: [PATCH] go: Update to the current notmuch_database_find_message API X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=4b82183b8f6e5b91e8058ca023d350f22c4754f9;p=notmuch-archives.git Re: [PATCH] go: Update to the current notmuch_database_find_message API --- diff --git a/ab/d5a1d89b3ead4652f7d78636913c383be47acc b/ab/d5a1d89b3ead4652f7d78636913c383be47acc new file mode 100644 index 000000000..6a4ade5aa --- /dev/null +++ b/ab/d5a1d89b3ead4652f7d78636913c383be47acc @@ -0,0 +1,102 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 7AEF5431FAF + for ; Mon, 30 Apr 2012 12:54:30 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id fUYWAnmNCNz4 for ; + Mon, 30 Apr 2012 12:54:29 -0700 (PDT) +Received: from mail.cryptobitch.de (cryptobitch.de [88.198.7.68]) + (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 20419431FAE + for ; Mon, 30 Apr 2012 12:54:29 -0700 (PDT) +Received: from mail.jade-hamburg.de (mail.jade-hamburg.de [85.183.11.228]) + (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) + (No client certificate requested) + by mail.cryptobitch.de (Postfix) with ESMTPSA id B811B584BAB + for ; Mon, 30 Apr 2012 21:54:24 +0200 (CEST) +Received: by mail.jade-hamburg.de (Postfix, from userid 401) + id 13941DF2A5; Mon, 30 Apr 2012 21:54:24 +0200 (CEST) +Received: from thinkbox.jade-hamburg.de (unknown [10.1.1.153]) + (using TLSv1 with cipher AES256-SHA (256/256 bits)) + (No client certificate requested) (Authenticated sender: teythoon) + by mail.jade-hamburg.de (Postfix) with ESMTPSA id 7767FDF2A1; + Mon, 30 Apr 2012 21:54:22 +0200 (CEST) +Received: from teythoon by thinkbox.jade-hamburg.de with local (Exim 4.77) + (envelope-from ) + id 1SOwfs-0003vx-FK; Mon, 30 Apr 2012 21:54:20 +0200 +Content-Type: text/plain; charset="utf-8" +MIME-Version: 1.0 +Content-Transfer-Encoding: quoted-printable +To: David Bremner +From: Justus Winter <4winter@informatik.uni-hamburg.de> +In-Reply-To: <87lildph9w.fsf@zancas.localnet> +References: <1335649518-1970-1-git-send-email-amdragon@mit.edu> + <87lildph9w.fsf@zancas.localnet> +Message-ID: <20120430195420.2528.48612@thinkbox.jade-hamburg.de> +User-Agent: alot/0.3+ +Subject: Re: [PATCH] go: Update to the current notmuch_database_find_message + API +Date: Mon, 30 Apr 2012 21:54:20 +0200 +Cc: , notmuch mailing list +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 30 Apr 2012 19:54:30 -0000 + +Quoting David Bremner (2012-04-30 13:53:47) +> Austin Clements writes: +> = + +> > The signature of notmuch_database_find_message was changed in 02a30767 +> > to report errors and the Go bindings were never updated. This brings +> > the Go bindings in sync with that change and at least makes them +> > compile with Go r60.3, the last release before Go 1. +> = + +> I don't have any easy way to test this, since the current versions in = + +> Debian are all based on Go 1. On the other hand I guess it doesn't make +> things worse. Anybody have any objections to this patch? + +lgtm. + +> In the long run we have to decide what to do about these bindings. Seb +> (or anyone else) are you interested in porting them to Go 1 and +> maintaining them? Otherwise it may be time to deprecate them. + +I care enough for the go environment to keep the go bindings +working. I've updated the bindings, the build infrastructure and the +notmuch-addrlookup utility to go 1. I'll send a patch series as a +followup that is meant to be applied upon Austins patch. + +The last patch in the series is a cleanup of the source code done with +the gofmt utility. Go is somewhat strict in its coding conventions, +but there is a utility that magically formats code. This makes the go +code in the wild remarkably consistent. We should stick to the +conventions too, hence this patch even if it breaks git blame +somewhat. + +I haven't tested the bindings in depth, but the notmuch-addrlookup +utility seems to be working fine. + +Cheers, +Justus