From: Dmitry Kurochkin Date: Sat, 5 May 2012 14:39:47 +0000 (+0400) Subject: [PATCH 2/2] emacs: fix custom queries section customization widget in notmuch-hello X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=44aec123507745aecd558c8364c89f79f0c7982f;p=notmuch-archives.git [PATCH 2/2] emacs: fix custom queries section customization widget in notmuch-hello --- diff --git a/72/ddd8784d44a48e5216e4172a6a6cc9e88c46cb b/72/ddd8784d44a48e5216e4172a6a6cc9e88c46cb new file mode 100644 index 000000000..48c444f5b --- /dev/null +++ b/72/ddd8784d44a48e5216e4172a6a6cc9e88c46cb @@ -0,0 +1,99 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 945CE431FC4 + for ; Sat, 5 May 2012 07:41:54 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.799 +X-Spam-Level: +X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id VagEHZTTBDCd for ; + Sat, 5 May 2012 07:41:53 -0700 (PDT) +Received: from mail-lb0-f181.google.com (mail-lb0-f181.google.com + [209.85.217.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 17867431FC9 + for ; Sat, 5 May 2012 07:41:49 -0700 (PDT) +Received: by lbbgk8 with SMTP id gk8so2900763lbb.26 + for ; Sat, 05 May 2012 07:41:48 -0700 (PDT) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; + h=from:to:subject:date:message-id:x-mailer:in-reply-to:references; + bh=Xu1wZNViheYh+QOVjwrwiTA6Uq5eWWcOEML2gIZXwT8=; + b=BIGO0KuJxCZ8zCjR9wppGhPvCslhy49lzAfLokc8Jr1vumMUg/hVKVlAMBqhKX83O0 + SM2Ly9gQ7E4WrbchxY/u7xcY+kTd4sGoL8xxwkfq7+IaGbfl0I1YeA2HQ8PYRShcGY+i + X/PjgeistwMEQss3S0C25oJuWD/zt/6Q+i0Zuyk81hIPf/kMvbkXd53NnJTbABF4hgtg + qixR4e/5NMz4RB08qAxlyXLjmoZy38hyhHUeACtVHQrE6Wx87fPAY2PRKQpUtTrcLgwT + bWorEjFVJFYjOQOnBT3t/SdPzZa4BJvRRTEQWZqHsJWRSna675t/QtyyBwMosG8GwRAr + er1A== +Received: by 10.112.103.194 with SMTP id fy2mr4495738lbb.64.1336228908360; + Sat, 05 May 2012 07:41:48 -0700 (PDT) +Received: from localhost ([91.144.186.21]) + by mx.google.com with ESMTPS id fx5sm15365630lbb.5.2012.05.05.07.41.47 + (version=TLSv1/SSLv3 cipher=OTHER); + Sat, 05 May 2012 07:41:47 -0700 (PDT) +From: Dmitry Kurochkin +To: notmuch@notmuchmail.org +Subject: [PATCH 2/2] emacs: fix custom queries section customization widget in + notmuch-hello +Date: Sat, 5 May 2012 18:39:47 +0400 +Message-Id: <1336228787-24936-2-git-send-email-dmitry.kurochkin@gmail.com> +X-Mailer: git-send-email 1.7.10 +In-Reply-To: <1336228787-24936-1-git-send-email-dmitry.kurochkin@gmail.com> +References: <1336228787-24936-1-git-send-email-dmitry.kurochkin@gmail.com> +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 05 May 2012 14:41:54 -0000 + +The customization widget referred to a non-existing function +`notmuch-hello-insert-query-list'. The patch changes it to the +correct one - `notmuch-hello-insert-searches'. The relevant test is +fixed now. +--- + emacs/notmuch-hello.el | 2 +- + test/emacs-hello | 1 - + 2 files changed, 1 insertion(+), 2 deletions(-) + +diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el +index f10d98d..684bedc 100644 +--- a/emacs/notmuch-hello.el ++++ b/emacs/notmuch-hello.el +@@ -187,7 +187,7 @@ This should only be set by `notmuch-hello-insert-search'.") + :tag "Customized queries section (see docstring for details)" + :type + `(list :tag "" +- (const :tag "" notmuch-hello-insert-query-list) ++ (const :tag "" notmuch-hello-insert-searches) + (string :tag "Title for this section") + (repeat :tag "Queries" + (cons (string :tag "Name") (string :tag "Query"))) +diff --git a/test/emacs-hello b/test/emacs-hello +index 936d00e..a998dc4 100755 +--- a/test/emacs-hello ++++ b/test/emacs-hello +@@ -52,7 +52,6 @@ test_emacs "(let* ((widget (widget-create 'notmuch-hello-tags-section)) + test_expect_equal_file OUTPUT $EXPECTED/notmuch-hello-empty-custom-tags-section + + test_begin_subtest "Empty custom queries section" +-test_subtest_known_broken + test_emacs "(let* ((widget (widget-create 'notmuch-hello-query-section)) + (notmuch-hello-sections (list (widget-value widget)))) + (notmuch-hello) +-- +1.7.10 +