From: David Bremner <david@tethera.net>
Date: Sat, 20 Jul 2013 12:36:41 +0000 (+2100)
Subject: Re: [PATCH] crypto: return NULL cryptoctx if protocol string is empty.
X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=4448e8bea92f815c37d03ff7b134e6a8b2e90833;p=notmuch-archives.git

Re: [PATCH] crypto: return NULL cryptoctx if protocol string is empty.
---

diff --git a/7d/31e7aa9ac31014fc3d3633476ad7c38cbef8a1 b/7d/31e7aa9ac31014fc3d3633476ad7c38cbef8a1
new file mode 100644
index 000000000..ce0f44ec0
--- /dev/null
+++ b/7d/31e7aa9ac31014fc3d3633476ad7c38cbef8a1
@@ -0,0 +1,65 @@
+Return-Path: <david@tethera.net>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id C6BC4431FAE
+	for <notmuch@notmuchmail.org>; Sat, 20 Jul 2013 05:36:53 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 0
+X-Spam-Level: 
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
+	autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id Xa60ECorVr+O for <notmuch@notmuchmail.org>;
+	Sat, 20 Jul 2013 05:36:46 -0700 (PDT)
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])
+	(using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
+	(No client certificate requested)
+	by olra.theworths.org (Postfix) with ESMTPS id 14A79431FAF
+	for <notmuch@notmuchmail.org>; Sat, 20 Jul 2013 05:36:46 -0700 (PDT)
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)
+	(envelope-from <david@tethera.net>)
+	id 1V0WOy-0002nc-OY; Sat, 20 Jul 2013 09:36:44 -0300
+Received: (nullmailer pid 23582 invoked by uid 1000); Sat, 20 Jul 2013
+	12:36:41 -0000
+From: David Bremner <david@tethera.net>
+To: Jameson Graef Rollins <jrollins@finestructure.net>, Notmuch Mail
+	<notmuch@notmuchmail.org>
+Subject: Re: [PATCH] crypto: return NULL cryptoctx if protocol string is
+ empty.
+In-Reply-To: <1374248172-14199-1-git-send-email-jrollins@finestructure.net>
+References: <id:51E95500.8000404@fifthhorseman.net>
+	<1374248172-14199-1-git-send-email-jrollins@finestructure.net>
+User-Agent: Notmuch/0.15.2+223~g3484372 (http://notmuchmail.org) Emacs/24.3.1
+	(x86_64-pc-linux-gnu)
+Date: Sat, 20 Jul 2013 09:36:41 -0300
+Message-ID: <87txjpe7c6.fsf@zancas.localnet>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Sat, 20 Jul 2013 12:36:53 -0000
+
+Jameson Graef Rollins <jrollins@finestructure.net> writes:
+
+> Badly formed messages that don't specify a protocol in
+> signed/encrypted parts, end up with a protocol of NULL.  strcasecmp in
+> notmuch_crypto_get_context then segfaults when trying to check it
+> against known protocols.  If the protocol is NULL, just return an
+> empty context immediately (with appropriate message.)
+
+Pushed, thanks for the fix
+
+d