From: Mark Walters Date: Thu, 28 Jun 2012 07:02:44 +0000 (+0100) Subject: Re: [PATCH] Restore original keybinding ('r' = reply-to-all) X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=435489ec7dd33c009244bb619e3145de2065d4a8;p=notmuch-archives.git Re: [PATCH] Restore original keybinding ('r' = reply-to-all) --- diff --git a/ee/268a26be48efae4d452041b777a4324f82fdc7 b/ee/268a26be48efae4d452041b777a4324f82fdc7 new file mode 100644 index 000000000..a40584e01 --- /dev/null +++ b/ee/268a26be48efae4d452041b777a4324f82fdc7 @@ -0,0 +1,135 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 81204431FAF + for ; Thu, 28 Jun 2012 00:03:04 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -1.098 +X-Spam-Level: +X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id MLdi3x68aivJ for ; + Thu, 28 Jun 2012 00:03:03 -0700 (PDT) +Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 9267D431FB6 + for ; Thu, 28 Jun 2012 00:03:03 -0700 (PDT) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail2.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1Sk8kb-0003HU-VC; Thu, 28 Jun 2012 08:02:56 +0100 +Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223] + helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69) + (envelope-from ) + id 1Sk8kb-0002S1-FQ; Thu, 28 Jun 2012 08:02:49 +0100 +From: Mark Walters +To: David Bremner , + Jameson Graef Rollins , + Carl Worth , notmuch@notmuchmail.org +Subject: Re: [PATCH] Restore original keybinding ('r' = reply-to-all) +In-Reply-To: <87hatwqoz9.fsf@maritornes.cs.unb.ca> +References: <1340815565-21083-1-git-send-email-cworth@cworth.org> + <87obo4zljq.fsf@servo.finestructure.net> + <87hatwqoz9.fsf@maritornes.cs.unb.ca> +User-Agent: Notmuch/0.13.2+63~g548a9bf (http://notmuchmail.org) Emacs/23.4.1 + (x86_64-pc-linux-gnu) +Date: Thu, 28 Jun 2012 08:02:44 +0100 +Message-ID: <87vcibnckr.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Sender-Host-Address: 94.192.233.223 +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: c8cba90a78ca7e5d2906b9eaab1ecb21 (of first 20000 bytes) +X-SpamAssassin-Score: -1.8 +X-SpamAssassin-SpamBar: - +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored -1.8 points. + Summary of the scoring: + * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, + * medium trust + * [138.37.6.40 listed in list.dnswl.org] + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay + * domain + * 0.5 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 28 Jun 2012 07:03:04 -0000 + +On Thu, 28 Jun 2012, David Bremner wrote: +> On Wed, 27 Jun 2012 10:55:53 -0700, Jameson Graef Rollins wrote: +>> On Wed, Jun 27 2012, Carl Worth wrote: +>> > Since the beginning of time, the emacs interface provided a keybinding +>> > of 'r' to reply to a message, (and originally, all recipients). +>> > +>> > Then, before release 0.12 the emacs interface acquired a new +>> > reply-to-sender only feature. In commit +>> > f02b475fa781bb5df3358c73213e7633a99f016e the new feature was put onto +>> > the original keybinding, (and reply-to-all was moved to 'R'). +>> > +>> > This restores the original keybinding and uses the new keybinding for +>> > the new feature. +> +> My bias is probably apparent in that I pushed the original patch... +> +> I think the there is potential for unfortunate mistakes with either set +> of bindings. On the one hand sending replies to unintended people can be +> very embarrassing. On the other hand, forgetting to reply to the group +> can also be problematic. The latter is easier to correct, _if_ it is +> detected. +> +> When we discussed this earlier, there were people who supported both +> options as default. I broke the tie based on my experience with other +> mailers, and the fact that apparently I worry more about sending things +> to too many people than to too few. Obviously Carl would have chosen +> differently. +> +> It would be easy enough to add a customization variable to swap the +> outcomes of r and R; iirc this is what wanderlust (or maybe VM) does. It +> seems that would not really make people any happier, since the complaint +> is not that it is hard to do the keybindings, but that the bindings +> changed. +> +> I do worry that by changing back, we annoy a whole new set of +> people. I'm not worried for myself; I can add the equivalent keybindings +> to my .emacs. I do (hypothetically) sympathize with people who just got +> used to the new behaviour and are surprised again. + +Hi + +I agree with David on all the above and I do think that the fact that +most other mail user agents (in my experience) default to reply to +sender is a point in favour of the status quo. + +Of course, it is not my project so I am happy to go along with whatever +choice is made. + +On a practical note to help with Daniel's point that it is easier to +remove recipients than add them: would it be possible to add a key +command to message mode to add the other addresses? Or put the other +addresses into the kill ring so they could be pasted into a cc line? + +Best wishes + +Mark