From: Jani Nikula Date: Thu, 26 Jan 2012 21:58:51 +0000 (+0200) Subject: Re: [PATCH] emacs: add default value to notmuch-search-line-faces X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=42d9bbb1ec05fbba944b9bf44204cc3d729a78ca;p=notmuch-archives.git Re: [PATCH] emacs: add default value to notmuch-search-line-faces --- diff --git a/2b/5714baef3aeadbe81584a89374c96ff1001e56 b/2b/5714baef3aeadbe81584a89374c96ff1001e56 new file mode 100644 index 000000000..11dc106a9 --- /dev/null +++ b/2b/5714baef3aeadbe81584a89374c96ff1001e56 @@ -0,0 +1,123 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 8F264431FAF + for ; Thu, 26 Jan 2012 13:58:57 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id gtd-MBqyC1Vy for ; + Thu, 26 Jan 2012 13:58:57 -0800 (PST) +Received: from mail-lpp01m010-f53.google.com (mail-lpp01m010-f53.google.com + [209.85.215.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 9FED2431FAE + for ; Thu, 26 Jan 2012 13:58:56 -0800 (PST) +Received: by lahd3 with SMTP id d3so672226lah.26 + for ; Thu, 26 Jan 2012 13:58:55 -0800 (PST) +Received: by 10.112.100.2 with SMTP id eu2mr1094964lbb.97.1327615135010; + Thu, 26 Jan 2012 13:58:55 -0800 (PST) +Received: from localhost (dsl-hkibrasgw4-fe50f800-253.dhcp.inet.fi. + [84.248.80.253]) + by mx.google.com with ESMTPS id nu4sm4160892lab.4.2012.01.26.13.58.52 + (version=SSLv3 cipher=OTHER); Thu, 26 Jan 2012 13:58:53 -0800 (PST) +From: Jani Nikula +To: Austin Clements +Subject: Re: [PATCH] emacs: add default value to notmuch-search-line-faces +In-Reply-To: <20120126194146.GG1940@mit.edu> +References: <1327605679-15213-1-git-send-email-jani@nikula.org> + <20120126194146.GG1940@mit.edu> +User-Agent: Notmuch/0.11+95~g1c29b96 (http://notmuchmail.org) Emacs/23.3.1 + (i686-pc-linux-gnu) +Date: Thu, 26 Jan 2012 23:58:51 +0200 +Message-ID: <87liounn1g.fsf@nikula.org> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 26 Jan 2012 21:58:57 -0000 + +On Thu, 26 Jan 2012 14:41:46 -0500, Austin Clements wrote: +> Quoth Jani Nikula on Jan 26 at 9:21 pm: +> > Add default value to notmuch-search-line-faces to show "unread" +> > messages in bold, and "flagged" messages in red, to have some visual +> > indication of important messages in search results. This should be +> > helpful for new users. +> > +> > "unread" tag is quite obvious, and handled specially both in the lib +> > and emacs ui. "flagged" is synced to maildir F flag in the lib. If one +> > syncs the maildir to IMAP, this also translates to corresponding IMAP +> > flag. (This is "starred" in GMail and Android.) +> > +> > Signed-off-by: Jani Nikula +> +> While I'm sure this can be bikeshod to death, I do have one legitimate +> concern (and one illegitimate). +> +> I completely agree with what you said on IRC, though, that setting +> this to non-nil is more about making this capability more discoverable +> to new users than trying to come up with the perfect faces. + +Thanks for repeating that here too before full blown bikeshedding. I'm +just trying to help other people find this option quicker than I and +some others did... + +> > --- +> > emacs/notmuch.el | 3 ++- +> > 1 files changed, 2 insertions(+), 1 deletions(-) +> > +> > diff --git a/emacs/notmuch.el b/emacs/notmuch.el +> > index 6b2c252..551ea9d 100644 +> > --- a/emacs/notmuch.el +> > +++ b/emacs/notmuch.el +> > @@ -662,7 +662,8 @@ This function advances the next thread when finished." +> > (goto-char (point-min)) +> > (forward-line (1- notmuch-search-target-line)))))))) +> > +> > -(defcustom notmuch-search-line-faces nil +> > +(defcustom notmuch-search-line-faces '(("unread" :weight bold) +> +> As much as I would like this, many terminals don't visually +> distinguish between the default face and the default face in bold. + +Would it really matter, though? People on such terminals are probably +aware they are missing out on a bunch of visual stuff. But please do +suggest an alternative that could be "composited" with the :foreground +setting below for "unread" and "flagged" threads. + +> > + ("flagged" :foreground "red")) +> +> Red is pretty universally used to indicate danger or a serious +> condition, while "flagged" is simply supposed to draw attention. I +> would say blue as a neutral and distinct indicator, but it also has +> poor visibility (I used to use blue, but found that when scanning my +> mail, I would habitually skip over flagged messages because they were +> dark, which was the opposite of what I wanted). Personally I've +> settled on yellow; it's visually distinct enough to be easily +> noticeable and bright enough that I don't skip over it, though it +> obviously wouldn't work on a light background. + +Can be yellow, I don't really care that much. But isn't a light +background the default for emacs in most distros? If that matters, +*shrug*. + + +BR, +Jani.