From: Mark Walters Date: Mon, 13 Feb 2012 18:16:44 +0000 (+0000) Subject: Re: [RFC PATCH v2 0/3] notmuch-pick: an emacs threaded message view with split-pane X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=41ff6553eea27696e8c5592b1b4dc1031b40c1c8;p=notmuch-archives.git Re: [RFC PATCH v2 0/3] notmuch-pick: an emacs threaded message view with split-pane --- diff --git a/89/e2778bff002a999e8260e9fd9183e00af55ba1 b/89/e2778bff002a999e8260e9fd9183e00af55ba1 new file mode 100644 index 000000000..96ec64575 --- /dev/null +++ b/89/e2778bff002a999e8260e9fd9183e00af55ba1 @@ -0,0 +1,135 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 69EDF431FBF + for ; Mon, 13 Feb 2012 10:15:29 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -1.098 +X-Spam-Level: +X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id R-Wv+nvXKh3e for ; + Mon, 13 Feb 2012 10:15:28 -0800 (PST) +Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 968FE431FBC + for ; Mon, 13 Feb 2012 10:15:28 -0800 (PST) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail2.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1Rx0Qt-000437-L4; Mon, 13 Feb 2012 18:15:24 +0000 +Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223] + helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69) + (envelope-from ) + id 1Rx0Qt-0000Fc-3g; Mon, 13 Feb 2012 18:15:23 +0000 +From: Mark Walters +To: "Aneesh Kumar K.V" , + notmuch@notmuchmail.org +Subject: Re: [RFC PATCH v2 0/3] notmuch-pick: an emacs threaded message view + with split-pane +In-Reply-To: <87ehtz6r38.fsf@linux.vnet.ibm.com> +References: <1329072579-27340-1-git-send-email-markwalters1009@gmail.com> + <87ehtz6r38.fsf@linux.vnet.ibm.com> +User-Agent: Notmuch/0.11.1+200~gc983be4 (http://notmuchmail.org) Emacs/23.2.1 + (i486-pc-linux-gnu) +Date: Mon, 13 Feb 2012 18:16:44 +0000 +Message-ID: <87ehtyegz7.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=utf-8 +Content-Transfer-Encoding: quoted-printable +X-Sender-Host-Address: 94.192.233.223 +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: a4c0ffc6be8efae1d2fb7bb55a64a0a2 (of first 20000 bytes) +X-SpamAssassin-Score: -1.8 +X-SpamAssassin-SpamBar: - +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored -1.8 points. + Summary of the scoring: + * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, + * medium trust + * [138.37.6.40 listed in list.dnswl.org] + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay + * domain + * 0.5 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 13 Feb 2012 18:15:29 -0000 + +On Mon, 13 Feb 2012 14:35:31 +0530, "Aneesh Kumar K.V" wrote: +> On Sun, 12 Feb 2012 18:49:36 +0000, Mark Walters wrote: +> > Here is a rebased version of the notmuch-pick patch set +> > id:"87d39k1gvi.fsf@qmul.ac.uk". It now applies directly=20 +> > to master since Jani's notmuch-show command line parsing=20 +> > has been pushed. +> >=20 +> > It includes the significant bug fix (at least for anyone working=20 +> > with a dark background) from Daniel making matched messages=20 +> > highlight color both configurable and have a sensible default. +> > These are in the notmuch-pick subgroup of the customize menus. +> >=20 + +Hi + +> Really nice patchset. It would be really nice if we can get the serach +> limit patchset before this. That way the pick result will be limitted. + +Do you mean id:"1327692900-22926-1-git-send-email-jani@nikula.org"? That +would not affect notmuch-pick. In fact, since notmuch-pick uses +notmuch-show.c rather than notmuch-search.c the cli doesn't have the +--limit option. You are quite right that this may be the way to go +though. + +> I also noticied that mails are not marked as read when i select them in +> the notmuch-pick mode. Also for me the tree structures appears as +> below.=20 + +Are they not marked as read at all, or just not marked as read in the +notmuch-pick display (try pressing '=3D' and see if they are shown +correctly on refresh). It would be very nice to have the tags refresh +automatically but I have not implemented it (it may be beyond my lisp-fu). + +> Today 00:19 Mark Walters =E2=94=9C=E2=94=AC=E2=96=BA[RFC PATCH= + v2 1/3] cli: notmuch-show changes to support pick (notmuch) +> Today 02:38 Daniel Schoepe =E2=94=82=E2=94=9C=E2=94=80=E2=96=BA = +... (notmuch, signed) +> Today 03:38 Mark Walters =E2=94=82=E2=95=B0=E2=94=80=E2=96=BA = +... (notmuch) +> Today 00:19 Mark Walters =E2=94=9C=E2=94=AC=E2=96=BA[RFC PATCH= + v2 2/3] emacs: changes to other files to support notmuch-pick (notmuch) +> Today 03:57 Mark Walters =E2=94=82=E2=95=B0=E2=94=80=E2=96=BA = +... (notmuch) +> Today 00:19 Mark Walters =E2=94=9C=E2=94=80=E2=96=BA[RFC PATCH= + v2 3/3] emacs: add notmuch-pick itself (notmuch) + +I am not quite sure what this looks like (as I am not sure what is my +emacs doing things and what is what you sent. Could you send me a +screenshot (and an explanation of what is wrong if it is not clear from +the screenshot)? + +Thanks + +Mark