From: Mark Walters Date: Mon, 30 Jan 2012 21:27:34 +0000 (+0000) Subject: Re: Bug?: notmuch-search-show-thread shows several threads; only one containing match... X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=41eea016554c252a4bcc75fc3232d8e67287dd44;p=notmuch-archives.git Re: Bug?: notmuch-search-show-thread shows several threads; only one containing matching messages --- diff --git a/35/7aed0aa008b29b551dfb876cbb1d38d6da92a3 b/35/7aed0aa008b29b551dfb876cbb1d38d6da92a3 new file mode 100644 index 000000000..c18c53313 --- /dev/null +++ b/35/7aed0aa008b29b551dfb876cbb1d38d6da92a3 @@ -0,0 +1,150 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 2B439421192 + for ; Mon, 30 Jan 2012 13:26:33 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -1.098 +X-Spam-Level: +X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id US4d6BVvx2FI for ; + Mon, 30 Jan 2012 13:26:31 -0800 (PST) +Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id DCCBA431FBC + for ; Mon, 30 Jan 2012 13:26:30 -0800 (PST) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail2.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1Rryk8-0007z7-UF; Mon, 30 Jan 2012 21:26:29 +0000 +Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223] + helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69) + (envelope-from ) + id 1Rryk8-00015m-KA; Mon, 30 Jan 2012 21:26:28 +0000 +From: Mark Walters +To: Gregor Zattler , notmuch +Subject: Re: Bug?: notmuch-search-show-thread shows several threads; + only one containing matching messages +In-Reply-To: <20120130190425.GB13521@shi.workgroup> +References: <20120126004024.GA13704@shi.workgroup> + <20120126011903.GA1176@mit.edu> + <8762fzry7k.fsf@servo.finestructure.net> + <20120126124450.GB30209@shi.workgroup> <87mx9avbc1.fsf@praet.org> + <20120129234213.GB11460@shi.workgroup> <87zkd5655g.fsf@praet.org> + <20120130190425.GB13521@shi.workgroup> +User-Agent: Notmuch/0.11+137~g98adc3d (http://notmuchmail.org) Emacs/23.2.1 + (i486-pc-linux-gnu) +Date: Mon, 30 Jan 2012 21:27:34 +0000 +Message-ID: <878vkoev95.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Sender-Host-Address: 94.192.233.223 +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: 01303b7771349fd76f80b9a195b5fd3a (of first 20000 bytes) +X-SpamAssassin-Score: -1.8 +X-SpamAssassin-SpamBar: - +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored -1.8 points. + Summary of the scoring: + * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, + * medium trust + * [138.37.6.40 listed in list.dnswl.org] + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay + * domain + * 0.5 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 30 Jan 2012 21:26:33 -0000 + + +On Mon, 30 Jan 2012 20:04:25 +0100, Gregor Zattler wrote: +> Hi Pieter, +> * Pieter Praet [30. Jan. 2012]: +> > On Mon, 30 Jan 2012 00:42:14 +0100, Gregor Zattler wrote: +> >> * Pieter Praet [26. Jan. 2012]: +> >>> On Thu, 26 Jan 2012 13:44:50 +0100, Gregor Zattler wrote: +> >>>> |> [2] grep -I "^Message-Id:" /tmp/thread-I-m-interested-in.mbox |sed -e "s/Message-Id: $//" >really.mid +> >>>> |> grep -I -F really.mid rest.mbox +> >>>> |> --> no match +> >>> +> [...] +> >>> Also, the '-F' option expects input on stdin, not a filename. +> >> +> >> No, this is -F instead of -f and means --fixed-strings. +> >> +> > And as I said, `-F' requires input on stdin, like this: +> > +> > `grep -F "$(cat really.mid)" rest.mbox' +> > +> > Otherwise [1] you're grepping for the pattern 'really.mid' instead of +> > for the patterns specified *in* 'really.mid', so naturally, you aren't +> > getting any results. +> +> *blush* you're right and I'm wrong. I re-re-did the greps with +> with the same results (no hits at all). +> +> [...] +> >>> Here's another couple of threads squashed into a single one: +> >>> - [O] [Use Question] Capture and long lines +> >>> - id:"BANLkTikoF4tXuNLLufRzNSD6k2ZYs7sUcg@mail.gmail.com" +> >>> - [O] Worg update +> >>> - id:"m1wrfiz3ch.fsf@tsdye.com" +> >>> - [O] Table formula to convert hex to dec +> >>> - id:"20110724080054.GB16388@x201" +> >>> - [O] ICS import? +> >>> - id:"20120125173421.GQ3747@x201" +> >>> +> >>> +> >>> AFAICT, none of them share Message-Id's... +> >> +> >> Do you consider this a bug? +> >> +> > +> > I do. No idea what causes it or how to fix it though... :) +> +> First I thougt it' not a severe bug since one see's more not less +> messages in notmuch show buffer. But later I realised one also +> sees less not more threads in notmuch search buffer and might not +> read certain notmuch threads because of "wrong" $Subject: in +> notmuch search buffer. + +Hi + +I think notmuch links two messages into the same thread if they have an +in-reply-to or reference header in common: i.e the messages reference a +common parent message. (See comment in lib/database.cc "Even before a +message is added, it's pre-allocated thread ID is useful so that all +descendant messages that reference this common parent can be recognized +as belonging to the same thread.") + +As far as I can see your grep tests haven't checked for that. + +Also, could you email me the mbox you had (I think you said that it was +a mailing list so all public) and I will take a look? + +Thanks + +Mark