From: Justus Winter <4winter@informatik.uni-hamburg.de> Date: Sat, 2 Mar 2013 18:29:43 +0000 (+0100) Subject: Re: [PATCH 2/3] Go bindings: wrap notmuch_message_get_date X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=405a8e449a9ce734ab63b74ef3e79440fb7cfba5;p=notmuch-archives.git Re: [PATCH 2/3] Go bindings: wrap notmuch_message_get_date --- diff --git a/bc/409a14b56ae0593f3a4588a2505f140414fc43 b/bc/409a14b56ae0593f3a4588a2505f140414fc43 new file mode 100644 index 000000000..d5acddb09 --- /dev/null +++ b/bc/409a14b56ae0593f3a4588a2505f140414fc43 @@ -0,0 +1,72 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 1F976431FAF + for ; Sat, 2 Mar 2013 10:29:47 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id qxDeSsQ4zqnR for ; + Sat, 2 Mar 2013 10:29:46 -0800 (PST) +Received: from mail.cryptobitch.de (cryptobitch.de [88.198.7.68]) + (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 8B99D431FAE + for ; Sat, 2 Mar 2013 10:29:46 -0800 (PST) +Received: from mail.jade-hamburg.de (mail.jade-hamburg.de [85.183.11.228]) + (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) + (No client certificate requested) + by mail.cryptobitch.de (Postfix) with ESMTPSA id 46D2F615D7E + for ; Sat, 2 Mar 2013 19:29:45 +0100 (CET) +Received: by mail.jade-hamburg.de (Postfix, from userid 401) + id A858FDF2A2; Sat, 2 Mar 2013 19:29:44 +0100 (CET) +Received: from thinkbox.jade-hamburg.de (thinkbox.jadE-Hamburg.de + [10.1.1.109]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No + client certificate requested) by mail.jade-hamburg.de (Postfix) with ESMTPS + id E86E1DF28B; Sat, 2 Mar 2013 19:29:43 +0100 (CET) +Received: from teythoon by thinkbox.jade-hamburg.de with local (Exim 4.80) + (envelope-from ) + id 1UBrBn-0007p6-JJ; Sat, 02 Mar 2013 19:29:43 +0100 +Content-Type: text/plain; charset="utf-8" +MIME-Version: 1.0 +Content-Transfer-Encoding: quoted-printable +To: Julius Plenz , notmuch@notmuchmail.org +From: Justus Winter <4winter@informatik.uni-hamburg.de> +In-Reply-To: <1362235856-15358-2-git-send-email-julius@plenz.com> +References: <1362235856-15358-1-git-send-email-julius@plenz.com> + <1362235856-15358-2-git-send-email-julius@plenz.com> +Message-ID: <20130302182943.27570.80994@thinkbox.jade-hamburg.de> +User-Agent: alot/0.3.3+ +Subject: Re: [PATCH 2/3] Go bindings: wrap notmuch_message_get_date +Date: Sat, 02 Mar 2013 19:29:43 +0100 +Cc: Julius Plenz +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 02 Mar 2013 18:29:47 -0000 + +Quoting Julius Plenz (2013-03-02 15:50:55) +> -// TODO: wrap notmuch_message_get_date +> +func (self *Message) GetDate() time.Time { + +It's customary to name the receiver just m for the type Message. I +realize that the rest of the code uses self too, but I'd love to see +this converted and maybe we should not introduce any new code that +uses a receiver called self. @anyone: Thoughts? + +Justus