From: Mark Walters Date: Thu, 26 Apr 2012 19:10:01 +0000 (+0100) Subject: Re: [PATCH v2 1/2] emacs: add a filter option to show X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=404b29084f74a52db49e871ba7d86d2d3d0d92af;p=notmuch-archives.git Re: [PATCH v2 1/2] emacs: add a filter option to show --- diff --git a/ad/677c939952540e1def97faaf508acaad9ee47a b/ad/677c939952540e1def97faaf508acaad9ee47a new file mode 100644 index 000000000..16c074485 --- /dev/null +++ b/ad/677c939952540e1def97faaf508acaad9ee47a @@ -0,0 +1,108 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id E0EFE431FC3 + for ; Thu, 26 Apr 2012 12:09:47 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -1.098 +X-Spam-Level: +X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id w-MGLSQqAnAR for ; + Thu, 26 Apr 2012 12:09:47 -0700 (PDT) +Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 23D50431FAE + for ; Thu, 26 Apr 2012 12:09:47 -0700 (PDT) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail2.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1SNU4W-00063o-0U; Thu, 26 Apr 2012 20:09:44 +0100 +Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223] + helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69) + (envelope-from ) + id 1SNU4V-0005ZI-LJ; Thu, 26 Apr 2012 20:09:43 +0100 +From: Mark Walters +To: Tomi Ollila , notmuch@notmuchmail.org +Subject: Re: [PATCH v2 1/2] emacs: add a filter option to show +In-Reply-To: +References: <1335373954-4578-1-git-send-email-markwalters1009@gmail.com> + <1335373954-4578-2-git-send-email-markwalters1009@gmail.com> + +User-Agent: Notmuch/0.12+128~g0f26d91 (http://notmuchmail.org) Emacs/23.3.1 + (x86_64-pc-linux-gnu) +Date: Thu, 26 Apr 2012 20:10:01 +0100 +Message-ID: <87vckmxqba.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Sender-Host-Address: 94.192.233.223 +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: 32fe739662843129fd880fca6ee7958d (of first 20000 bytes) +X-SpamAssassin-Score: -1.8 +X-SpamAssassin-SpamBar: - +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored -1.8 points. + Summary of the scoring: + * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, + * medium trust + * [138.37.6.40 listed in list.dnswl.org] + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay + * domain + * 0.5 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 26 Apr 2012 19:09:48 -0000 + +On Thu, 26 Apr 2012, Tomi Ollila wrote: +> On Wed, Apr 25 2012, Mark Walters wrote: +> +>> Show the current thread with a different filter (i.e., open messages +>> in the thread matching the new query). +>> +>> Bound to 'l' for "limit". +>> +>> Note that it is not the same as filter in search mode as it replaces +>> the existing query rather than ANDing with it (but it does keep the +>> thread-id part of the query). +>> --- +> +> LGTM -- just one question -- to be analogous with 'notmuch-search-filter' +> 'notmuch-show-filter-thread' could look something like: +> +> (defun notmuch-show-filter-thread (query) +> "Filter or LIMIT the current thread based on a new query string. +> +> Reshows the current thread with matches defined by the new query-string." +> (interactive (list (notmuch-read-query "Filter thread: "))) +> (setq notmuch-show-query-context (if (string= query "") nil query)) +> (notmuch-show-refresh-view t)) +> + +Oh that looks much nicer! I will resubmit. + +Best wishes + +Mark +