From: Pieter Praet Date: Fri, 24 Feb 2012 22:38:20 +0000 (+0100) Subject: Re: [PATCH v5 00/12] emacs: more flexible and consistent tagging operations X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=3f2fc2a1ef5f6cf7b0aa08541215f69529284710;p=notmuch-archives.git Re: [PATCH v5 00/12] emacs: more flexible and consistent tagging operations --- diff --git a/42/f9ed02e1334a9eb808b6de3fb5232914357e52 b/42/f9ed02e1334a9eb808b6de3fb5232914357e52 new file mode 100644 index 000000000..0cad86e2f --- /dev/null +++ b/42/f9ed02e1334a9eb808b6de3fb5232914357e52 @@ -0,0 +1,132 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id A761441615F + for ; Fri, 24 Feb 2012 14:40:41 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id lZIMh2CH-BgL for ; + Fri, 24 Feb 2012 14:40:41 -0800 (PST) +Received: from mail-we0-f181.google.com (mail-we0-f181.google.com + [74.125.82.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id E12D1416158 + for ; Fri, 24 Feb 2012 14:40:40 -0800 (PST) +Received: by werp13 with SMTP id p13so2020003wer.26 + for ; Fri, 24 Feb 2012 14:40:39 -0800 (PST) +Received-SPF: pass (google.com: domain of pieter@praet.org designates + 10.180.8.226 as permitted sender) client-ip=10.180.8.226; +Authentication-Results: mr.google.com; + spf=pass (google.com: domain of pieter@praet.org + designates 10.180.8.226 as permitted sender) + smtp.mail=pieter@praet.org +Received: from mr.google.com ([10.180.8.226]) + by 10.180.8.226 with SMTP id u2mr8934164wia.16.1330123239729 (num_hops + = 1); Fri, 24 Feb 2012 14:40:39 -0800 (PST) +Received: by 10.180.8.226 with SMTP id u2mr7198351wia.16.1330123239611; + Fri, 24 Feb 2012 14:40:39 -0800 (PST) +Received: from localhost ([109.131.181.26]) + by mx.google.com with ESMTPS id gp8sm6329447wib.5.2012.02.24.14.40.38 + (version=TLSv1/SSLv3 cipher=OTHER); + Fri, 24 Feb 2012 14:40:39 -0800 (PST) +From: Pieter Praet +To: Dmitry Kurochkin , + David Bremner , notmuch@notmuchmail.org +Subject: Re: [PATCH v5 00/12] emacs: more flexible and consistent tagging + operations +In-Reply-To: <87obsojzga.fsf@gmail.com> +References: <1327725684-5887-1-git-send-email-dmitry.kurochkin@gmail.com> + <1328426033-21480-1-git-send-email-dmitry.kurochkin@gmail.com> + <87wr7xqpuf.fsf@rocinante.cs.unb.ca> <878vjtqhcg.fsf@praet.org> + <87obsojzga.fsf@gmail.com> +User-Agent: Notmuch/0.11.1+210~g6afc43e (http://notmuchmail.org) Emacs/23.3.1 + (x86_64-unknown-linux-gnu) +Date: Fri, 24 Feb 2012 23:38:20 +0100 +Message-ID: <87y5rrdfhf.fsf@praet.org> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Gm-Message-State: + ALoCoQlyizRdLu5G5jY+qIk1nliXYl2eU0Ax48k1BEP9BYQnRFfc4bVPlnfusAuD2tl0wCiCIrrv +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Fri, 24 Feb 2012 22:40:41 -0000 + +On Fri, 24 Feb 2012 14:30:29 +0400, Dmitry Kurochkin wrote: +> On Fri, 24 Feb 2012 00:07:27 +0100, Pieter Praet wrote: +> > On Wed, 08 Feb 2012 11:58:32 -0400, David Bremner wrote: +> > > On Sun, 5 Feb 2012 11:13:41 +0400, Dmitry Kurochkin wrote: +> > > > Changes: +> > > > +> > > > v4: +> > > > +> > > > * rebased on master, no conflicts so no need for another review +> > > > +> > > +> > > I pushed this series. +> > > +> > > Maybe this was discussed already, but I think ideally * would apply only +> > > to open messages. So consider that a feature request if someone is +> > > looking for a project. +> > > +> > +> > How about if '*' applies to all messages (as it currently does), +> > but 'C-u *' only to open messages? That would make more sense IMHO. +> > +> > But, conforming to your original request, I've implemented the inverse. +> > +> +> I personally do like '*' as is and do not want to change it's behavior. +> Though I am not against adding a prefix argument for it. +> + +Same here. In v2 [1], '*' tags all and 'C-u *' tags only open. + +One can always swap the keybindings if so inclined. + + +> Regards, +> Dmitry +> +> > Patches follow. +> > +> > +> > > d +> > > _______________________________________________ +> > > notmuch mailing list +> > > notmuch@notmuchmail.org +> > > http://notmuchmail.org/mailman/listinfo/notmuch +> > +> > +> > Peace +> > +> > -- +> > Pieter +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch + + +Peace + +-- +Pieter + +[1] id:"1330122640-18895-1-git-send-email-pieter@praet.org"