From: Austin Clements Date: Tue, 31 Jan 2012 05:08:10 +0000 (+1900) Subject: Re: [RFC PATCH 2/4] Add NOTMUCH_MESSAGE_FLAG_EXCLUDED flag X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=3e301895f648f27060ea6542588cde02f97b7ea7;p=notmuch-archives.git Re: [RFC PATCH 2/4] Add NOTMUCH_MESSAGE_FLAG_EXCLUDED flag --- diff --git a/c5/1ba2f3b3dc6d514dbd4210b04bce45d0addc90 b/c5/1ba2f3b3dc6d514dbd4210b04bce45d0addc90 new file mode 100644 index 000000000..3a7f499ea --- /dev/null +++ b/c5/1ba2f3b3dc6d514dbd4210b04bce45d0addc90 @@ -0,0 +1,116 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 258A341ED96 + for ; Mon, 30 Jan 2012 21:09:04 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id b+Ed63FZiefN for ; + Mon, 30 Jan 2012 21:09:03 -0800 (PST) +Received: from dmz-mailsec-scanner-7.mit.edu (DMZ-MAILSEC-SCANNER-7.MIT.EDU + [18.7.68.36]) + by olra.theworths.org (Postfix) with ESMTP id 95D2141ED91 + for ; Mon, 30 Jan 2012 21:09:03 -0800 (PST) +X-AuditID: 12074424-b7fae6d000000906-15-4f27776f308d +Received: from mailhub-auth-1.mit.edu ( [18.9.21.35]) + by dmz-mailsec-scanner-7.mit.edu (Symantec Messaging Gateway) with SMTP + id 3D.7A.02310.F67772F4; Tue, 31 Jan 2012 00:09:03 -0500 (EST) +Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) + by mailhub-auth-1.mit.edu (8.13.8/8.9.2) with ESMTP id q0V593Uf030148; + Tue, 31 Jan 2012 00:09:03 -0500 +Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) + (authenticated bits=0) + (User authenticated as amdragon@ATHENA.MIT.EDU) + by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q0V5917O004147 + (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); + Tue, 31 Jan 2012 00:09:02 -0500 (EST) +Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77) + (envelope-from ) + id 1Rs5ww-0002pT-Ai; Tue, 31 Jan 2012 00:08:10 -0500 +Date: Tue, 31 Jan 2012 00:08:10 -0500 +From: Austin Clements +To: Mark Walters +Subject: Re: [RFC PATCH 2/4] Add NOTMUCH_MESSAGE_FLAG_EXCLUDED flag +Message-ID: <20120131050810.GC17991@mit.edu> +References: <20120124011609.GX16740@mit.edu> + <1327367923-18228-2-git-send-email-markwalters1009@gmail.com> + <20120124024521.GY16740@mit.edu> <874nvg6qxn.fsf@qmul.ac.uk> + <20120128183340.GD17991@mit.edu> <8739azqt2j.fsf@qmul.ac.uk> + <87zkd6pzg2.fsf@qmul.ac.uk> <8762fu4aqt.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +Content-Disposition: inline +In-Reply-To: <8762fu4aqt.fsf@qmul.ac.uk> +User-Agent: Mutt/1.5.21 (2010-09-15) +X-Brightmail-Tracker: + H4sIAAAAAAAAA+NgFmpileLIzCtJLcpLzFFi42IR4hRV1s0vV/c3uHCL12L1XB6L6zdnMjsw + eeycdZfd49mqW8wBTFFcNimpOZllqUX6dglcGV+PtbAXbOSuWPXiM2sD4xWOLkZODgkBE4kt + J3oYIWwxiQv31rN1MXJxCAnsY5TYcP8dI4SzgVHi0Pa1LBDOSSaJ9f/3MIO0CAksYZR4/JUb + xGYRUJX4fPYZE4jNJqAhsW3/crCxIgI6ErcPLWAHsZkFpCW+/W4GqxEWcJZ43vSVFcTmBaqZ + 3XiMBWLmKiaJ6a/EIOKCEidnPmGB6NWSuPHvJVAvB9ic5f/APuAEWjVr3muwkaICKhJTTm5j + m8AoNAtJ9ywk3bMQuhcwMq9ilE3JrdLNTczMKU5N1i1OTszLSy3SNdfLzSzRS00p3cQICmp2 + F5UdjM2HlA4xCnAwKvHwCn1S8xdiTSwrrsw9xCjJwaQkyjunQN1fiC8pP6UyI7E4I76oNCe1 + +BCjBAezkgjvm9VA5bwpiZVVqUX5MClpDhYlcV4NrXd+QgLpiSWp2ampBalFMFkZDg4lCd7m + MqChgkWp6akVaZk5JQhpJg5OkOE8QMNrQWp4iwsSc4sz0yHypxgVpcR540ESAiCJjNI8uF5Y + 0nnFKA70ijDvLJAqHmDCgut+BTSYCWjwcwZVkMEliQgpqQbGzobT29mt82fGfNsh+OXdpucz + i/eeiS90OLM4oYZ3ihnDoX/9rFc8Ve7zZ0z5PrcmSuqb2urFuV8esF0uP8U74cRsOUPvXiYt + jS0qP5OOJEdefh62g81sfsoCtXOSi67MiTwXtcxk1gH2VTktK1t66k4FxNjcPtdevsjmX2LT + 8k7728srEnjvKbEUZyQaajEXFScCAKZ61OkVAwAA +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 31 Jan 2012 05:09:04 -0000 + +This is looking really good. I think this overall approach is +significantly better than the initial exclude support and the UI +aspects look like they should be much more pleasant. + +Quoth Mark Walters on Jan 29 at 6:36 pm: +> +> Ok I now have a patch set which might be complete enough to be worth +> reviewing. It is essentially complete and appears to work. +> +> Things that still need doing: +> updating the test suite. The series changes notmuch-show to +> output the exclude flag so several tests need updating. Of +> course, the new functionality needs some tests too. +> +> emacs/notmuch.el I think it would be nice to hide (make +> invisible) threads with no matching non-excluded messages (with a +> toggle for visibility) but that is definitely beyond my elisp +> skills. + +I'm happy to do that once this goes in. + +> The first patch of the series is not really part of the series: it adds +> a --do-not-exclude option to tell the command not to exclude. I think +> this is useful anyway, but it also simplifies behaviour decisions with +> the excludes. For example notmuch count will only count matching +> non-excluded messages but notmuch count --do-not-exclude will count +> all matching messages excluded or not. +> +> One outstanding issue is that raised in +> id:"20120124025331.GZ16740@mit.edu". I will need to think about +> that. +> +> Best wishes +> +> Mark +>