From: David Bremner Date: Mon, 24 Dec 2012 15:54:35 +0000 (+2000) Subject: Re: [PATCH] emacs: show: make id links respect window X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=3be4a07649297bd00b325dab6401802c7f667937;p=notmuch-archives.git Re: [PATCH] emacs: show: make id links respect window --- diff --git a/a8/4b5cb3e279b90bca2dd3a46292ba261f8633da b/a8/4b5cb3e279b90bca2dd3a46292ba261f8633da new file mode 100644 index 000000000..5ff5ffebc --- /dev/null +++ b/a8/4b5cb3e279b90bca2dd3a46292ba261f8633da @@ -0,0 +1,73 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id EF823431FAF + for ; Mon, 24 Dec 2012 07:54:42 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id iJAuAI3W+faD for ; + Mon, 24 Dec 2012 07:54:42 -0800 (PST) +Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238]) + (using TLSv1 with cipher AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 566E6431FAE + for ; Mon, 24 Dec 2012 07:54:42 -0800 (PST) +Received: from fctnnbsc30w-156034082078.dhcp-dynamic.fibreop.nb.bellaliant.net + ([156.34.82.78] helo=zancas.localnet) + by tesseract.cs.unb.ca with esmtpsa + (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) + (envelope-from ) + id 1TnAMT-0000XG-6T; Mon, 24 Dec 2012 11:54:41 -0400 +Received: from bremner by zancas.localnet with local (Exim 4.80) + (envelope-from ) + id 1TnAMN-0003Et-78; Mon, 24 Dec 2012 11:54:35 -0400 +From: David Bremner +To: Mark Walters , notmuch@notmuchmail.org +Subject: Re: [PATCH] emacs: show: make id links respect window +In-Reply-To: <1355958602-16752-1-git-send-email-markwalters1009@gmail.com> +References: <1355958602-16752-1-git-send-email-markwalters1009@gmail.com> +User-Agent: Notmuch/0.14+213~g4af1ac6 (http://notmuchmail.org) Emacs/24.2.1 + (x86_64-pc-linux-gnu) +Date: Mon, 24 Dec 2012 11:54:35 -0400 +Message-ID: <87bodjfnt0.fsf@zancas.localnet> +MIME-Version: 1.0 +Content-Type: text/plain +X-Spam_bar: - +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 24 Dec 2012 15:54:43 -0000 + +Mark Walters writes: + +> I think this is a bug but that could be debated. It is particularly +> easy to trigger with notmuch pick because that uses the split pane +> while focus usually remains in the `pick' pane rather than the `show' +> pane. + +I can imagine that people would want/like the "open in other window" +effect of the current code, even if the reason is a bug. + +> 'action `(lambda (arg) +> (notmuch-show ,(third link))) + +Can you (or someone) explain why backquote is needed here? Is this some +kind of workaround for lack of lexical scope? If so, maybe a comment. + +d