From: Ethan Glasser-Camp Date: Fri, 12 Oct 2012 17:42:24 +0000 (+2000) Subject: Re: [PATCH 1/2] test: add check for filename argument for test_expect_equa... X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=3ad4707ff281eb721da94748a9faf56e44bc024d;p=notmuch-archives.git Re: [PATCH 1/2] test: add check for filename argument for test_expect_equal_file --- diff --git a/50/86a3bd72ec7c28cac773c042b0a6d70f84a06a b/50/86a3bd72ec7c28cac773c042b0a6d70f84a06a new file mode 100644 index 000000000..637dbc53e --- /dev/null +++ b/50/86a3bd72ec7c28cac773c042b0a6d70f84a06a @@ -0,0 +1,81 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id CB3FE431FAF + for ; Fri, 12 Oct 2012 10:42:32 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.799 +X-Spam-Level: +X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id U7AYlY3on-DD for ; + Fri, 12 Oct 2012 10:42:31 -0700 (PDT) +Received: from mail-qa0-f46.google.com (mail-qa0-f46.google.com + [209.85.216.46]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 6F561431FAE + for ; Fri, 12 Oct 2012 10:42:31 -0700 (PDT) +Received: by mail-qa0-f46.google.com with SMTP id c26so40377qad.5 + for ; Fri, 12 Oct 2012 10:42:30 -0700 (PDT) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; + h=from:to:subject:in-reply-to:references:user-agent:date:message-id + :mime-version:content-type; + bh=EhGslp7umPuYTfJkJtriZZqu1U8t8JTtefDgOk55fzs=; + b=moLWJpjnO9QFU31iazDN6zm8R6TcAbIIj1iibNEy/5A9OEfpNWaEovHW+8p9vpQyyk + UnewJYtl+ez62drwuzh4Pr9OPlcpHAbROZerRZTNgZrf3GvVN/KH/GQmeHAREcPI9JvU + 7Q6DGYqLjT4MeyqbE2osPqFbEIMqG1kyzrXxblVqwtnczaPtaT9RYq0AauqlMVG/M8wN + OkwyBMTDruJhBbp/ymIGKjkUdsGFYMB9lfid6OC+6XQY61RT1Hb4B19njmsm9Z/Jkw3X + AfVoU32h044p3E5u2WeNg6fLOIQtrIt66h/v17a9zdJyKaoWSvBjxdt96+9K2DYPuN0s + HAPQ== +Received: by 10.49.72.1 with SMTP id z1mr3629350qeu.2.1350063750838; + Fri, 12 Oct 2012 10:42:30 -0700 (PDT) +Received: from smtp.gmail.com (p70-80.acedsl.com. [66.114.70.80]) + by mx.google.com with ESMTPS id z9sm6924340qeg.9.2012.10.12.10.42.29 + (version=TLSv1/SSLv3 cipher=OTHER); + Fri, 12 Oct 2012 10:42:29 -0700 (PDT) +From: Ethan Glasser-Camp +To: Dmitry Kurochkin , + Jameson Graef Rollins , notmuch@notmuchmail.org +Subject: Re: [PATCH 1/2] test: add check for filename argument for + test_expect_equal_file +In-Reply-To: <87sjishv3e.fsf@gmail.com> +References: <1328141050-30356-1-git-send-email-dmitry.kurochkin@gmail.com> + <1328141050-30356-2-git-send-email-dmitry.kurochkin@gmail.com> + <87zkd1p12c.fsf@servo.finestructure.net> <87sjishv3e.fsf@gmail.com> +User-Agent: Notmuch/0.14+45~g6ea9330 (http://notmuchmail.org) Emacs/23.3.1 + (x86_64-pc-linux-gnu) +Date: Fri, 12 Oct 2012 13:42:24 -0400 +Message-ID: <87vcefa8ov.fsf@betacantrips.com> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Fri, 12 Oct 2012 17:42:32 -0000 + +Dmitry Kurochkin writes: + +> Actually, we can do both: check file name for consistent diff order +> (from expected to actual) and use file names that the caller provides. + +Hi! Reviewing the patch queue a little bit here. It seems like this +patch ended up getting dropped because the other approach (using the +filenames that the caller provided) won out and was even pushed. I'm +therefore marking this series notmuch::obsolete (and also +notmuch::stale since it doesn't apply cleanly). + +Ethan