From: Tomi Ollila <tomi.ollila@iki.fi>
Date: Sat, 4 Aug 2012 07:05:04 +0000 (+0300)
Subject: Re: [PATCH] test: test-lib.el: replace sleep-for with sit-for in notmuch-test-wait
X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=3a0a424cebd14ce9967659e8b14b661eca536a01;p=notmuch-archives.git

Re: [PATCH] test: test-lib.el: replace sleep-for with sit-for in notmuch-test-wait
---

diff --git a/a2/27736b07dedb68241269955f1b3b85a9db6498 b/a2/27736b07dedb68241269955f1b3b85a9db6498
new file mode 100644
index 000000000..e4e7dae9c
--- /dev/null
+++ b/a2/27736b07dedb68241269955f1b3b85a9db6498
@@ -0,0 +1,64 @@
+Return-Path: <tomi.ollila@iki.fi>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id E8E04431FAE
+	for <notmuch@notmuchmail.org>; Sat,  4 Aug 2012 00:04:57 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 0
+X-Spam-Level: 
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
+	autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id p3JKWFfQ0Xxr for <notmuch@notmuchmail.org>;
+	Sat,  4 Aug 2012 00:04:56 -0700 (PDT)
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
+	by olra.theworths.org (Postfix) with ESMTP id D7CEE431FAF
+	for <notmuch@notmuchmail.org>; Sat,  4 Aug 2012 00:04:55 -0700 (PDT)
+Received: by guru.guru-group.fi (Postfix, from userid 501)
+	id 69D6B100372; Sat,  4 Aug 2012 10:05:04 +0300 (EEST)
+From: Tomi Ollila <tomi.ollila@iki.fi>
+To: Austin Clements <amdragon@MIT.EDU>
+Subject: Re: [PATCH] test: test-lib.el: replace sleep-for with sit-for in
+	notmuch-test-wait
+In-Reply-To: <20120803205216.GG22601@mit.edu>
+References: <1343996163-26720-1-git-send-email-tomi.ollila@iki.fi>
+	<20120803205216.GG22601@mit.edu>
+User-Agent: Notmuch/0.13.2+123~gd19b5be (http://notmuchmail.org) Emacs/23.1.1
+	(x86_64-redhat-linux-gnu)
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
+	$[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
+	!)g;OY^,BjTbr)Np:%c_o'jj,Z
+Date: Sat, 04 Aug 2012 10:05:04 +0300
+Message-ID: <m2sjc3rvbz.fsf@guru.guru-group.fi>
+MIME-Version: 1.0
+Content-Type: text/plain; charset=us-ascii
+Cc: notmuch@notmuchmail.org
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Sat, 04 Aug 2012 07:04:58 -0000
+
+On Fri, Aug 03 2012, Austin Clements <amdragon@MIT.EDU> wrote:
+
+> Code LGTM, but maybe the comment should explain that this is a
+> workaround for a bug in Emacs, given that both sleep-for and sit-for
+> are supposed to process process output and run sentinels (which has
+> been stated in the Elisp reference at least as far back as Emacs 21).
+> In light of this (and our better understanding of sleep-for and
+> sit-for from IRC discussions), the commit message is also misleading.
+
+Indeed...
+
+Tomi