From: David Bremner <david@tethera.net>
Date: Fri, 29 Mar 2013 13:28:00 +0000 (+2000)
Subject: Re: [PATCH v2] completion: complete bash completion rewrite
X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=39e0d9b8b81dc4efbbd1e9c3c725d9aa48833e63;p=notmuch-archives.git

Re: [PATCH v2] completion: complete bash completion rewrite
---

diff --git a/72/186a9a938a3c4b8ca2cdc81d0be6a7e38a2805 b/72/186a9a938a3c4b8ca2cdc81d0be6a7e38a2805
new file mode 100644
index 000000000..5f7cde5d3
--- /dev/null
+++ b/72/186a9a938a3c4b8ca2cdc81d0be6a7e38a2805
@@ -0,0 +1,77 @@
+Return-Path: <bremner@unb.ca>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id ECF50431FBC
+	for <notmuch@notmuchmail.org>; Fri, 29 Mar 2013 06:28:09 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 0
+X-Spam-Level: 
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
+	autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id cxQV2auVWHh9 for <notmuch@notmuchmail.org>;
+	Fri, 29 Mar 2013 06:28:09 -0700 (PDT)
+Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])
+	(using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
+	(No client certificate requested)
+	by olra.theworths.org (Postfix) with ESMTPS id 06D7C431FB6
+	for <notmuch@notmuchmail.org>; Fri, 29 Mar 2013 06:28:08 -0700 (PDT)
+Received: from remotemail by tesseract.cs.unb.ca with local (Exim 4.80)
+	(envelope-from <bremner@unb.ca>)
+	id 1ULZLh-0000Z2-AN; Fri, 29 Mar 2013 10:28:05 -0300
+Received: (nullmailer pid 10914 invoked by uid 1000);
+	Fri, 29 Mar 2013 13:28:00 -0000
+From: David Bremner <david@tethera.net>
+To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
+Subject: Re: [PATCH v2] completion: complete bash completion rewrite
+In-Reply-To: <1362344368-27623-1-git-send-email-jani@nikula.org>
+References: <1362232751-9571-1-git-send-email-jani@nikula.org>
+	<1362344368-27623-1-git-send-email-jani@nikula.org>
+User-Agent: Notmuch/0.15.1 (http://notmuchmail.org) Emacs/24.2.1
+	(x86_64-pc-linux-gnu)
+Date: Fri, 29 Mar 2013 09:28:00 -0400
+Message-ID: <87zjxmwd27.fsf@maritornes.cs.unb.ca>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Fri, 29 Mar 2013 13:28:10 -0000
+
+Jani Nikula <jani@nikula.org> writes:
+
+> Rewrite the bash completion script to actually do something
+> useful. Supported completions:
+>
+> * All the notmuch commands, command line arguments, and values for
+>   keyword arguments.
+It seems to do what it says on the box. The bash code look OK, although
+I'm probably not as fussy or expert as some.
+
+> ---
+>
+> CAVEATS:
+>
+> There may be dependencies on the version of the bash-completion
+> package. I do not know, and I don't have a huge interest in finding
+> out. That way lay dragons.
+
+I pushed this.
+
+Maybe we should just document what versions of bash-completion it is
+tested with. I tested it with bash-completion 2.0. 
+
+Could you make a followup patch with
+something for completion/README and a line or so for NEWS?