From: David Bremner <david@tethera.net>
Date: Fri, 9 Nov 2012 02:57:37 +0000 (+2000)
Subject: Re: [PATCH] contrib: pick: bugfix when trying to show a non-message
X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=3687ae736ef2caad2f12637bde212dd6281ebe20;p=notmuch-archives.git

Re: [PATCH] contrib: pick: bugfix when trying to show a non-message
---

diff --git a/ae/798c66bc28ffbc24fe2f02222b2d33363bb2a9 b/ae/798c66bc28ffbc24fe2f02222b2d33363bb2a9
new file mode 100644
index 000000000..a4a271eb9
--- /dev/null
+++ b/ae/798c66bc28ffbc24fe2f02222b2d33363bb2a9
@@ -0,0 +1,65 @@
+Return-Path: <bremner@unb.ca>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id 49D08431FB6
+	for <notmuch@notmuchmail.org>; Thu,  8 Nov 2012 18:57:47 -0800 (PST)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 0
+X-Spam-Level: 
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
+	autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id Bfw1OMqleA15 for <notmuch@notmuchmail.org>;
+	Thu,  8 Nov 2012 18:57:46 -0800 (PST)
+Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])
+	(using TLSv1 with cipher AES256-SHA (256/256 bits))
+	(No client certificate requested)
+	by olra.theworths.org (Postfix) with ESMTPS id B4DF7431FAE
+	for <notmuch@notmuchmail.org>; Thu,  8 Nov 2012 18:57:46 -0800 (PST)
+Received: from fctnnbsc30w-156034089108.dhcp-dynamic.fibreop.nb.bellaliant.net
+	([156.34.89.108] helo=zancas.localnet)
+	by tesseract.cs.unb.ca with esmtpsa
+	(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72)
+	(envelope-from <bremner@unb.ca>)
+	id 1TWems-0000ew-Rf; Thu, 08 Nov 2012 22:57:43 -0400
+Received: from bremner by zancas.localnet with local (Exim 4.80)
+	(envelope-from <bremner@unb.ca>)
+	id 1TWemn-0007yK-AT; Thu, 08 Nov 2012 22:57:37 -0400
+From: David Bremner <david@tethera.net>
+To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
+Subject: Re: [PATCH] contrib: pick: bugfix when trying to show a non-message
+In-Reply-To: <1351797983-19707-1-git-send-email-markwalters1009@gmail.com>
+References: <1351797983-19707-1-git-send-email-markwalters1009@gmail.com>
+User-Agent: Notmuch/0.14+75~g984212d (http://notmuchmail.org) Emacs/24.1.1
+	(x86_64-pc-linux-gnu)
+Date: Thu, 08 Nov 2012 22:57:37 -0400
+Message-ID: <87ehk332la.fsf@zancas.localnet>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-Spam_bar: -
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Fri, 09 Nov 2012 02:57:47 -0000
+
+Mark Walters <markwalters1009@gmail.com> writes:
+
+> -  (concat "id:\"" (notmuch-pick-get-prop :id) "\""))
+> +  (let ((id (notmuch-pick-get-prop :id)))
+> +    (when id
+> +      (concat "id:\"" id "\""))))
+
+I don't know how other people feel, but I'd rather have an `if' in a
+context where I care about the return value.