From: Austin Clements Date: Fri, 7 Dec 2012 16:33:20 +0000 (+1900) Subject: Re: [PATCH 1/1] NEWS: under-the-hood Emacs interface fixes X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=3534307a30a8e65512075aa27c98b717613446a4;p=notmuch-archives.git Re: [PATCH 1/1] NEWS: under-the-hood Emacs interface fixes --- diff --git a/2d/25307492e71bb0643197b48d14eb0487addc15 b/2d/25307492e71bb0643197b48d14eb0487addc15 new file mode 100644 index 000000000..abd2496e5 --- /dev/null +++ b/2d/25307492e71bb0643197b48d14eb0487addc15 @@ -0,0 +1,143 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 7B684431FB6 + for ; Fri, 7 Dec 2012 08:33:27 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id KTsJ1gm8sJfJ for ; + Fri, 7 Dec 2012 08:33:26 -0800 (PST) +Received: from dmz-mailsec-scanner-5.mit.edu (DMZ-MAILSEC-SCANNER-5.MIT.EDU + [18.7.68.34]) + by olra.theworths.org (Postfix) with ESMTP id 5AB15431FAE + for ; Fri, 7 Dec 2012 08:33:26 -0800 (PST) +X-AuditID: 12074422-b7fe46d0000008d2-bb-50c21a542713 +Received: from mailhub-auth-3.mit.edu ( [18.9.21.43]) + by dmz-mailsec-scanner-5.mit.edu (Symantec Messaging Gateway) with SMTP + id 56.0E.02258.45A12C05; Fri, 7 Dec 2012 11:33:24 -0500 (EST) +Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) + by mailhub-auth-3.mit.edu (8.13.8/8.9.2) with ESMTP id qB7GXN4q022809; + Fri, 7 Dec 2012 11:33:24 -0500 +Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) + (authenticated bits=0) + (User authenticated as amdragon@ATHENA.MIT.EDU) + by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id qB7GXLoF000840 + (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); + Fri, 7 Dec 2012 11:33:23 -0500 (EST) +Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.80) + (envelope-from ) + id 1Th0rY-0004vG-TX; Fri, 07 Dec 2012 11:33:20 -0500 +Date: Fri, 7 Dec 2012 11:33:20 -0500 +From: Austin Clements +To: Tomi Ollila +Subject: Re: [PATCH 1/1] NEWS: under-the-hood Emacs interface fixes +Message-ID: <20121207163320.GE4422@mit.edu> +References: <1354488524-12013-1-git-send-email-tomi.ollila@iki.fi> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +Content-Disposition: inline +In-Reply-To: <1354488524-12013-1-git-send-email-tomi.ollila@iki.fi> +User-Agent: Mutt/1.5.21 (2010-09-15) +X-Brightmail-Tracker: + H4sIAAAAAAAAA+NgFmpileLIzCtJLcpLzFFi42IR4hTV1g2ROhRgMH+fhsX1mzOZLd6snMfq + wORx+OtCFo9nq24xBzBFcdmkpOZklqUW6dslcGVMmb2eveCHcMWqfctYGxj7BboYOTkkBEwk + zpx/xAhhi0lcuLeeDcQWEtjHKLFjnmoXIxeQvZ5RYvv2U8wQiQtMEgd3ekIkljBKPD5wmBUk + wSKgInH/+goWEJtNQENi2/7lYFNFgOIP2taD1TALSEt8+93MBGILCzhLvLi5Fmwor4C2xJVl + G1ggFjhJ3D3VwAgRF5Q4OfMJC0SvlsSNfy+BejnA5iz/xwES5gQac/vGdbCRokCrppzcxjaB + UWgWku5ZSLpnIXQvYGRexSibklulm5uYmVOcmqxbnJyYl5dapGuql5tZopeaUrqJERTU7C5K + Oxh/HlQ6xCjAwajEw3tD5FCAEGtiWXFl7iFGSQ4mJVHeJcJAIb6k/JTKjMTijPii0pzU4kOM + EhzMSiK8OzmAcrwpiZVVqUX5MClpDhYlcd5rKTf9hQTSE0tSs1NTC1KLYLIyHBxKEryekkCN + gkWp6akVaZk5JQhpJg5OkOE8QMN/SYAMLy5IzC3OTIfIn2JUlBLnlQBpFgBJZJTmwfXCks4r + RnGgV4R5zUGqeIAJC677FdBgJqDBUez7QQaXJCKkpBoYe1xXPY+O/Lpa4Onj/AsVjYdnmsWZ + 7Xn1feNDh813eDZpzFz7MfH2SucCQbvXX7j2FinVmh1+6Nvyr/3pR87iI5/Xh/3/v9OqQMHS + 8m+T1o10lSVuaS15G+S/vTyR83lz28pv550iigqnO7zrnr9Ex3x39KtrsdsXPX+/vjkuyfAQ + H7cgp8Y9DyWW4oxEQy3mouJEAJDlJAIVAwAA +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Fri, 07 Dec 2012 16:33:27 -0000 + +Quoth Tomi Ollila on Dec 03 at 12:48 am: +> Added the following Emacs Interface NEWS entries: +> +> Catch errors bodypart insertions may throw, +> Improved text/calendar content handling and +> Don't do coding conversions when reading in +> `with-current-notmuch-show-message`. +> --- +> NEWS | 25 +++++++++++++++++++++++++ +> 1 file changed, 25 insertions(+) +> +> diff --git a/NEWS b/NEWS +> index dadf92a..1d0c840 100644 +> --- a/NEWS +> +++ b/NEWS +> @@ -18,6 +18,31 @@ Bcc and Reply-To headers are now available in notmuch show json output +> For example notmuch Emacs client can now have these headers visible +> when the headers are added to the `notmuch-message-headers` variable. +> +> +Emacs Interface +> +--------------- +> + +> +Catch errors bodypart insertions may throw +> + +> +Whenever anything inside `notmuch-show-insert-part-*` functions +> +threw an error then filling of notmuch show buffer halted there. +> +Now the error is caught, user is informed about the error +> +and execution is continued with next content filling function. + +Should these blocks be indented? + +Also, this could be a little more user-facing. Maybe, + + If displaying the text of a message in show mode causes an error (in + the `notmuch-show-insert-part-*` functions), notmuch no longer cuts + off thread display at the offending message. The error is now + simply displayed in place of the message. + +> + +> +Improved text/calendar content handling +> + +> +Carriage returns in embedded text/calendar content caused insertion +> +of calendar content fail. Now CRs are removed before calling icalendar +> +to extract icalendar data. In case icalendar extraction fails an error +> +is thrown for bodypart insertion function to react upon it. +> + +> +Don't do coding conversions when reading in `with-current-notmuch-show-message` +> + +> +In locales that support more than 8-bit characters reading data in +> +`with-current-notmuch-show-message` converted data to multibyte format. +> +Some cases reversing the conversion did not provide original data. Now +> +the input octet stream is buffered in non-converted format for further +> +processing. + +This doesn't mention the ultimate effect of this bug. + + Depending on the user's locale, saving attachments containing 8-bit + data may have performed an unintentional encoding conversion, + corrupting the saved attachment. This has been fixed by making + `with-current-notmuch-show-message` disable coding conversion. + +? + +> + +> Library changes +> --------------- +>