From: Mark Walters Date: Sun, 5 Feb 2012 12:45:05 +0000 (+0000) Subject: Re: [PATCH v3 2/5] reply: Add a JSON reply format. X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=32637f93fd4192cc0db83009fc2b5f87e527b2ce;p=notmuch-archives.git Re: [PATCH v3 2/5] reply: Add a JSON reply format. --- diff --git a/b9/476cb740a8095384ac6f5876549ef7ee94b68d b/b9/476cb740a8095384ac6f5876549ef7ee94b68d new file mode 100644 index 000000000..87f054f16 --- /dev/null +++ b/b9/476cb740a8095384ac6f5876549ef7ee94b68d @@ -0,0 +1,113 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id C93C8431FAF + for ; Sun, 5 Feb 2012 04:43:58 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -1.098 +X-Spam-Level: +X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 2XlPp0BNrU7o for ; + Sun, 5 Feb 2012 04:43:58 -0800 (PST) +Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 16CAC431FAE + for ; Sun, 5 Feb 2012 04:43:58 -0800 (PST) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail2.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1Ru1Rj-0001b6-Mc; Sun, 05 Feb 2012 12:43:56 +0000 +Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223] + helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69) + (envelope-from ) + id 1Ru1Rj-00024Z-Ea; Sun, 05 Feb 2012 12:43:55 +0000 +From: Mark Walters +To: Adam Wolfe Gordon , notmuch@notmuchmail.org +Subject: Re: [PATCH v3 2/5] reply: Add a JSON reply format. +In-Reply-To: <87mx8xpki3.fsf@qmul.ac.uk> +References: <1326995217-27423-1-git-send-email-awg+notmuch@xvx.ca> + <1326995217-27423-3-git-send-email-awg+notmuch@xvx.ca> + <87mx8xpki3.fsf@qmul.ac.uk> +User-Agent: Notmuch/0.11+154~ged6d37e (http://notmuchmail.org) Emacs/23.2.1 + (i486-pc-linux-gnu) +Date: Sun, 05 Feb 2012 12:45:05 +0000 +Message-ID: <871uq9wisu.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Sender-Host-Address: 94.192.233.223 +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: 57223c4c5fb3b518acb2be89ed8d0267 (of first 20000 bytes) +X-SpamAssassin-Score: -1.8 +X-SpamAssassin-SpamBar: - +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored -1.8 points. + Summary of the scoring: + * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, + * medium trust + * [138.37.6.40 listed in list.dnswl.org] + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay + * domain + * 0.5 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 05 Feb 2012 12:43:58 -0000 + + +On Sun, 05 Feb 2012 11:50:12 +0000, Mark Walters wrote: +> On Thu, 19 Jan 2012 10:46:54 -0700, Adam Wolfe Gordon wrote: +> > This new JSON format for replies includes headers generated for a reply +> > message as well as the headers and all text parts of the original message. +> > Using this data, a client can intelligently create a reply. For example, +> > the emacs client will be able to create replies with quoted HTML parts by +> > parsing the HTML parts using w3m. +> +> Hi this is only a preliminary look so far as I read the code. Note this +> is the first time I have tried reviewing a substantial chunk of code so +> sorry for any stupidities on my part! + +After Austin's show modifications (commit 7430a42) I needed the +following patch which is probably trivial but I was only guessing based +on the other change to notmuch-reply Austin made at the time. + +Best wishes + +Mark + +diff --git a/notmuch-reply.c b/notmuch-reply.c +index 9aefce8..1c62b54 100644 +--- a/notmuch-reply.c ++++ b/notmuch-reply.c +@@ -56,7 +56,7 @@ static const notmuch_show_format_t format_reply = { + }; + + static const notmuch_show_format_t format_json = { +- "", ++ "", NULL, + "", NULL, + "", NULL, NULL, "", + "", + +