From: Gregor Zattler Date: Mon, 30 Jan 2012 22:34:16 +0000 (+0100) Subject: Re: Bug?: notmuch-search-show-thread shows several threads; only one containing match... X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=322384a12978bfc240b9eceba7922dbf39be2925;p=notmuch-archives.git Re: Bug?: notmuch-search-show-thread shows several threads; only one containing matching messages --- diff --git a/90/8cfc2cacc89acd40d6c2f29d0120402028ffcd b/90/8cfc2cacc89acd40d6c2f29d0120402028ffcd new file mode 100644 index 000000000..ba5f620f8 --- /dev/null +++ b/90/8cfc2cacc89acd40d6c2f29d0120402028ffcd @@ -0,0 +1,117 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 23D61431E64 + for ; Mon, 30 Jan 2012 14:34:53 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0.001 +X-Spam-Level: +X-Spam-Status: No, score=0.001 tagged_above=-999 required=5 + tests=[FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id pUkjvp6Eu71I for ; + Mon, 30 Jan 2012 14:34:52 -0800 (PST) +Received: from mailout-de.gmx.net (mailout-de.gmx.net [213.165.64.23]) + by olra.theworths.org (Postfix) with SMTP id 2F86D431FBC + for ; Mon, 30 Jan 2012 14:34:52 -0800 (PST) +Received: (qmail invoked by alias); 30 Jan 2012 22:34:50 -0000 +Received: from p54BE2F5E.dip.t-dialin.net (EHLO shi.workgroup) [84.190.47.94] + by mail.gmx.net (mp029) with SMTP; 30 Jan 2012 23:34:50 +0100 +X-Authenticated: #19296480 +X-Provags-ID: V01U2FsdGVkX19n+fUZ8Z1niSsF2IzcN6zH1DAPYhfk0+/l89pzWr + 7rViV5HJfs308X +Received: from grfz by shi.workgroup with local (Exim 4.77) + (envelope-from ) + id 1Rrzo4-0000l4-RS; Mon, 30 Jan 2012 23:34:36 +0100 +Date: Mon, 30 Jan 2012 23:34:16 +0100 +From: Gregor Zattler +To: notmuch +Subject: Re: Bug?: notmuch-search-show-thread shows several threads; only one + containing matching messages +Message-ID: <20120130223416.GA26239@shi.workgroup> +Mail-Followup-To: notmuch +References: <20120126004024.GA13704@shi.workgroup> + <20120126011903.GA1176@mit.edu> + <8762fzry7k.fsf@servo.finestructure.net> + <20120126124450.GB30209@shi.workgroup> <87mx9avbc1.fsf@praet.org> + <20120129234213.GB11460@shi.workgroup> <87zkd5655g.fsf@praet.org> + <20120130190425.GB13521@shi.workgroup> <878vkoev95.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +Content-Disposition: inline +In-Reply-To: <878vkoev95.fsf@qmul.ac.uk> +User-Agent: Mutt/1.5.21 (2010-09-15) +X-Y-GMX-Trusted: 0 +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 30 Jan 2012 22:34:53 -0000 + +Hi Mark, +* Mark Walters [30. Jan. 2012]: +> On Mon, 30 Jan 2012 20:04:25 +0100, Gregor Zattler wrote: +>> * Pieter Praet [30. Jan. 2012]: +>>> On Mon, 30 Jan 2012 00:42:14 +0100, Gregor Zattler wrote: +>>>> * Pieter Praet [26. Jan. 2012]: +>>>>> Here's another couple of threads squashed into a single one: +>>>>> - [O] [Use Question] Capture and long lines +>>>>> - id:"BANLkTikoF4tXuNLLufRzNSD6k2ZYs7sUcg@mail.gmail.com" +>>>>> - [O] Worg update +>>>>> - id:"m1wrfiz3ch.fsf@tsdye.com" +>>>>> - [O] Table formula to convert hex to dec +>>>>> - id:"20110724080054.GB16388@x201" +>>>>> - [O] ICS import? +>>>>> - id:"20120125173421.GQ3747@x201" +>>>>> +>>>>> +>>>>> AFAICT, none of them share Message-Id's... +>>>> +>>>> Do you consider this a bug? +>>>> +>>> +>>> I do. No idea what causes it or how to fix it though... :) +>> +>> First I thougt it' not a severe bug since one see's more not less +>> messages in notmuch show buffer. But later I realised one also +>> sees less not more threads in notmuch search buffer and might not +>> read certain notmuch threads because of "wrong" $Subject: in +>> notmuch search buffer. + +> I think notmuch links two messages into the same thread if they have an +> in-reply-to or reference header in common: i.e the messages reference a +> common parent message. (See comment in lib/database.cc "Even before a +> message is added, it's pre-allocated thread ID is useful so that all +> descendant messages that reference this common parent can be recognized +> as belonging to the same thread.") + +So in case message a from thread A and message b from B would +name the same Message c in their In-Reoply-To:/References: +headers, while c is not (for some reason) in A or B, notmuch +would assume both threads linked? Makes sense. + +> As far as I can see your grep tests haven't checked for that. + +True. + +> Also, could you email me the mbox you had (I think you said that it was +> a mailing list so all public) and I will take a look? + +Sure, I do so off-list because of the size of the attachment. + + +Ciao, Gregor +-- + -... --- .-. . -.. ..--.. ...-.-