From: Jani Nikula Date: Fri, 30 Nov 2012 23:37:19 +0000 (+0200) Subject: Re: [Patch v2 07/17] notmuch-dump: add --format=(batch-tag|sup) X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=31b0e6b468198880cc87a2819ea57f2c6d3c9c8b;p=notmuch-archives.git Re: [Patch v2 07/17] notmuch-dump: add --format=(batch-tag|sup) --- diff --git a/91/74cab3195a06cc399eaf7e660fa20c76648a60 b/91/74cab3195a06cc399eaf7e660fa20c76648a60 new file mode 100644 index 000000000..8223d4171 --- /dev/null +++ b/91/74cab3195a06cc399eaf7e660fa20c76648a60 @@ -0,0 +1,208 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 80958431FAE + for ; Fri, 30 Nov 2012 15:37:28 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id nbDGbLS05XxI for ; + Fri, 30 Nov 2012 15:37:24 -0800 (PST) +Received: from mail-lb0-f181.google.com (mail-lb0-f181.google.com + [209.85.217.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id CF581431FAF + for ; Fri, 30 Nov 2012 15:37:23 -0800 (PST) +Received: by mail-lb0-f181.google.com with SMTP id ge1so976616lbb.26 + for ; Fri, 30 Nov 2012 15:37:22 -0800 (PST) +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=google.com; s=20120113; + h=from:to:cc:subject:in-reply-to:references:user-agent:date + :message-id:mime-version:content-type:x-gm-message-state; + bh=aGY7tumjfDKNLlBKh+QA7jViXLnCvdeOKyMUdWVxOSo=; + b=ANF2zQAdzwfdHRkUnI5upBzWgc83NMxN4YTk3/4a8DjEl1q7mShffiSS7LH1l9mAKe + Zka7UcKqTbqK6QFYSpWldYKB2FDDhmgLJCf/z0r7iKj/RrZWz7BTcF/5H+FvBHAaU4DF + dNQbfuf8hH4hkj5F+Q+4OdDtMyOkrQP+0ihaeCBa8zkHcsu4bckZRkmi5S8o+869ylG5 + 9y6ZgqITHCxCTyDtteFr09KAmWn/rnEIwasF/xf3yu/LV1Wa9CTu15PtYLknMeHqpNOm + F/+kTRD7jGcZkT5sGzDXKo0VnjJ/46CwKGCywhzPq1YufkkWB4Gr6mK23Vi+ZEKojLeU + ClEQ== +Received: by 10.112.25.168 with SMTP id d8mr1513108lbg.62.1354318642317; + Fri, 30 Nov 2012 15:37:22 -0800 (PST) +Received: from localhost (dsl-hkibrasgw4-fe51df00-27.dhcp.inet.fi. + [80.223.81.27]) + by mx.google.com with ESMTPS id q2sm2581307lbd.14.2012.11.30.15.37.20 + (version=SSLv3 cipher=OTHER); Fri, 30 Nov 2012 15:37:21 -0800 (PST) +From: Jani Nikula +To: david@tethera.net, notmuch@notmuchmail.org +Subject: Re: [Patch v2 07/17] notmuch-dump: add --format=(batch-tag|sup) +In-Reply-To: <1353792017-31459-8-git-send-email-david@tethera.net> +References: <1353792017-31459-1-git-send-email-david@tethera.net> + <1353792017-31459-8-git-send-email-david@tethera.net> +User-Agent: Notmuch/0.14+124~g3b17402 (http://notmuchmail.org) Emacs/23.4.1 + (i686-pc-linux-gnu) +Date: Sat, 01 Dec 2012 01:37:19 +0200 +Message-ID: <87ip8maci8.fsf@nikula.org> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Gm-Message-State: + ALoCoQlvcGtYDemL1cPY0KSExPODMlyXdIQUNAj8xDHQ6HrTCMEx/4FVRGcbXEHN6omMRuzpT8+z +Cc: David Bremner +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Fri, 30 Nov 2012 23:37:28 -0000 + +On Sat, 24 Nov 2012, david@tethera.net wrote: +> From: David Bremner +> +> sup is the old format, and remains the default, at least until +> restore is converted to parse this format. +> +> Each line of the batch- format is valid for notmuch tag, (with the +> "notmuch tag" omitted from the front of the line). The dump format +> only uses query strings of a single message-id. + +Valid for notmuch tag except for the hex encoding and empty set of tags. + +> Each space seperated tag/message-id is 'hex-encoded' to remove +> troubling characters. In particular this format won't have the same +> problem with e.g. spaces in message-ids or tags; they will be +> round-trip-able. +> --- +> dump-restore-private.h | 13 +++++++++++++ +> notmuch-dump.c | 42 ++++++++++++++++++++++++++++++++++++------ +> 2 files changed, 49 insertions(+), 6 deletions(-) +> create mode 100644 dump-restore-private.h +> +> diff --git a/dump-restore-private.h b/dump-restore-private.h +> new file mode 100644 +> index 0000000..896a004 +> --- /dev/null +> +++ b/dump-restore-private.h +> @@ -0,0 +1,13 @@ +> +#ifndef DUMP_RESTORE_PRIVATE_H +> +#define DUMP_RESTORE_PRIVATE_H +> + +> +#include "hex-escape.h" +> +#include "command-line-arguments.h" +> + +> +typedef enum dump_formats { +> + DUMP_FORMAT_AUTO, +> + DUMP_FORMAT_BATCH_TAG, +> + DUMP_FORMAT_SUP +> +} dump_format_t; +> + +> +#endif +> diff --git a/notmuch-dump.c b/notmuch-dump.c +> index 88f598a..045ca9e 100644 +> --- a/notmuch-dump.c +> +++ b/notmuch-dump.c +> @@ -19,6 +19,7 @@ +> */ +> +> #include "notmuch-client.h" +> +#include "dump-restore-private.h" +> +> int +> notmuch_dump_command (unused (void *ctx), int argc, char *argv[]) +> @@ -43,7 +44,13 @@ notmuch_dump_command (unused (void *ctx), int argc, char *argv[]) +> char *output_file_name = NULL; +> int opt_index; +> +> + int output_format = DUMP_FORMAT_SUP; +> + +> notmuch_opt_desc_t options[] = { +> + { NOTMUCH_OPT_KEYWORD, &output_format, "format", 'f', +> + (notmuch_keyword_t []){ { "sup", DUMP_FORMAT_SUP }, +> + { "batch-tag", DUMP_FORMAT_BATCH_TAG }, +> + { 0, 0 } } }, +> { NOTMUCH_OPT_STRING, &output_file_name, "output", 'o', 0 }, +> { 0, 0, 0, 0, 0 } +> }; +> @@ -83,27 +90,50 @@ notmuch_dump_command (unused (void *ctx), int argc, char *argv[]) +> */ +> notmuch_query_set_sort (query, NOTMUCH_SORT_UNSORTED); +> +> + char *buffer = NULL; +> + size_t buffer_size = 0; +> + +> for (messages = notmuch_query_search_messages (query); +> notmuch_messages_valid (messages); +> notmuch_messages_move_to_next (messages)) { +> int first = 1; +> + const char *message_id; +> + +> message = notmuch_messages_get (messages); +> + message_id = notmuch_message_get_message_id (message); +> +> - fprintf (output, +> - "%s (", notmuch_message_get_message_id (message)); +> + if (output_format == DUMP_FORMAT_SUP) { +> + fprintf (output, "%s (", message_id); +> + } +> +> for (tags = notmuch_message_get_tags (message); +> notmuch_tags_valid (tags); +> notmuch_tags_move_to_next (tags)) { +> - if (! first) +> - fprintf (output, " "); +> + const char *tag_str = notmuch_tags_get (tags); +> +> - fprintf (output, "%s", notmuch_tags_get (tags)); +> + if (! first) +> + fputs (" ", output); +> +> first = 0; +> + +> + if (output_format == DUMP_FORMAT_SUP) { +> + fputs (tag_str, output); +> + } else { +> + if (hex_encode (notmuch, tag_str, +> + &buffer, &buffer_size) != HEX_SUCCESS) +> + return 1; + +Maybe hex_encode errors would deserve an error message. Ditto below. + +Otherwise LGTM. + +BR, +Jani. + +> + fprintf (output, "+%s", buffer); +> + } +> } +> +> - fprintf (output, ")\n"); +> + if (output_format == DUMP_FORMAT_SUP) { +> + fputs (")\n", output); +> + } else { +> + if (hex_encode (notmuch, message_id, +> + &buffer, &buffer_size) != HEX_SUCCESS) +> + return 1; +> + fprintf (output, " -- id:%s\n", buffer); +> + } +> +> notmuch_message_destroy (message); +> } +> -- +> 1.7.10.4 +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch