From: Dmitry Kurochkin Date: Mon, 30 Jan 2012 02:26:13 +0000 (+0400) Subject: [PATCH v2 04/13] emacs: make "+" and "-" tagging operations in notmuch-show more... X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=30afa58c9d0949d2ae187bf7a2804a9d1ff25ca1;p=notmuch-archives.git [PATCH v2 04/13] emacs: make "+" and "-" tagging operations in notmuch-show more robust --- diff --git a/c7/e063da2b80f1f70cd6bc10a050b241c0f2b983 b/c7/e063da2b80f1f70cd6bc10a050b241c0f2b983 new file mode 100644 index 000000000..b44b74fa9 --- /dev/null +++ b/c7/e063da2b80f1f70cd6bc10a050b241c0f2b983 @@ -0,0 +1,178 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 99013429E4E + for ; Sun, 29 Jan 2012 18:27:47 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.799 +X-Spam-Level: +X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 40tB1drEOhG2 for ; + Sun, 29 Jan 2012 18:27:45 -0800 (PST) +Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com + [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id A5EA0429E34 + for ; Sun, 29 Jan 2012 18:27:43 -0800 (PST) +Received: by mail-bk0-f53.google.com with SMTP id 11so960260bke.26 + for ; Sun, 29 Jan 2012 18:27:43 -0800 (PST) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; + h=from:to:subject:date:message-id:x-mailer:in-reply-to:references; + bh=BRoFNgFZMGszZ0lxWKjSYg5xKR9s/9rVloL7JNfGA0g=; + b=FxSWprgPtvSM0lKIWQhZUNBHIdo8CbuNYEWapWNmso2hEKvt6rysOyWWMDpeFBEuO6 + U005xeyvVR/XRh3JGBhYNkj8WiD26JFnHRXcXE/S2JWfS0B5TIRtyNZx4P8l/6MEiL8K + CR5eXyrFcHIhvO/Sv0OcqneQa2unO28WoEflc= +Received: by 10.204.148.73 with SMTP id o9mr7823821bkv.46.1327890463377; + Sun, 29 Jan 2012 18:27:43 -0800 (PST) +Received: from localhost ([91.144.186.21]) + by mx.google.com with ESMTPS id ek9sm34251370bkb.10.2012.01.29.18.27.42 + (version=TLSv1/SSLv3 cipher=OTHER); + Sun, 29 Jan 2012 18:27:42 -0800 (PST) +From: Dmitry Kurochkin +To: notmuch@notmuchmail.org +Subject: [PATCH v2 04/13] emacs: make "+" and "-" tagging operations in + notmuch-show more robust +Date: Mon, 30 Jan 2012 06:26:13 +0400 +Message-Id: <1327890382-548-5-git-send-email-dmitry.kurochkin@gmail.com> +X-Mailer: git-send-email 1.7.8.3 +In-Reply-To: <1327890382-548-1-git-send-email-dmitry.kurochkin@gmail.com> +References: <1327725684-5887-1-git-send-email-dmitry.kurochkin@gmail.com> + <1327890382-548-1-git-send-email-dmitry.kurochkin@gmail.com> +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 30 Jan 2012 02:27:48 -0000 + +Before the change, "+" and "-" tagging operations in notmuch-show view +accepted only a single tag. The patch makes them use the recently +added `notmuch-read-tag-changes' function, which allows to enter +multiple tags with "+" and "-" prefixes. So after the change, "+" and +"-" bindings in notmuch-show view allow to both add and remove +multiple tags. The only difference between "+" and "-" is the +minibuffer initial input ("+" and "-" respectively). +--- + emacs/notmuch-show.el | 64 +++++++++++++++++------------------------------- + 1 files changed, 23 insertions(+), 41 deletions(-) + +diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el +index 84ac624..11dab2d 100644 +--- a/emacs/notmuch-show.el ++++ b/emacs/notmuch-show.el +@@ -38,8 +38,9 @@ + + (declare-function notmuch-call-notmuch-process "notmuch" (&rest args)) + (declare-function notmuch-fontify-headers "notmuch" nil) +-(declare-function notmuch-select-tag-with-completion "notmuch" (prompt &rest search-terms)) ++(declare-function notmuch-read-tag-changes "notmuch" (&optional initial-input &rest search-terms)) + (declare-function notmuch-search-show-thread "notmuch" nil) ++(declare-function notmuch-update-tags "notmuch" (current-tags tag-changes)) + + (defcustom notmuch-message-headers '("Subject" "To" "Cc" "Date") + "Headers that should be shown in a message, in this order. +@@ -1267,7 +1268,7 @@ Some useful entries are: + + (defun notmuch-show-mark-read () + "Mark the current message as read." +- (notmuch-show-remove-tag "unread")) ++ (notmuch-show-tag-message "-unread")) + + ;; Functions for getting attributes of several messages in the current + ;; thread. +@@ -1470,51 +1471,32 @@ than only the current message." + (message (format "Command '%s' exited abnormally with code %d" + shell-command exit-code)))))))) + +-(defun notmuch-show-add-tags-worker (current-tags add-tags) +- "Add to `current-tags' with any tags from `add-tags' not +-currently present and return the result." +- (let ((result-tags (copy-sequence current-tags))) +- (mapc (lambda (add-tag) +- (unless (member add-tag current-tags) +- (setq result-tags (push add-tag result-tags)))) +- add-tags) +- (sort result-tags 'string<))) +- +-(defun notmuch-show-del-tags-worker (current-tags del-tags) +- "Remove any tags in `del-tags' from `current-tags' and return +-the result." +- (let ((result-tags (copy-sequence current-tags))) +- (mapc (lambda (del-tag) +- (setq result-tags (delete del-tag result-tags))) +- del-tags) +- result-tags)) +- +-(defun notmuch-show-add-tag (&rest toadd) +- "Add a tag to the current message." +- (interactive +- (list (notmuch-select-tag-with-completion "Tag to add: "))) ++(defun notmuch-show-tag-message (&rest tag-changes) ++ "Change tags for the current message. + ++TAG-CHANGES is a list of tag operations for `notmuch-tag'." + (let* ((current-tags (notmuch-show-get-tags)) +- (new-tags (notmuch-show-add-tags-worker current-tags toadd))) +- ++ (new-tags (notmuch-update-tags current-tags tag-changes))) + (unless (equal current-tags new-tags) +- (apply 'notmuch-tag (notmuch-show-get-message-id) +- (mapcar (lambda (s) (concat "+" s)) toadd)) ++ (apply 'notmuch-tag (notmuch-show-get-message-id) tag-changes) + (notmuch-show-set-tags new-tags)))) + +-(defun notmuch-show-remove-tag (&rest toremove) +- "Remove a tag from the current message." +- (interactive +- (list (notmuch-select-tag-with-completion +- "Tag to remove: " (notmuch-show-get-message-id)))) ++(defun notmuch-show-tag (&optional initial-input) ++ "Change tags for the current message, read input from the minibuffer." ++ (interactive) ++ (let ((tag-changes (notmuch-read-tag-changes ++ initial-input (notmuch-show-get-message-id)))) ++ (apply 'notmuch-show-tag-message tag-changes))) + +- (let* ((current-tags (notmuch-show-get-tags)) +- (new-tags (notmuch-show-del-tags-worker current-tags toremove))) ++(defun notmuch-show-add-tag () ++ "Same as `notmuch-show-tag' but sets initial input to '+'." ++ (interactive) ++ (notmuch-show-tag "+")) + +- (unless (equal current-tags new-tags) +- (apply 'notmuch-tag (notmuch-show-get-message-id) +- (mapcar (lambda (s) (concat "-" s)) toremove)) +- (notmuch-show-set-tags new-tags)))) ++(defun notmuch-show-remove-tag () ++ "Same as `notmuch-show-tag' but sets initial input to '-'." ++ (interactive) ++ (notmuch-show-tag "-")) + + (defun notmuch-show-toggle-headers () + "Toggle the visibility of the current message headers." +@@ -1559,7 +1541,7 @@ argument, hide all of the messages." + (defun notmuch-show-archive-thread-internal (show-next) + ;; Remove the tag from the current set of messages. + (goto-char (point-min)) +- (loop do (notmuch-show-remove-tag "inbox") ++ (loop do (notmuch-show-tag-message "-inbox") + until (not (notmuch-show-goto-message-next))) + ;; Move to the next item in the search results, if any. + (let ((parent-buffer notmuch-show-parent-buffer)) +-- +1.7.8.3 +