From: Michal Sojka Date: Wed, 15 Feb 2012 23:18:31 +0000 (+0100) Subject: Re: [PATCH v2] emacs: Fix display of highlighted line in notmuch-search X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=304702f190a7d35c94f3d0548b98af78b89eb1d6;p=notmuch-archives.git Re: [PATCH v2] emacs: Fix display of highlighted line in notmuch-search --- diff --git a/62/05b1ff4e3d2211793798ba9924864e23c4d70d b/62/05b1ff4e3d2211793798ba9924864e23c4d70d new file mode 100644 index 000000000..c7651a0c1 --- /dev/null +++ b/62/05b1ff4e3d2211793798ba9924864e23c4d70d @@ -0,0 +1,91 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id B5940429E42 + for ; Wed, 15 Feb 2012 15:18:42 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -2.3 +X-Spam-Level: +X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id qGbAYiqjZHXX for ; + Wed, 15 Feb 2012 15:18:38 -0800 (PST) +Received: from max.feld.cvut.cz (max.feld.cvut.cz [147.32.192.36]) + by olra.theworths.org (Postfix) with ESMTP id C441C431E62 + for ; Wed, 15 Feb 2012 15:18:38 -0800 (PST) +Received: from localhost (unknown [192.168.200.4]) + by max.feld.cvut.cz (Postfix) with ESMTP id C611E19F3600; + Thu, 16 Feb 2012 00:18:37 +0100 (CET) +X-Virus-Scanned: IMAP AMAVIS +Received: from max.feld.cvut.cz ([192.168.200.1]) + by localhost (styx.feld.cvut.cz [192.168.200.4]) (amavisd-new, + port 10044) + with ESMTP id 9btytyhE69PC; Thu, 16 Feb 2012 00:18:32 +0100 (CET) +Received: from imap.feld.cvut.cz (imap.feld.cvut.cz [147.32.192.34]) + by max.feld.cvut.cz (Postfix) with ESMTP id 842AE19F35E3; + Thu, 16 Feb 2012 00:18:32 +0100 (CET) +Received: from steelpick.2x.cz (cable-86-56-3-85.cust.telecolumbus.net + [86.56.3.85]) (Authenticated sender: sojkam1) + by imap.feld.cvut.cz (Postfix) with ESMTPSA id 6F856660968; + Thu, 16 Feb 2012 00:18:32 +0100 (CET) +Received: from wsh by steelpick.2x.cz with local (Exim 4.77) + (envelope-from ) + id 1Rxo7L-0004z5-CH; Thu, 16 Feb 2012 00:18:31 +0100 +From: Michal Sojka +To: Dmitry Kurochkin , notmuch@notmuchmail.org +Subject: Re: [PATCH v2] emacs: Fix display of highlighted line in + notmuch-search +In-Reply-To: <87wr7ngand.fsf@gmail.com> +References: <87mx8lpd5o.fsf@nikula.org> + <1329239387-6300-1-git-send-email-sojka@os.inf.tu-dresden.de> + <87wr7ngand.fsf@gmail.com> +User-Agent: Notmuch/0.11.1+196~g4e14806 (http://notmuchmail.org) Emacs/23.3.1 + (x86_64-pc-linux-gnu) +Date: Thu, 16 Feb 2012 00:18:31 +0100 +Message-ID: <87ehtvheig.fsf@steelpick.2x.cz> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Mailman-Approved-At: Wed, 22 Feb 2012 08:28:25 -0800 +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 15 Feb 2012 23:18:42 -0000 + +On Wed, 15 Feb 2012, Dmitry Kurochkin wrote: +> Hi Michal. +> +> On Tue, 14 Feb 2012 18:09:47 +0100, Michal Sojka wrote: +> > When notmuch-search-line-faces is used to set background color in search +> > results, the highlight of the current line is not always displayed +> > correctly. This patch fixes that by increasing the priority property of +> > the highlight overlay. +> > --- +> +> How about changing `notmuch-search-color-line' to use text properties +> instead of overlays? Then hl-line overlay would take priority over it +> without these changes. +> +> See [1] by David Edmondson on why text properties are better in +> general. I plan to use text properties here to simplify updating the +> face when tags are changed. + +Hmm, I always wondered why notmuch uses overlays even if Elisp manual +says they don't scale. I remember that I wanted to replace that long +time ago, but there was some problem, which I forgot. Maybe it was the +invisibility David mentions. I guess there is some invisible text in +search output, isn't it? + +-Michal