From: David Bremner <david@tethera.net>
Date: Mon, 9 Apr 2012 22:17:30 +0000 (+2100)
Subject: Re: [PATCH] replace gnu xargs usage in notmuch-mutt with perl
X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=2fd63b1119866501cf272ca50821b33ed1c04112;p=notmuch-archives.git

Re: [PATCH] replace gnu xargs usage in notmuch-mutt with perl
---

diff --git a/2a/adf016ac5edc30f9d26602761954b1f02643c2 b/2a/adf016ac5edc30f9d26602761954b1f02643c2
new file mode 100644
index 000000000..f044fdc7f
--- /dev/null
+++ b/2a/adf016ac5edc30f9d26602761954b1f02643c2
@@ -0,0 +1,68 @@
+Return-Path: <bremner@unb.ca>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id CED4F4041F0
+	for <notmuch@notmuchmail.org>; Mon,  9 Apr 2012 15:17:39 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 0
+X-Spam-Level: 
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
+	autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id ioYzD9d2jQSh for <notmuch@notmuchmail.org>;
+	Mon,  9 Apr 2012 15:17:39 -0700 (PDT)
+Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])
+	(using TLSv1 with cipher AES256-SHA (256/256 bits))
+	(No client certificate requested)
+	by olra.theworths.org (Postfix) with ESMTPS id 65C594041EF
+	for <notmuch@notmuchmail.org>; Mon,  9 Apr 2012 15:17:39 -0700 (PDT)
+Received: from fctnnbsc30w-156034089108.dhcp-dynamic.fibreop.nb.bellaliant.net
+	([156.34.89.108] helo=zancas.localnet)
+	by tesseract.cs.unb.ca with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32)
+	(Exim 4.72) (envelope-from <bremner@unb.ca>)
+	id 1SHMu0-0004Di-SO; Mon, 09 Apr 2012 19:17:37 -0300
+Received: from bremner by zancas.localnet with local (Exim 4.77)
+	(envelope-from <bremner@unb.ca>)
+	id 1SHMtv-0005Gu-0x; Mon, 09 Apr 2012 19:17:31 -0300
+From: David Bremner <david@tethera.net>
+To: Taylor Carpenter <taylor@codecafe.com>, notmuch@notmuchmail.org
+Subject: Re: [PATCH] replace gnu xargs usage in notmuch-mutt with perl
+In-Reply-To: <20120409211153.GA6497@codecafe.com>
+References: <20120409211153.GA6497@codecafe.com>
+User-Agent: Notmuch/0.12+99~g075d7df (http://notmuchmail.org) Emacs/23.3.1
+	(x86_64-pc-linux-gnu)
+Date: Mon, 09 Apr 2012 19:17:30 -0300
+Message-ID: <87ehrwpn2d.fsf@zancas.localnet>
+MIME-Version: 1.0
+Content-Type: text/plain; charset=us-ascii
+X-Spam_bar: -
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Mon, 09 Apr 2012 22:17:40 -0000
+
+
+Hi Taylor, and thanks for the patch.
+
+In general for notmuch patches we prefer
+
+- some kind of commit message beyond the one line summary explaining the
+rationale for the change.
+
+- not to have unrelated changes (/usr/bin/env perl) in the patch.
+
+d
+
+