From: Ethan Glasser-Camp Date: Wed, 14 Nov 2012 02:46:00 +0000 (+1900) Subject: Re: [PATCH v2] test: Fix HTML rendering test X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=2d0adaba2e0d67e09dd3b5c7668eee70ca9d28a7;p=notmuch-archives.git Re: [PATCH v2] test: Fix HTML rendering test --- diff --git a/8c/589817224704418f80e48f6b329bd482cd34c7 b/8c/589817224704418f80e48f6b329bd482cd34c7 new file mode 100644 index 000000000..84b4a9757 --- /dev/null +++ b/8c/589817224704418f80e48f6b329bd482cd34c7 @@ -0,0 +1,78 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 6318F431FBC + for ; Tue, 13 Nov 2012 18:46:04 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.799 +X-Spam-Level: +X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id hSoqDpGxeZ-Y for ; + Tue, 13 Nov 2012 18:46:04 -0800 (PST) +Received: from mail-qc0-f181.google.com (mail-qc0-f181.google.com + [209.85.216.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 07DE3431FAF + for ; Tue, 13 Nov 2012 18:46:03 -0800 (PST) +Received: by mail-qc0-f181.google.com with SMTP id x40so3225743qcp.26 + for ; Tue, 13 Nov 2012 18:46:03 -0800 (PST) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; + h=from:to:cc:subject:in-reply-to:references:user-agent:date + :message-id:mime-version:content-type; + bh=JL73QnpQZriTa9uEn9fRUD3e6eOz0zyIE15oNv/QRck=; + b=mwT1VZVgC/OOXIvGwZUV4rAuNtWBLSp7mQCNltHAF1voQ2YOcxr0TADt/26vQfRrh3 + fTEbWecTlhmRx81/2XrV/se2lco05q7bND1deLhX4LQdWFBzuDslmLX4Bedm4rZHboLl + JyTgs1OEpwOkTtGnVFW22FgI+2c5Nx6LAXgz57u8YPNLjvPlEsZbp9IRJe/ZlryUooGQ + gRUJSLlbn0NWODfEULZkJKyEj6MjZjklsiIzODoYvcmJzlderbUp0FuykAk0R0CfMmsQ + jD2HXLWvNJMU+bDKP8Q9bB46pvRj9NTOoxosDqvPQ4JuFym2mDv9kaAxIzDeShW/NjsT + 5zAw== +Received: by 10.224.189.81 with SMTP id dd17mr24631170qab.64.1352861163562; + Tue, 13 Nov 2012 18:46:03 -0800 (PST) +Received: from smtp.gmail.com (mca2d36d0.tmodns.net. [208.54.45.202]) + by mx.google.com with ESMTPS id j3sm1322254qek.7.2012.11.13.18.46.02 + (version=TLSv1/SSLv3 cipher=OTHER); + Tue, 13 Nov 2012 18:46:02 -0800 (PST) +From: Ethan Glasser-Camp +To: Austin Clements , notmuch@notmuchmail.org +Subject: Re: [PATCH v2] test: Fix HTML rendering test +In-Reply-To: <1352682727-12533-1-git-send-email-amdragon@mit.edu> +References: <1352682727-12533-1-git-send-email-amdragon@mit.edu> +User-Agent: Notmuch/0.14+45~g6ea9330 (http://notmuchmail.org) Emacs/23.4.1 + (x86_64-pc-linux-gnu) +Date: Tue, 13 Nov 2012 21:46:00 -0500 +Message-ID: <87haos6gwn.fsf@betacantrips.com> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +Cc: tomi.ollila@iki.fi +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 14 Nov 2012 02:46:04 -0000 + +Austin Clements writes: + +> The test designed to exercise Emacs' rendering of HTML emails +> containing images inadvertently assumed w3m was available under Emacs +> 23. The real point of this test was to check that Emacs 24's shr +> renderer didn't crash when given img tags, so use shr if it's +> available, html2text otherwise (which is built in), and do only a +> simple sanity check of the result. + +This fixes the failing test on my machine. + +Ethan