From: David Edmondson Date: Tue, 31 Jan 2012 17:01:28 +0000 (+0000) Subject: Re: [PATCH 0/5 v3] reworked crypto toggle, plus a few other toggles X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=2c5fb1b0904be83eda445926d48270f556e2ebec;p=notmuch-archives.git Re: [PATCH 0/5 v3] reworked crypto toggle, plus a few other toggles --- diff --git a/f3/b1a5b9a931dc58f2f7f7bd2f9e86132ecfe349 b/f3/b1a5b9a931dc58f2f7f7bd2f9e86132ecfe349 new file mode 100644 index 000000000..30170d7aa --- /dev/null +++ b/f3/b1a5b9a931dc58f2f7f7bd2f9e86132ecfe349 @@ -0,0 +1,155 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 24C34429E25 + for ; Tue, 31 Jan 2012 09:01:41 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 8Izxz26FJzAB for ; + Tue, 31 Jan 2012 09:01:40 -0800 (PST) +Received: from mail-ww0-f45.google.com (mail-ww0-f45.google.com + [74.125.82.45]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client + certificate requested) by olra.theworths.org (Postfix) with ESMTPS id + 53E34431E64 for ; Tue, 31 Jan 2012 09:01:40 -0800 + (PST) +Received: by wgbdt12 with SMTP id dt12so180724wgb.2 + for ; Tue, 31 Jan 2012 09:01:39 -0800 (PST) +Received: by 10.180.90.194 with SMTP id by2mr12639800wib.5.1328029299210; + Tue, 31 Jan 2012 09:01:39 -0800 (PST) +Received: from hotblack-desiato.hh.sledj.net + (host81-149-164-25.in-addr.btopenworld.com. [81.149.164.25]) + by mx.google.com with ESMTPS id y1sm12982970wiw.6.2012.01.31.09.01.37 + (version=TLSv1/SSLv3 cipher=OTHER); + Tue, 31 Jan 2012 09:01:38 -0800 (PST) +Received: by hotblack-desiato.hh.sledj.net (Postfix, from userid 30000) + id 0CACF9FF33; Tue, 31 Jan 2012 17:01:36 +0000 (GMT) +To: Jameson Graef Rollins , + notmuch@notmuchmail.org +Subject: Re: [PATCH 0/5 v3] reworked crypto toggle, plus a few other toggles +In-Reply-To: <871uqf3kbl.fsf@servo.finestructure.net> +References: <1327486729-18052-1-git-send-email-dme@dme.org> + <1327941064-20027-1-git-send-email-dme@dme.org> + <87pqe1w095.fsf@servo.finestructure.net> + + <871uqf3kbl.fsf@servo.finestructure.net> +User-Agent: Notmuch/0.11+137~g7cd907b (http://notmuchmail.org) Emacs/24.0.92.1 + (x86_64-pc-linux-gnu) +From: David Edmondson +Date: Tue, 31 Jan 2012 17:01:28 +0000 +Message-ID: +MIME-Version: 1.0 +Content-Type: multipart/signed; boundary="=-=-="; + micalg=pgp-sha1; protocol="application/pgp-signature" +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 31 Jan 2012 17:01:41 -0000 + +--=-=-= +Content-Type: text/plain +Content-Transfer-Encoding: quoted-printable + +On Tue, 31 Jan 2012 08:31:26 -0800, Jameson Graef Rollins wrote: +> On Tue, 31 Jan 2012 08:09:08 +0000, David Edmondson wrote: +> > On Mon, 30 Jan 2012 09:47:34 -0800, Jameson Graef Rollins wrote: +> > > One thing I've noticed, which isn't actually part of this patch, is t= +hat +> > > the long-line truncation doesn't respect the indentation, which makes +> > > things look strange. +> >=20 +> > Which lines are getting wrapped in a way that you don't like? The header +> > line? The headers? The body? +>=20 +> Header lines, such as Subject, To, Cc, etc. + +You could try out id:"1327565871-19729-3-git-send-email-dme@dme.org". + +> > > But honestly I still don't like our method of displaying threads as a +> > > giant chain of concatenated messages with indentation. But that's for +> > > later work. +> >=20 +> > It's inherited from sup, and is surely part of the "raison de notmuch" +> > :-) +>=20 +> Inheritance is not a good justification for anything, much less +> questionable UI choices (I seem to have inherited baldness from my dad. +> Thanks dad). + +I didn't suggest that inheritance was justification. Whether it's a +questionable UI choice is largely a matter of personal preference. When +Carl started the project he chose to follow sup's example in this +respect. (Though sup is more aggressive in scrolling the display to the +left to accommodate deep threads.) + +> Problems I have with the current approach: +>=20 +> - thread structure is opaque. This is especially true with long +> threads, where it can be next to impossible to see which messages are +> replies to what. This is by far my biggest pet peeve with the current +> format. + +A collapsed view of the current `notmuch-show-mode' buffer is not very +different to a mutt index view. + +> - navigation through the thread is difficult. This is related to above. +> There's no way to simultaneously see the current message and the +> thread structure, which again, makes it very difficult to find +> children and parents. This could possibly be fixed by having key +> bindings that would navigate through parents, children and siblings of +> the current message, but that might be tricky to implement. + +It would be relatively simple to add the bindings you describe, based on +the computed thread depth of messages. So far I haven't particularly +missed being able to do it. + +> - indentation of the entire message body is a really bad way to indicate +> thread depth. I don't like how messages start to walk off screen as +> threads get longer, or how copying regions of the body brings the +> indentation with it. Your indentation toggling will improve this a +> bit, though, but I still think it's a bandaid on the larger issue. + +The indentation works well until threads are more than about ten levels +deep, I find. It becomes unworkable after about twenty levels (but +conversations that deep tend to stress both the UI and myself in other +ways as well). + +I don't copy regions of the `notmuch-show-mode' buffer, so that hasn't +been a problem. + +> I must say that the approach I've been longing for is a modified version +> of what mutt has: a top pain that is just the thread structure (with +> nice branching lines), and a bottom pain that displays the current +> message. I think that would be a much cleaner approach. + +Nothing precludes the implementation of what you describe. It's not hard +to see how the two approaches could live side by side. + +--=-=-= +Content-Type: application/pgp-signature + +-----BEGIN PGP SIGNATURE----- +Version: GnuPG v1.4.11 (GNU/Linux) + +iEYEARECAAYFAk8oHmgACgkQaezQq/BJZRaFzwCePk1ZdGWIysSyF9qCuxK6qJbp +mFUAnilePPTh6wRKsnCntEb+Sk625hWH +=hNug +-----END PGP SIGNATURE----- +--=-=-=--