From: David Bremner <david@tethera.net>
Date: Sat, 27 Oct 2012 12:46:01 +0000 (+2100)
Subject: Re: [PATCH 1/3] emacs: Introduce generic boolean term escaping function
X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=2c5b5a35e0b27d7e08bb4564b4f30a1e420bf340;p=notmuch-archives.git

Re: [PATCH 1/3] emacs: Introduce generic boolean term escaping function
---

diff --git a/b3/e1d0427e28d0dd42152b77c82b43328fa2f1fb b/b3/e1d0427e28d0dd42152b77c82b43328fa2f1fb
new file mode 100644
index 000000000..006ccc0e5
--- /dev/null
+++ b/b3/e1d0427e28d0dd42152b77c82b43328fa2f1fb
@@ -0,0 +1,67 @@
+Return-Path: <bremner@unb.ca>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id E33B1431FC4
+	for <notmuch@notmuchmail.org>; Sat, 27 Oct 2012 05:46:17 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 0
+X-Spam-Level: 
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
+	autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id GdjT5rdClJoM for <notmuch@notmuchmail.org>;
+	Sat, 27 Oct 2012 05:46:17 -0700 (PDT)
+Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])
+	(using TLSv1 with cipher AES256-SHA (256/256 bits))
+	(No client certificate requested)
+	by olra.theworths.org (Postfix) with ESMTPS id 537C9431FAE
+	for <notmuch@notmuchmail.org>; Sat, 27 Oct 2012 05:46:17 -0700 (PDT)
+Received: from fctnnbsc30w-156034089108.dhcp-dynamic.fibreop.nb.bellaliant.net
+	([156.34.89.108] helo=zancas.localnet)
+	by tesseract.cs.unb.ca with esmtpsa
+	(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72)
+	(envelope-from <bremner@unb.ca>)
+	id 1TS5mK-0002Nh-HB; Sat, 27 Oct 2012 09:46:16 -0300
+Received: from bremner by zancas.localnet with local (Exim 4.80)
+	(envelope-from <bremner@unb.ca>)
+	id 1TS5mE-0005bQ-0e; Sat, 27 Oct 2012 09:46:10 -0300
+From: David Bremner <david@tethera.net>
+To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
+Subject: Re: [PATCH 1/3] emacs: Introduce generic boolean term escaping
+	function
+In-Reply-To: <1351282692-11455-1-git-send-email-amdragon@mit.edu>
+References: <1351282692-11455-1-git-send-email-amdragon@mit.edu>
+User-Agent: Notmuch/0.14+37~gf227d63 (http://notmuchmail.org) Emacs/24.1.1
+	(x86_64-pc-linux-gnu)
+Date: Sat, 27 Oct 2012 09:46:01 -0300
+Message-ID: <871ugk6q2e.fsf@zancas.localnet>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-Spam_bar: -
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Sat, 27 Oct 2012 12:46:18 -0000
+
+Austin Clements <amdragon@MIT.EDU> writes:
+
+> Currently, we only properly escape stashed id queries, but there are
+> other places where the Emacs UI constructs queries for boolean terms.
+> Since this escaping function is meant to be used in other places, it
+> avoids escaping strings that don't need escaping.
+
+Pushed all 3.
+
+d