From: Tomi Ollila <tomi.ollila@iki.fi>
Date: Thu, 8 Nov 2012 08:55:36 +0000 (+0200)
Subject: Re: [PATCH v2 07/10] gen-version-script: parse Solaris "nm" output (Solaris support)
X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=2ba42a3b0b31bcdd5f5372cb3898199929c5d3de;p=notmuch-archives.git

Re: [PATCH v2 07/10] gen-version-script: parse Solaris "nm" output (Solaris support)
---

diff --git a/13/f292c5e111cd29cc0d3566f55e7e97fd34104a b/13/f292c5e111cd29cc0d3566f55e7e97fd34104a
new file mode 100644
index 000000000..4a4324084
--- /dev/null
+++ b/13/f292c5e111cd29cc0d3566f55e7e97fd34104a
@@ -0,0 +1,113 @@
+Return-Path: <tomi.ollila@iki.fi>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id 70170431FB6
+	for <notmuch@notmuchmail.org>; Thu,  8 Nov 2012 00:55:38 -0800 (PST)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 0
+X-Spam-Level: 
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
+	autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id YFKg8TAXYXcK for <notmuch@notmuchmail.org>;
+	Thu,  8 Nov 2012 00:55:37 -0800 (PST)
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
+	by olra.theworths.org (Postfix) with ESMTP id BC8DB431FAE
+	for <notmuch@notmuchmail.org>; Thu,  8 Nov 2012 00:55:37 -0800 (PST)
+Received: from guru.guru-group.fi (localhost [IPv6:::1])
+	by guru.guru-group.fi (Postfix) with ESMTP id A6991100094;
+	Thu,  8 Nov 2012 10:55:36 +0200 (EET)
+From: Tomi Ollila <tomi.ollila@iki.fi>
+To: Blake Jones <blakej@foo.net>
+Subject: Re: [PATCH v2 07/10] gen-version-script: parse Solaris "nm" output
+	(Solaris support)
+In-Reply-To: <24582.1352356152@foo.net>
+References: <24582.1352356152@foo.net>
+User-Agent: Notmuch/0.14+84~g8a199bf (http://notmuchmail.org) Emacs/24.2.1
+	(x86_64-unknown-linux-gnu)
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
+	$[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
+	!)g;OY^,BjTbr)Np:%c_o'jj,Z
+Date: Thu, 08 Nov 2012 10:55:36 +0200
+Message-ID: <m2bof8fp87.fsf@guru.guru-group.fi>
+MIME-Version: 1.0
+Content-Type: text/plain
+Cc: notmuch@notmuchmail.org
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Thu, 08 Nov 2012 08:55:38 -0000
+
+On Thu, Nov 08 2012, Blake Jones <blakej@foo.net> wrote:
+
+>>> @@ -11,10 +12,44 @@ fi
+>>>  HEADER=$1
+>>>  shift
+>>>  
+>>> +if [ `uname -s` == SunOS ] ; then
+>>> +    #
+>>> +    # Using Solaris "nm", a defined symbol looks like this:
+>>> +    #
+>> 
+>> The POSIX / Bourne -comformant equality comparison is '='. 
+>
+> Sigh, of course it is.  Fixed.
+>
+>> e.g.
+>> 
+>> $ ./heirloom-sh/sh -c ' [ a == b ] || echo x'
+>> ./heirloom-sh/sh: test: unknown operator ==
+>> zsh: exit 1     ./heirloom-sh/sh -c ' [ a == b ] || echo x'
+>> 
+>> Interesting that Solaris /bin/sh did not fail there...
+>
+> I was running on Solaris 11.1, which uses ksh93 as its /bin/sh.  You're
+> absolutely right that Solaris 10 would fall over, though.
+>
+> Similarly, the following line:
+>
+>     demangled=$(demangle $sym)
+>
+> doesn't work on traditional sh.  I've replaced $() with ``.
+>
+>> Hmm, gen-version-script doesn't have shebang... it is run like:
+>> 
+>> sh $(srcdir)/$(lib)/gen-version-script.sh $< $(libnotmuch_modules) > $@
+>> 
+>> in lib/Makefile.local -- taking sh fron PATH.
+>
+> I updated the first line from the #! invocation to a comment saying
+>
+>     # This script is invoked via "sh .../gen-version-script.sh".
+
+looks good
+
+> Would a respun version of these patches help toward testing?
+
+$ grep vim test/*
+zsh: exit 1     grep vim test/*
+
+i.e. no vim tests...
+
+Also, as *I* will execute my tests in Linux these won't make things
+fail -- and probably no-one else eager to test won't have problems
+either
+
+So I think these patches are good until someone(tm) finds other
+issues (if any),
+
+> Blake
+
+Tomi