From: Eric S. Raymond <esr@thyrsus.com>
Date: Mon, 1 Oct 2012 02:03:30 +0000 (-0400)
Subject: Note a bug.
X-Git-Tag: 1.3~18
X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=2b533ae06eeed225cdd861b0ec351f1c141dad9e;p=irker.git

Note a bug.
---

diff --git a/BUGS b/BUGS
index 199419c..2c3e506 100644
--- a/BUGS
+++ b/BUGS
@@ -3,6 +3,4 @@
 * Despite what the header comment implies, the URL prefix and message template
   in irkerhook.py can at present only be modified by hacking the script.
 
-* DoS attacks on irker instances are not presently very difficult.
-  Some mechanism for reaping old connections when near exhaustion of
-  thread instances or file descriptors would be a good idea.
+* We shouldn't generate bogus URLS when the repo doesm't have a web view.
diff --git a/irkerhook.py b/irkerhook.py
index 781670f..bcc8275 100755
--- a/irkerhook.py
+++ b/irkerhook.py
@@ -68,9 +68,10 @@ class GenericExtractor:
         self.logmsg = None
         self.rev = None
         self.color = False
+        # Color highlighting is disabled by default.
         self.bold = self.green = self.blue = ""
         self.yellow = self.brown = self.reset = ""
-    def activate_color(self)
+    def activate_color(self):
         "IRC color codes."
         self.bold = '\x02'
         self.green = '\x033'