From: Austin Clements Date: Wed, 15 Feb 2012 23:59:07 +0000 (+1900) Subject: Re: [RFC PATCH v5 00/11] Add NOTMUCH_MESSAGE_FLAG_EXCLUDED flag X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=2b49525bdb577e005bd528392a3d1e46cf2781be;p=notmuch-archives.git Re: [RFC PATCH v5 00/11] Add NOTMUCH_MESSAGE_FLAG_EXCLUDED flag --- diff --git a/36/2294cfb3d7764013f3ee1b48383a0c804afb4e b/36/2294cfb3d7764013f3ee1b48383a0c804afb4e new file mode 100644 index 000000000..57ec14f56 --- /dev/null +++ b/36/2294cfb3d7764013f3ee1b48383a0c804afb4e @@ -0,0 +1,113 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 294FE431E62 + for ; Wed, 15 Feb 2012 16:00:52 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id O5CgZm-e1k8w for ; + Wed, 15 Feb 2012 16:00:51 -0800 (PST) +Received: from dmz-mailsec-scanner-7.mit.edu (DMZ-MAILSEC-SCANNER-7.MIT.EDU + [18.7.68.36]) + by olra.theworths.org (Postfix) with ESMTP id 7230C429E42 + for ; Wed, 15 Feb 2012 16:00:51 -0800 (PST) +X-AuditID: 12074424-b7fae6d000000906-32-4f3c4731432b +Received: from mailhub-auth-3.mit.edu ( [18.9.21.43]) + by dmz-mailsec-scanner-7.mit.edu (Symantec Messaging Gateway) with SMTP + id 97.6D.02310.1374C3F4; Wed, 15 Feb 2012 19:00:49 -0500 (EST) +Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) + by mailhub-auth-3.mit.edu (8.13.8/8.9.2) with ESMTP id q1G00mTT030779; + Wed, 15 Feb 2012 19:00:49 -0500 +Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) + (authenticated bits=0) + (User authenticated as amdragon@ATHENA.MIT.EDU) + by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q1G00kdu020719 + (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); + Wed, 15 Feb 2012 19:00:47 -0500 (EST) +Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77) + (envelope-from ) + id 1Rxokd-0008Ot-Kc; Wed, 15 Feb 2012 18:59:07 -0500 +Date: Wed, 15 Feb 2012 18:59:07 -0500 +From: Austin Clements +To: Jameson Graef Rollins +Subject: Re: [RFC PATCH v5 00/11] Add NOTMUCH_MESSAGE_FLAG_EXCLUDED flag +Message-ID: <20120215235907.GY27039@mit.edu> +References: <1329296619-7463-1-git-send-email-markwalters1009@gmail.com> + <8739acrnu7.fsf@servo.finestructure.net> + <8739aber9o.fsf@qmul.ac.uk> + <874nurrbdb.fsf@servo.finestructure.net> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +Content-Disposition: inline +In-Reply-To: <874nurrbdb.fsf@servo.finestructure.net> +User-Agent: Mutt/1.5.21 (2010-09-15) +X-Brightmail-Tracker: + H4sIAAAAAAAAA+NgFuphleLIzCtJLcpLzFFi42IR4hTV1jV0t/E3aJ4obrFnn5fF6rk8Ftdv + zmR2YPa4e5rLY+esu+wez1bdYg5gjuKySUnNySxLLdK3S+DKmLlwAmPBY56KV6feszUwTuXq + YuTkkBAwkTixbDoLhC0mceHeerYuRi4OIYF9jBJ/J01nhHA2MErM2faBCcI5ySSx6tAVKGcJ + o8TJS48YQfpZBFQlFjT9ZgKx2QQ0JLbtXw4WFxEwk+j58gfMZhZwlZhxYRdYjbCAh8SShxPZ + QWxeAR2JxqVzWSGG7mGU2LVqDlRCUOLkzCcsEM1aEjf+vQRq5gCypSWW/+MACXMKmEp83HwA + bL6ogIrElJPb2CYwCs1C0j0LSfcshO4FjMyrGGVTcqt0cxMzc4pTk3WLkxPz8lKLdM31cjNL + 9FJTSjcxggKd3UVlB2PzIaVDjAIcjEo8vBzMNv5CrIllxZW5hxglOZiURHm/ugKF+JLyUyoz + Eosz4otKc1KLDzFKcDArifBqT7f2F+JNSaysSi3Kh0lJc7AoifNqaL3zExJITyxJzU5NLUgt + gsnKcHAoSfBudAMaKliUmp5akZaZU4KQZuLgBBnOAzR8IkgNb3FBYm5xZjpE/hSjopQ473KQ + hABIIqM0D64XloheMYoDvSLMOwmkigeYxOC6XwENZgIabP7CCmRwSSJCSqqBUe5NiW0541q3 + TWsbIrt4zxdxuU/muRL7MX+SCWvonr0blPlfv5YOq3rFx14gnGDmLhpc+1R8qtv07fLLNRaf + qUgrTrnF1/NJ0dbt6YG04AUH7+69s9q04i1DFZM7L3fyhz6fD7rFJZm/9+7xUZjIzeixdarg + jvApAgHX/fOj9p5KcqjsNkhVYinOSDTUYi4qTgQAET4B7x8DAAA= +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 16 Feb 2012 00:00:52 -0000 + +Quoth Jameson Graef Rollins on Feb 15 at 2:16 pm: +> On Wed, 15 Feb 2012 21:11:15 +0000, Mark Walters wrote: +> > I think the difficulty is that there are lots of annoying corner cases, +> > but if there is a simpler solution that would be great! +> +> I think there is! + +There's been a fair bit of discussion of this at +id:"871uqvgrnm.fsf@qmul.ac.uk" (already pointed out on IRC, but I +figured I'd point it out here for others). + +There are some drawbacks to separating out the exclude flag, but +personally I think they're minor and that doing so opens up a lot of +interesting UI possibilities as well as providing a very clean and +consistent interface. + +> > 1) What should notmuch show id:deleted-message-id do? +> > +> > It could return the thread containing the deleted message. If it does +> > return a thread what subject does it assign it? Possibly it could +> > return no messages and the caller would have to call it again with +> > --no-exclude. +> +> "notmuch show id:" should always return the message +> matching id: with match=true. In fact, any search that +> references a specific id: should always process the message as if there +> were no excludes at all. + +This sounds terribly inconsistent to me. Even setting that aside, I +can't think of a reasonable way to implement this. What does it mean +for a search to reference a specific id? Do you special case when the +query begins with the string "id:"? Do you parse the query? Do you +check if the unexcluded search matches exactly one message and do +something different in that case?