From: David Edmondson Date: Thu, 26 Jan 2012 14:40:26 +0000 (+0000) Subject: Re: [RFC] Re: [PATCH] emacs: Add `notmuch-show-stash-gmane' and `notmuch-show-stash... X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=2a6790d25d01a4e91032298662f2b0702ed4d31d;p=notmuch-archives.git Re: [RFC] Re: [PATCH] emacs: Add `notmuch-show-stash-gmane' and `notmuch-show-stash-gmane-and-go'. --- diff --git a/12/e86e94c312a5e9cc7fce413d6bf483077dba3b b/12/e86e94c312a5e9cc7fce413d6bf483077dba3b new file mode 100644 index 000000000..5bb6ca604 --- /dev/null +++ b/12/e86e94c312a5e9cc7fce413d6bf483077dba3b @@ -0,0 +1,87 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id A9EB9431FAF + for ; Thu, 26 Jan 2012 06:40:36 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id RJzLtIVkfnCn for ; + Thu, 26 Jan 2012 06:40:36 -0800 (PST) +Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com + [209.85.212.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 1E561431FAE + for ; Thu, 26 Jan 2012 06:40:35 -0800 (PST) +Received: by wibhi8 with SMTP id hi8so483170wib.26 + for ; Thu, 26 Jan 2012 06:40:33 -0800 (PST) +Received: by 10.180.95.105 with SMTP id dj9mr3977358wib.18.1327588833806; + Thu, 26 Jan 2012 06:40:33 -0800 (PST) +Received: from hotblack-desiato.hh.sledj.net + (host81-149-164-25.in-addr.btopenworld.com. [81.149.164.25]) + by mx.google.com with ESMTPS id bu13sm13217656wib.6.2012.01.26.06.40.31 + (version=TLSv1/SSLv3 cipher=OTHER); + Thu, 26 Jan 2012 06:40:32 -0800 (PST) +Received: by hotblack-desiato.hh.sledj.net (Postfix, from userid 30000) + id 5E8D3A0141; Thu, 26 Jan 2012 14:40:30 +0000 (GMT) +To: Pieter Praet +Subject: Re: [RFC] Re: [PATCH] emacs: Add `notmuch-show-stash-gmane' and + `notmuch-show-stash-gmane-and-go'. +In-Reply-To: <1327583610-30085-1-git-send-email-pieter@praet.org> +References: <87pqe6vcgv.fsf@praet.org> + <1327583610-30085-1-git-send-email-pieter@praet.org> +User-Agent: Notmuch/0.11+114~g550724b (http://notmuchmail.org) Emacs/24.0.92.1 + (x86_64-pc-linux-gnu) +From: David Edmondson +Date: Thu, 26 Jan 2012 14:40:26 +0000 +Message-ID: +MIME-Version: 1.0 +Content-Type: multipart/signed; boundary="=-=-="; + micalg=pgp-sha1; protocol="application/pgp-signature" +Cc: Notmuch Mail +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 26 Jan 2012 14:40:36 -0000 + +--=-=-= +Content-Type: text/plain + +In general, I like this. + +- I think that the stash function(s) should take an optional argument + specifying the archive to use. That will make testing simpler and also + allow people to produce preferred bindings more easily. + +- "Message archive: " feels better than "ML Archive: ", but I don't + really care. + +- Don't base the patch on the thing that I posted, just on master from + the repository - no need to make David's life harder. + +--=-=-= +Content-Type: application/pgp-signature + +-----BEGIN PGP SIGNATURE----- +Version: GnuPG v1.4.11 (GNU/Linux) + +iEYEARECAAYFAk8hZdoACgkQaezQq/BJZRYrAACaAmA7TRdZAYjG+nQoIMQk6ENs +d2cAnjvxSk3FhuWmUGs37hCQRx9VH75Q +=r/Qr +-----END PGP SIGNATURE----- +--=-=-=--