From: Tomi Ollila <tomi.ollila@iki.fi>
Date: Wed, 28 Nov 2012 12:31:21 +0000 (+0200)
Subject: Re: [PATCH] configure: really expand libdir_expanded
X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=271b895f99b318756b8abaa9ea321834c6b2fb0e;p=notmuch-archives.git

Re: [PATCH] configure: really expand libdir_expanded
---

diff --git a/2e/1ab7e398b747b4bf58a518fd75c0aac6f86c28 b/2e/1ab7e398b747b4bf58a518fd75c0aac6f86c28
new file mode 100644
index 000000000..37df951d4
--- /dev/null
+++ b/2e/1ab7e398b747b4bf58a518fd75c0aac6f86c28
@@ -0,0 +1,96 @@
+Return-Path: <tomi.ollila@iki.fi>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id D3945431FAF
+	for <notmuch@notmuchmail.org>; Wed, 28 Nov 2012 04:31:24 -0800 (PST)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 0
+X-Spam-Level: 
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
+	autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id kwyRuLCBZfPR for <notmuch@notmuchmail.org>;
+	Wed, 28 Nov 2012 04:31:23 -0800 (PST)
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
+	by olra.theworths.org (Postfix) with ESMTP id B6CA7431FAE
+	for <notmuch@notmuchmail.org>; Wed, 28 Nov 2012 04:31:23 -0800 (PST)
+Received: from guru.guru-group.fi (localhost [IPv6:::1])
+	by guru.guru-group.fi (Postfix) with ESMTP id 7E53F1000E5;
+	Wed, 28 Nov 2012 14:31:21 +0200 (EET)
+From: Tomi Ollila <tomi.ollila@iki.fi>
+To: david@tethera.net, notmuch@notmuchmail.org
+Subject: Re: [PATCH] configure: really expand libdir_expanded
+In-Reply-To: <1354105552-31297-1-git-send-email-david@tethera.net>
+References: <1354105552-31297-1-git-send-email-david@tethera.net>
+User-Agent: Notmuch/0.14+116~g29fcdb5 (http://notmuchmail.org) Emacs/24.2.1
+	(x86_64-unknown-linux-gnu)
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
+	$[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
+	!)g;OY^,BjTbr)Np:%c_o'jj,Z
+Date: Wed, 28 Nov 2012 14:31:21 +0200
+Message-ID: <m2ip8pewo6.fsf@guru.guru-group.fi>
+MIME-Version: 1.0
+Content-Type: text/plain
+Cc: David Bremner <bremner@debian.org>
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Wed, 28 Nov 2012 12:31:25 -0000
+
+On Wed, Nov 28 2012, david@tethera.net wrote:
+
+> From: David Bremner <bremner@debian.org>
+>
+> It turns out that if people really use configure in autotools style and pass
+> libdir containing '${prefix}/foo' then the ldconfig previously failed.
+>
+> This uses sed for portability (versus bash parameter expansion with
+> substitution) and hopefully a bit more robustness than blindly
+> parameter expanding the string.
+> ---
+
+For the record: +1
+
+Tomi
+
+
+>  configure |    7 ++++++-
+>  1 file changed, 6 insertions(+), 1 deletion(-)
+>
+> diff --git a/configure b/configure
+> index ea8a1ad..460fcfc 100755
+> --- a/configure
+> +++ b/configure
+> @@ -236,7 +236,12 @@ done
+>  # Makefile.config file later like most values), because we need to
+>  # actually investigate this value compared to the ldconfig_paths value
+>  # below.
+> -libdir_expanded=${LIBDIR:-${PREFIX}/lib}
+> +if [ -z "$LIBDIR" ] ; then
+> +    libdir_expanded="${PREFIX}/lib"
+> +else
+> +    # very non-general variable expansion
+> +    libdir_expanded=`echo "$LIBDIR" | sed "s|\\${prefix}|${PREFIX}|g; s|\\$prefix/|${PREFIX}/|; s|//*|/|g"`
+> +fi
+>  
+>  cat <<EOF
+>  Welcome to Notmuch, a system for indexing, searching and tagging your email.
+> -- 
+> 1.7.10.4
+>
+> _______________________________________________
+> notmuch mailing list
+> notmuch@notmuchmail.org
+> http://notmuchmail.org/mailman/listinfo/notmuch