From: Tomi Ollila Date: Sun, 2 Sep 2012 20:18:46 +0000 (+0300) Subject: [PATCH V2 2b/2] {., man}/Makefile.local: edit/remove release-checks.sh related targets X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=26437fd4736adc1400357efcb73f60bd8340dadd;p=notmuch-archives.git [PATCH V2 2b/2] {., man}/Makefile.local: edit/remove release-checks.sh related targets --- diff --git a/ed/13a96ab5c92e8adf9d390fe4341b0d8073f935 b/ed/13a96ab5c92e8adf9d390fe4341b0d8073f935 new file mode 100644 index 000000000..9c7fe5825 --- /dev/null +++ b/ed/13a96ab5c92e8adf9d390fe4341b0d8073f935 @@ -0,0 +1,142 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id C9B86431FB6 + for ; Sun, 2 Sep 2012 13:18:51 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Amavis-Alert: BAD HEADER SECTION, Duplicate header field: "References" +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id beJLrPTRprPZ for ; + Sun, 2 Sep 2012 13:18:50 -0700 (PDT) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by olra.theworths.org (Postfix) with ESMTP id 534C7431FAF + for ; Sun, 2 Sep 2012 13:18:50 -0700 (PDT) +Received: by guru.guru-group.fi (Postfix, from userid 501) + id CF78810014E; Sun, 2 Sep 2012 23:18:56 +0300 (EEST) +From: Tomi Ollila +To: notmuch@notmuchmail.org +Subject: [PATCH V2 2b/2] {., + man}/Makefile.local: edit/remove release-checks.sh related targets +Date: Sun, 2 Sep 2012 23:18:46 +0300 +Message-Id: <1346491928-2356-2b-git-send-email-tomi.ollila@iki.fi> +X-Mailer: git-send-email 1.7.1 +In-Reply-To: <1346491928-2356-1-git-send-email-tomi.ollila@iki.fi> +References: <1346491928-2356-1-git-send-email-tomi.ollila@iki.fi> +In-Reply-To: <1346491928-2356-1-git-send-email-tomi.ollila@iki.fi> +References: <1346491928-2356-1-git-send-email-tomi.ollila@iki.fi> +Cc: tomi.ollila@iki.fi +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 02 Sep 2012 20:18:51 -0000 + +Use new target release-checks in place of verify-version-debian, +verify-version-python verify-version-manpage. This target executes +devel/release-checks.sh which does all the verifications the three +dropped targets did, and some more. +--- + +The only change to + + id:"1346491928-2356-2-git-send-email-tomi.ollila@iki.fi" + +is that 'exec' is removed from devel/release-checks.sh invocation. +I thought it would have saved one fork but experimentation showed +that is not the case. + + Makefile.local | 28 ++++------------------------ + man/Makefile.local | 9 +-------- + 2 files changed, 5 insertions(+), 32 deletions(-) + +diff --git a/Makefile.local b/Makefile.local +index de984ab..99f1e19 100644 +--- a/Makefile.local ++++ b/Makefile.local +@@ -187,7 +187,7 @@ release-message: + verify-source-tree-and-version: verify-no-dirty-code + + .PHONY: verify-no-dirty-code +-verify-no-dirty-code: verify-version-debian verify-version-python verify-version-manpage ++verify-no-dirty-code: release-checks + ifeq ($(IS_GIT),yes) + @printf "Checking that source tree is clean..." + ifneq ($(shell git ls-files -m),) +@@ -204,29 +204,9 @@ else + endif + endif + +-.PHONY: verify-version-debian +-verify-version-debian: verify-version-components +- @echo -n "Checking that Debian package version is $(VERSION)-1..." +- @[ "$(VERSION)-1" = $$(sed '1{ s/).*//; s/.*(//; q; }' debian/changelog) ] || \ +- (echo "No." && \ +- echo "Please edit version and debian/changelog to have consistent versions." && false) +- @echo "Good." +- +-.PHONY: verify-version-python +-verify-version-python: verify-version-components +- @echo -n "Checking that python bindings version is $(VERSION)..." +- @[ "$(VERSION)" = $$(python -c "execfile('$(PV_FILE)'); print __VERSION__") ] || \ +- (echo "No." && \ +- echo "Please edit version and $(PV_FILE) to have consistent versions." && false) +- @echo "Good." +- +-.PHONY: verify-version-components +-verify-version-components: +- @echo -n "Checking that $(VERSION) consists only of digits and periods..." +- @echo $(VERSION) | grep -q -x '^[0-9.]*$$' || \ +- (echo "No." && \ +- echo "Please follow the instructions in RELEASING to choose a version" && false) +- @echo "Good." ++.PHONY: release-checks ++release-checks: ++ devel/release-checks.sh + + .PHONY: verify-newer + verify-newer: +diff --git a/man/Makefile.local b/man/Makefile.local +index d43a949..72e2a18 100644 +--- a/man/Makefile.local ++++ b/man/Makefile.local +@@ -32,7 +32,7 @@ COMPRESSED_MAN := $(MAN1_GZ) $(MAN5_GZ) $(MAN7_GZ) + %.gz: % + gzip --stdout $^ > $@ + +-.PHONY: install-man update-man-versions verify-version-manpage ++.PHONY: install-man update-man-versions + + install-man: $(COMPRESSED_MAN) + mkdir -p "$(DESTDIR)$(mandir)/man1" +@@ -43,13 +43,6 @@ install-man: $(COMPRESSED_MAN) + install -m0644 $(MAN7_GZ) $(DESTDIR)/$(mandir)/man7 + cd $(DESTDIR)/$(mandir)/man1 && ln -sf notmuch.1.gz notmuch-setup.1.gz + +-verify-version-manpage: verify-version-components +- @echo -n "Checking that manual page version is $(VERSION)..." +- @[ "$(VERSION)" = $$(sed -n '/^[.]TH NOTMUCH 1/{s/.*"Notmuch //;s/".*//p;}' $(MAIN_PAGE)) ] || \ +- (echo "No." && \ +- echo "Please edit version and notmuch.1 to have consistent versions." && false) +- @echo "Good." +- + update-man-versions: $(MAN_SOURCE) + for file in $(MAN_SOURCE); do \ + cp $$file $$file.bak ; \ +-- +1.7.1 +