From: David Edmondson Date: Mon, 30 Jan 2012 16:52:20 +0000 (+0000) Subject: [PATCH] emacs: Move the blank line from the bottom of the headers to the top of the... X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=25f92af1d4829c231cdf953e839ab2dbde1df7eb;p=notmuch-archives.git [PATCH] emacs: Move the blank line from the bottom of the headers to the top of the body. --- diff --git a/00/098607ba42257636ed6991b05a81a4b2ec055b b/00/098607ba42257636ed6991b05a81a4b2ec055b new file mode 100644 index 000000000..7c6346ae1 --- /dev/null +++ b/00/098607ba42257636ed6991b05a81a4b2ec055b @@ -0,0 +1,92 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id AB663431FBC + for ; Mon, 30 Jan 2012 08:52:28 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id I+IAEY+H-VlA for ; + Mon, 30 Jan 2012 08:52:28 -0800 (PST) +Received: from mail-ww0-f45.google.com (mail-ww0-f45.google.com + [74.125.82.45]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client + certificate requested) by olra.theworths.org (Postfix) with ESMTPS id + 07EB0431E64 for ; Mon, 30 Jan 2012 08:52:27 -0800 + (PST) +Received: by wgbdt12 with SMTP id dt12so4222950wgb.2 + for ; Mon, 30 Jan 2012 08:52:26 -0800 (PST) +Received: by 10.180.85.105 with SMTP id g9mr10128208wiz.12.1327942346821; + Mon, 30 Jan 2012 08:52:26 -0800 (PST) +Received: from hotblack-desiato.hh.sledj.net + (host81-149-164-25.in-addr.btopenworld.com. [81.149.164.25]) + by mx.google.com with ESMTPS id eq5sm54211690wib.2.2012.01.30.08.52.25 + (version=TLSv1/SSLv3 cipher=OTHER); + Mon, 30 Jan 2012 08:52:25 -0800 (PST) +Received: by hotblack-desiato.hh.sledj.net (Postfix, from userid 30000) + id B7C029FDD7; Mon, 30 Jan 2012 16:52:23 +0000 (GMT) +From: David Edmondson +To: notmuch@notmuchmail.org +Subject: [PATCH] emacs: Move the blank line from the bottom of the headers to + the top of the body. +Date: Mon, 30 Jan 2012 16:52:20 +0000 +Message-Id: <1327942340-23340-1-git-send-email-dme@dme.org> +X-Mailer: git-send-email 1.7.8.3 +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 30 Jan 2012 16:52:28 -0000 + +The blank line doesn't really change position, but is now considered +to be part of the body rather than part of the headers. This means +that it is visible when the body is visible rather than when the +headers are visible. +--- + +I'm interested in getting feedback on this. + +Unless you run with `notmuch-message-headers-visible' set to `nil' or +regularly toggle header visibility, you probably don't care. + + emacs/notmuch-show.el | 4 ++-- + 1 files changed, 2 insertions(+), 2 deletions(-) + +diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el +index 84ac624..73f73d4 100644 +--- a/emacs/notmuch-show.el ++++ b/emacs/notmuch-show.el +@@ -854,8 +854,6 @@ current buffer, if possible." + ;; compatible with the existing implementation. This just sets it + ;; to after the first header. + (notmuch-show-insert-headers headers) +- ;; Headers should include a blank line (backwards compatibility). +- (insert "\n") + (save-excursion + (goto-char content-start) + ;; If the subject of this message is the same as that of the +@@ -870,6 +868,8 @@ current buffer, if possible." + (setq notmuch-show-previous-subject bare-subject) + + (setq body-start (point-marker)) ++ ;; A blank line between the headers and the body. ++ (insert "\n") + (notmuch-show-insert-body msg (plist-get msg :body) depth) + ;; Ensure that the body ends with a newline. + (unless (bolp) +-- +1.7.8.3 +