From: Jameson Graef Rollins Date: Fri, 7 Dec 2012 08:24:36 +0000 (+1600) Subject: Re: [PATCH v4 3/5] Use the S-Expression structured printer in notmuch-show, notmuch... X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=24d93006b0eed94a4b537c27f0309c00c15473e1;p=notmuch-archives.git Re: [PATCH v4 3/5] Use the S-Expression structured printer in notmuch-show, notmuch-reply and notmuch-search. --- diff --git a/14/d09166cb14c5681b5a2b8634849a4e2af3b1d9 b/14/d09166cb14c5681b5a2b8634849a4e2af3b1d9 new file mode 100644 index 000000000..a944f6e5f --- /dev/null +++ b/14/d09166cb14c5681b5a2b8634849a4e2af3b1d9 @@ -0,0 +1,109 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 2DB39431FBC + for ; Fri, 7 Dec 2012 00:24:46 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -2.3 +X-Spam-Level: +X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id VkR12Rk6XPXX for ; + Fri, 7 Dec 2012 00:24:44 -0800 (PST) +Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu + [131.215.239.19]) + by olra.theworths.org (Postfix) with ESMTP id 2556C431FB6 + for ; Fri, 7 Dec 2012 00:24:44 -0800 (PST) +Received: from fire-doxen.imss.caltech.edu (localhost [127.0.0.1]) + by fire-doxen-postvirus (Postfix) with ESMTP id 86A192E508C7; + Fri, 7 Dec 2012 00:24:41 -0800 (PST) +X-Spam-Scanned: at Caltech-IMSS on fire-doxen by amavisd-new +Received: from finestructure.net (cpe-76-166-145-133.socal.res.rr.com + [76.166.145.133]) (Authenticated sender: jrollins) + by fire-doxen-submit (Postfix) with ESMTP id AA5812E50677; + Fri, 7 Dec 2012 00:24:37 -0800 (PST) +Received: by finestructure.net (Postfix, from userid 1000) + id 29754616EF; Fri, 7 Dec 2012 00:24:37 -0800 (PST) +From: Jameson Graef Rollins +To: Mark Walters , Peter Feigl , + notmuch@notmuchmail.org +Subject: Re: [PATCH v4 3/5] Use the S-Expression structured printer in + notmuch-show, notmuch-reply and notmuch-search. +In-Reply-To: <87txry5m08.fsf@qmul.ac.uk> +References: + <9cb474a271c471f8bae8b55b0148bb970ba78ceb.1354794428.git.craven@gmx.net> + <871uf2in54.fsf@servo.finestructure.net> + <87txry5m08.fsf@qmul.ac.uk> +User-Agent: Notmuch/0.14+143~g175686e (http://notmuchmail.org) Emacs/24.2.1 + (x86_64-pc-linux-gnu) +Date: Fri, 07 Dec 2012 00:24:36 -0800 +Message-ID: <87mwxqgth7.fsf@servo.finestructure.net> +MIME-Version: 1.0 +Content-Type: multipart/signed; boundary="=-=-="; + micalg=pgp-sha256; protocol="application/pgp-signature" +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Fri, 07 Dec 2012 08:24:46 -0000 + +--=-=-= +Content-Type: text/plain + +On Fri, Dec 07 2012, Mark Walters wrote: +> Jameson Graef Rollins writes: +> +>> On Thu, Dec 06 2012, Peter Feigl wrote: +>>> - /* Any changes to the JSON format should be reflected in the file +>>> - * devel/schemata. */ +>>> + /* Any changes to the JSON or S-Expression format should be +>>> + * reflected in the file devel/schemata. */ +>> +>> Can we just make these comments more general, so we don't have to tweak +>> them every time a new formatter is added? +> +> I think I agree, but I think it may as well wait until we have more than +> the two formats. In other words I would suggest not holding up the +> (latest version) of this series for this. + +Yes, that's totally fair. I didn't notice later that a new version of +the patch had already been sent. + +I haven't had a chance to review the patches, but I am certainly all for +the feature. Definitely don't hold it up on this account. + +jamie. + +--=-=-= +Content-Type: application/pgp-signature + +-----BEGIN PGP SIGNATURE----- +Version: GnuPG v1.4.12 (GNU/Linux) + +iQIcBAEBCAAGBQJQwafEAAoJEO00zqvie6q87O8P/A80+dLNpZ3M9nDNl9aV1TZW +XV6m8wWrDi2pz8FHaZQ4en0Y0dwJ/t2rCCMN2bPEieLZrgm+ktd3LU7jY/pkYBip +Q1DJsHw41HiPTz9O0bSremCa2U+GzJ5iXyP/euHnRcm6Q4cppqJDQ8btDWA9zc7Z +zg7g24/pXS9DSxwMbFcGnU/aMJWYwr8JtOWEFBaHANeTqd5WdE9uzG6N9q3tSrcI +nUqRjqLjI7SVy0u/Rw32j0LsGg8UNIO8zvVuBwHU+dO3AdQI2OUzJVyaP2NFoGXd +tV40Qzn3/XQkS6OkIkkwGeJb5UrhpvrrSjaSdfqfj1lAjyYL/vxg4viX/LGR16KP +YvN9NldyvKUzgJHfAuO5Lv0FWyWiPiI3ZGoL3xLmHH4A+O/1Ap9HUSfAcVy7/xRJ +Yq+JMagdfg0g/whVteEFtTswxbRBWKB7KWQV7k5gNfKQiTPttkNqvZB1odrRu97H +s2FqyBhE3y9pOmqqRDcE6KiPfHQLx3KHmkYajqOFHD0u6A0Sr8v+PD/kUfOGFNXz +SSPwNwtR2jbm7CLLRhg0Pxdto8v4GxJkG6sLTdc1hk0Du9JBzw6XEBgv31syRJe9 +kfQBoGbye2ESQ+kfAveXiiD6Jw4kjUFu8W1KaLhdE8rjUeTNPfzVqbcNAnQn4cU0 +jcf436O/Ljlhm4NlYutJ +=YxVI +-----END PGP SIGNATURE----- +--=-=-=--