From: Austin Clements Date: Thu, 26 Jan 2012 19:41:46 +0000 (+1900) Subject: Re: [PATCH] emacs: add default value to notmuch-search-line-faces X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=22b90afff7f892a9a0a9f8247cd7b5cf8dba0c8d;p=notmuch-archives.git Re: [PATCH] emacs: add default value to notmuch-search-line-faces --- diff --git a/ca/20fb02827c99f406aba39a31dd95b2b8ac4272 b/ca/20fb02827c99f406aba39a31dd95b2b8ac4272 new file mode 100644 index 000000000..ba1793083 --- /dev/null +++ b/ca/20fb02827c99f406aba39a31dd95b2b8ac4272 @@ -0,0 +1,129 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 40480431FBC + for ; Thu, 26 Jan 2012 11:42:27 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id Qd+WE92wFZWq for ; + Thu, 26 Jan 2012 11:42:26 -0800 (PST) +Received: from dmz-mailsec-scanner-7.mit.edu (DMZ-MAILSEC-SCANNER-7.MIT.EDU + [18.7.68.36]) + by olra.theworths.org (Postfix) with ESMTP id 7C786431FAF + for ; Thu, 26 Jan 2012 11:42:26 -0800 (PST) +X-AuditID: 12074424-b7fae6d000000906-d9-4f21aca17ab9 +Received: from mailhub-auth-3.mit.edu ( [18.9.21.43]) + by dmz-mailsec-scanner-7.mit.edu (Symantec Messaging Gateway) with SMTP + id BD.88.02310.1ACA12F4; Thu, 26 Jan 2012 14:42:25 -0500 (EST) +Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) + by mailhub-auth-3.mit.edu (8.13.8/8.9.2) with ESMTP id q0QJgP50013533; + Thu, 26 Jan 2012 14:42:25 -0500 +Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) + (authenticated bits=0) + (User authenticated as amdragon@ATHENA.MIT.EDU) + by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q0QJgOvR004440 + (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); + Thu, 26 Jan 2012 14:42:25 -0500 (EST) +Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77) + (envelope-from ) + id 1RqVCc-0002Md-2M; Thu, 26 Jan 2012 14:41:46 -0500 +Date: Thu, 26 Jan 2012 14:41:46 -0500 +From: Austin Clements +To: Jani Nikula +Subject: Re: [PATCH] emacs: add default value to notmuch-search-line-faces +Message-ID: <20120126194146.GG1940@mit.edu> +References: <1327605679-15213-1-git-send-email-jani@nikula.org> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +Content-Disposition: inline +In-Reply-To: <1327605679-15213-1-git-send-email-jani@nikula.org> +User-Agent: Mutt/1.5.21 (2010-09-15) +X-Brightmail-Tracker: + H4sIAAAAAAAAA+NgFmpkleLIzCtJLcpLzFFi42IR4hTV1l24RtHf4Ph6C4um6c4W12/OZHZg + 8rh1/zW7x7NVt5gDmKK4bFJSczLLUov07RK4Mi4uvsResFKoYt0HqwbG63xdjJwcEgImEgvm + 7WSHsMUkLtxbz9bFyMUhJLCPUWLfz3XsEM4GRok9N/9AOSeZJB7132QBaRESWMIocfR4FYjN + IqAq0Xb1LdgoNgENiW37lzOC2CICihKbT+4Hs5kFpCW+/W5mArGFBbwkfp74CTaHV0BbYuu0 + +0wQM+0lWk/3sEHEBSVOznzCAtGrJXHj30ugGg6wOcv/cYCEOQUcJM4/+c8KYosKqEhMObmN + bQKj0Cwk3bOQdM9C6F7AyLyKUTYlt0o3NzEzpzg1Wbc4OTEvL7VI11wvN7NELzWldBMjKKTZ + XVR2MDYfUjrEKMDBqMTD6zlJ0V+INbGsuDL3EKMkB5OSKO+nlUAhvqT8lMqMxOKM+KLSnNTi + Q4wSHMxKIrx3vIByvCmJlVWpRfkwKWkOFiVxXg2td35CAumJJanZqakFqUUwWRkODiUJ3ler + gRoFi1LTUyvSMnNKENJMHJwgw3mAhj8GqeEtLkjMLc5Mh8ifYlSUEuf9BZIQAElklObB9cJS + zitGcaBXhHlfglTxANMVXPcroMFMQIOX6sqDDC5JREhJNTAmfChZbS/m53B54arY2rdfefWz + zwi8klArS2mevHLNzd+H+q3cjh7k0Pl9uO6btuu+9cu5o7lZ5gQo/4oSEo07qfh8Y4dhadSq + mGkTXxnurCv1Z8jyr85xzmfu9FSd4lNy8+z1ycueqUwINmhfI6EyKc+bx/PRh7q2LZ8YZKXZ + a53OKDAqCyqxFGckGmoxFxUnAgD3c5ipFAMAAA== +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 26 Jan 2012 19:42:27 -0000 + +Quoth Jani Nikula on Jan 26 at 9:21 pm: +> Add default value to notmuch-search-line-faces to show "unread" +> messages in bold, and "flagged" messages in red, to have some visual +> indication of important messages in search results. This should be +> helpful for new users. +> +> "unread" tag is quite obvious, and handled specially both in the lib +> and emacs ui. "flagged" is synced to maildir F flag in the lib. If one +> syncs the maildir to IMAP, this also translates to corresponding IMAP +> flag. (This is "starred" in GMail and Android.) +> +> Signed-off-by: Jani Nikula + +While I'm sure this can be bikeshod to death, I do have one legitimate +concern (and one illegitimate). + +I completely agree with what you said on IRC, though, that setting +this to non-nil is more about making this capability more discoverable +to new users than trying to come up with the perfect faces. + +> --- +> emacs/notmuch.el | 3 ++- +> 1 files changed, 2 insertions(+), 1 deletions(-) +> +> diff --git a/emacs/notmuch.el b/emacs/notmuch.el +> index 6b2c252..551ea9d 100644 +> --- a/emacs/notmuch.el +> +++ b/emacs/notmuch.el +> @@ -662,7 +662,8 @@ This function advances the next thread when finished." +> (goto-char (point-min)) +> (forward-line (1- notmuch-search-target-line)))))))) +> +> -(defcustom notmuch-search-line-faces nil +> +(defcustom notmuch-search-line-faces '(("unread" :weight bold) + +As much as I would like this, many terminals don't visually +distinguish between the default face and the default face in bold. + +> + ("flagged" :foreground "red")) + +Red is pretty universally used to indicate danger or a serious +condition, while "flagged" is simply supposed to draw attention. I +would say blue as a neutral and distinct indicator, but it also has +poor visibility (I used to use blue, but found that when scanning my +mail, I would habitually skip over flagged messages because they were +dark, which was the opposite of what I wanted). Personally I've +settled on yellow; it's visually distinct enough to be easily +noticeable and bright enough that I don't skip over it, though it +obviously wouldn't work on a light background. + +> "Tag/face mapping for line highlighting in notmuch-search. +> +> Here is an example of how to color search results based on tags.