From: Damien Cassou Date: Fri, 30 Nov 2012 16:13:05 +0000 (+0100) Subject: Re: [PATCH 3/4] emacs: Make tags that appear in `notmuch-show' clickable X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=22058b2b6e85136e58ab1571a83437461ef567af;p=notmuch-archives.git Re: [PATCH 3/4] emacs: Make tags that appear in `notmuch-show' clickable --- diff --git a/2c/47dca6aa6a189722725ec5de272b5b3cf62639 b/2c/47dca6aa6a189722725ec5de272b5b3cf62639 new file mode 100644 index 000000000..17996dec1 --- /dev/null +++ b/2c/47dca6aa6a189722725ec5de272b5b3cf62639 @@ -0,0 +1,123 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 31A1D431FAF + for ; Fri, 30 Nov 2012 08:13:33 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.798 +X-Spam-Level: +X-Spam-Status: No, score=-0.798 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id aCQ9OQTtaW9Z for ; + Fri, 30 Nov 2012 08:13:29 -0800 (PST) +Received: from mail-lb0-f181.google.com (mail-lb0-f181.google.com + [209.85.217.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id B9CEE431FAE + for ; Fri, 30 Nov 2012 08:13:28 -0800 (PST) +Received: by mail-lb0-f181.google.com with SMTP id ge1so643023lbb.26 + for ; Fri, 30 Nov 2012 08:13:25 -0800 (PST) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; + h=mime-version:in-reply-to:references:from:date:message-id:subject:to + :cc:content-type; + bh=pafzpvocoNrw9Xu5NFsWhVk6qJGDicDagey60JXJBtw=; + b=OcL95nBCEzHiJxqNmBCinkjqm3/hzLOXfeN2ld5DgqtOm5xEohndQZAK3Wxbf0SltY + xMIjSweSDHqTeP/a2xAo6Rtou50MMAk0PuleQjUhveXBkEroy2V4m7SUoFxlfXX2je/U + JIqQ0PdrOsMazdHlusP89wwth12DU1DMPALCItCnHqSYYXvsaR9gJSNSMsm+AtkyNTAN + 2ViOugopF8ZycDGqiaRuG3v7LuzfpGEaGdqDFaeFcPdxHPZLL0pPbjqjIr9xvKCcldew + nIoTlvAcEbKKo3YP/AqoUYQEbDIwdg5mKN9gELm4aeE0JEgrZdLzGLt3VAhCVLaR8i7S + 4ZTQ== +Received: by 10.112.44.135 with SMTP id e7mr1055900lbm.55.1354292005557; Fri, + 30 Nov 2012 08:13:25 -0800 (PST) +MIME-Version: 1.0 +Received: by 10.112.7.193 with HTTP; Fri, 30 Nov 2012 08:13:05 -0800 (PST) +In-Reply-To: <20121120053216.GG22284@mit.edu> +References: <1353266322-20318-1-git-send-email-damien.cassou@gmail.com> + <1353266322-20318-4-git-send-email-damien.cassou@gmail.com> + <20121120053216.GG22284@mit.edu> +From: Damien Cassou +Date: Fri, 30 Nov 2012 17:13:05 +0100 +Message-ID: + +Subject: Re: [PATCH 3/4] emacs: Make tags that appear in `notmuch-show' + clickable +To: Austin Clements +Content-Type: multipart/alternative; boundary=bcaec554d2c0e9d66404cfb8adb7 +Cc: notmuch mailing list +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Fri, 30 Nov 2012 16:13:33 -0000 + +--bcaec554d2c0e9d66404cfb8adb7 +Content-Type: text/plain; charset=ISO-8859-1 + + On Tue, Nov 20, 2012 at 6:32 AM, Austin Clements wrote: + +> Though is this really the right interface? Is it useful to return a +> mode-line-format template from this, given that it can't be used in +> the mode-line or header-line since the buttons won't work? Should +> this just return a string that can be inserted into a buffer? +> Something like (untested), +> + +I agree, it might look strange. Nevertheless, I want to keep consistency +between header-line and body. That's not important at all now, but in the +next series of patches I will add the possibility to replace tags by +pictures and consistency will help I think. + +-- +Damien Cassou +http://damiencassou.seasidehosting.st + +"Success is the ability to go from one failure to another without losing +enthusiasm." +Winston Churchill + +--bcaec554d2c0e9d66404cfb8adb7 +Content-Type: text/html; charset=ISO-8859-1 +Content-Transfer-Encoding: quoted-printable + +
+On Tue, Nov 20, 2012 at 6:32 AM, Austin Clements <amdragon@mit.edu><= +/span> wrote:
+ + + +
Though is this really the right interface? =A0Is it useful to return a= +
+mode-line-format template from this, given that it can't be used in
+the mode-line or header-line since the buttons won't work? =A0Should +this just return a string that can be inserted into a buffer?
+Something like (untested),

I agree, it might lo= +ok strange. Nevertheless, I want to keep consistency between header-line an= +d body. That's not important at all now, but in the next series of patc= +hes I will add the possibility to replace tags by pictures and consistency = +will help I think.
+ +
--
Damien Cassou
http://damiencassou.seasidehosting.st
+ +
"Success is the ability to go from one failure to another without = +losing enthusiasm."
Winston Churchill
+
+ +--bcaec554d2c0e9d66404cfb8adb7--