From: Austin Clements Date: Sat, 14 Jul 2012 03:28:03 +0000 (+2000) Subject: Re: [PATCH 0/7] emacs: JSON-based search cleanups X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=20eb7c9dcc7436d0d8ebf8254921056130fbfa01;p=notmuch-archives.git Re: [PATCH 0/7] emacs: JSON-based search cleanups --- diff --git a/2c/7ed83967855fb5474122f6a1e4b1c6f3bb8be1 b/2c/7ed83967855fb5474122f6a1e4b1c6f3bb8be1 new file mode 100644 index 000000000..0d64d11bb --- /dev/null +++ b/2c/7ed83967855fb5474122f6a1e4b1c6f3bb8be1 @@ -0,0 +1,107 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id C100B431FC3 + for ; Fri, 13 Jul 2012 20:28:10 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id K0GMJRT2ieHY for ; + Fri, 13 Jul 2012 20:28:08 -0700 (PDT) +Received: from dmz-mailsec-scanner-8.mit.edu (DMZ-MAILSEC-SCANNER-8.MIT.EDU + [18.7.68.37]) + by olra.theworths.org (Postfix) with ESMTP id 71913431FAE + for ; Fri, 13 Jul 2012 20:28:08 -0700 (PDT) +X-AuditID: 12074425-b7f9b6d0000008c4-c8-5000e7455cbb +Received: from mailhub-auth-4.mit.edu ( [18.7.62.39]) + by dmz-mailsec-scanner-8.mit.edu (Symantec Messaging Gateway) with SMTP + id 59.6D.02244.547E0005; Fri, 13 Jul 2012 23:28:05 -0400 (EDT) +Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) + by mailhub-auth-4.mit.edu (8.13.8/8.9.2) with ESMTP id q6E3S4ux025389; + Fri, 13 Jul 2012 23:28:05 -0400 +Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) + (authenticated bits=0) + (User authenticated as amdragon@ATHENA.MIT.EDU) + by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q6E3S3m3018347 + (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); + Fri, 13 Jul 2012 23:28:04 -0400 (EDT) +Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77) + (envelope-from ) + id 1Spt1X-0000rp-3K; Fri, 13 Jul 2012 23:28:03 -0400 +Date: Fri, 13 Jul 2012 23:28:03 -0400 +From: Austin Clements +To: Mark Walters +Subject: Re: [PATCH 0/7] emacs: JSON-based search cleanups +Message-ID: <20120714032744.GE31670@mit.edu> +References: <1342140319-19859-1-git-send-email-amdragon@mit.edu> + <871ukf8r8q.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +Content-Disposition: inline +In-Reply-To: <871ukf8r8q.fsf@qmul.ac.uk> +User-Agent: Mutt/1.5.21 (2010-09-15) +X-Brightmail-Tracker: + H4sIAAAAAAAAA+NgFmpgleLIzCtJLcpLzFFi42IRYrdT13V9zhBgcHazssXquTwW12/OZHZg + 8tg56y67x7NVt5gDmKK4bFJSczLLUov07RK4Mk6uSC14zFVxqOsuWwPjQY4uRg4OCQETid7Z + nl2MnECmmMSFe+vZuhi5OIQE9jFKbPzfwQySEBLYwCjxfhIjROIkk0Tb6zYoZwmjxL/Tu9lB + qlgEVCUW7GtiBbHZBDQktu1fzghiiwjoSNw+tACshllAWuLb72YmEFtYwEpi9dV9LCA2L1DN + mrd72CC2xUksubUeKi4ocXLmExaIXi2JG/9eMoFcDTJn+T8OkDAn0KoZh4+ArRUVUJGYcnIb + 2wRGoVlIumch6Z6F0L2AkXkVo2xKbpVubmJmTnFqsm5xcmJeXmqRroVebmaJXmpK6SZGcEC7 + qO5gnHBI6RCjAAejEg9voj9DgBBrYllxZe4hRkkOJiVRXobHQCG+pPyUyozE4oz4otKc1OJD + jBIczEoivOZtQDnelMTKqtSifJiUNAeLkjjvjZSb/kIC6YklqdmpqQWpRTBZGQ4OJQlesWdA + jYJFqempFWmZOSUIaSYOTpDhPEDDI0FqeIsLEnOLM9Mh8qcYFaXEeQtAEgIgiYzSPLheWMJ5 + xSgO9IowbxVIFQ8wWcF1vwIazAQ0eNbPf/5Ag0sSEVJSDYwHtLwyUk68nbVlaYts3J8DD2Z2 + nah5s/ZQsbtxmPUE03UxP6/dMV/W7CT8z71ubZgdy9Pai+1Xbr/Yvkp36yyVjLzlR8uXX/to + dqYrUb7vd2l9/Mv6A7XtDHP2q3/9wxrOFOa64NS9KucVYtZykiLuUdIm0cez46XtHmWqFIfu + zSvVS7lsaKvEUpyRaKjFXFScCACUtiEUEwMAAA== +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 14 Jul 2012 03:28:10 -0000 + +Quoth Mark Walters on Jul 13 at 7:12 pm: +> On Fri, 13 Jul 2012, Austin Clements wrote: +> > This series builds on the JSON-based search series [0] to clean up +> > several other aspects of search-mode. It removes constraints on the +> > formatting of tags in the result line (you can even leave them out +> > entirely), it recolors lines when tags change, it adds supports for +> > multi-line result formats, and rendering big search buffers should be +> > less quadratic (it might even be linear). Much of this derives from +> > having a single object representation of a result (the JSON plist) and +> > a simple method for rendering it to the buffer. +> +> Overall this series looks excellent. I have reviewed all the patches +> except patch 4/7 (I will need to work out how macros work to review +> that) and they seem fine modulo the small comments I have made. +> +> One final comment: I couldn't persuade the defcustom search result to +> take a newline symbol to test multiline results. It seems to escape +> entries of \n, and I couldn't enter returns (and ^Q return didn't work +> either). + +C-q C-j worked for me. Not the most obvious, certainly. + +> It was easy by editing the option in my .emacs file and then seemed to +> work as expected. +> +> Best wishes +> +> Mark +> > +> > [0] 1341870162-17782-1-git-send-email-amdragon@mit.edu