From: Mark Walters Date: Tue, 24 Jul 2012 21:21:46 +0000 (+0100) Subject: [PATCH 0/5] Notmuch Pick (WIP or contrib) X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=204697679b57079c57a07cb3ed94e3ebcda4caca;p=notmuch-archives.git [PATCH 0/5] Notmuch Pick (WIP or contrib) --- diff --git a/21/3d7e96f61247281ed9b5f156a299353ec00fc6 b/21/3d7e96f61247281ed9b5f156a299353ec00fc6 new file mode 100644 index 000000000..edb662fb7 --- /dev/null +++ b/21/3d7e96f61247281ed9b5f156a299353ec00fc6 @@ -0,0 +1,130 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id A8D90431FBD + for ; Tue, 24 Jul 2012 14:22:01 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0.201 +X-Spam-Level: +X-Spam-Status: No, score=0.201 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + FREEMAIL_ENVFROM_END_DIGIT=1, FREEMAIL_FROM=0.001, + RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id jqrJayGnEOnH for ; + Tue, 24 Jul 2012 14:22:00 -0700 (PDT) +Received: from mail-wi0-f179.google.com (mail-wi0-f179.google.com + [209.85.212.179]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 05398431FAE + for ; Tue, 24 Jul 2012 14:21:59 -0700 (PDT) +Received: by wibhq4 with SMTP id hq4so19767wib.2 + for ; Tue, 24 Jul 2012 14:21:57 -0700 (PDT) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; + h=from:to:cc:subject:date:message-id:x-mailer; + bh=WAFUpB9YvOi7OpO6sYx/BbK0fkrv6kYgehlyG+nwj80=; + b=PvNkWIc+afyn1RIcGuRJuTyHbn8I93XvQYpLT4DvxC7EfOfZ5Cb23Trm1NNfETSajh + y/dYEsXBDd88Y9C7r567kbyYeBdjxHvZRoCnA/GhWvHIapb6bxe3v6INCfX+aViLhWJR + BvyK5BvZyzIM/f0VF+Bx2drTLT7d8eZEdZ8moNu4EOH+DEahg6aX/B9azMdiwgoIGW/V + NFN4Vj4eOBiL3CczlE6m400zyA1tMmAZr0PnHjW71MLYz55ge3vxnuQXuskiAjlTbk7e + dc4f6iYC5nOCHVW5ebjWD3HiZUVcuzYwq37Gjx8ZKfc9BvL4TG+c0mDNwG6a0caTUdDD + L2VA== +Received: by 10.180.81.38 with SMTP id w6mr8186380wix.10.1343164917302; + Tue, 24 Jul 2012 14:21:57 -0700 (PDT) +Received: from localhost (94-192-233-223.zone6.bethere.co.uk. + [94.192.233.223]) by mx.google.com with ESMTPS id + w7sm6295048wiz.0.2012.07.24.14.21.55 (version=TLSv1/SSLv3 cipher=OTHER); Tue, + 24 Jul 2012 14:21:56 -0700 (PDT) +From: Mark Walters +To: notmuch@notmuchmail.org +Subject: [PATCH 0/5] Notmuch Pick (WIP or contrib) +Date: Tue, 24 Jul 2012 22:21:46 +0100 +Message-Id: <1343164911-31589-1-git-send-email-markwalters1009@gmail.com> +X-Mailer: git-send-email 1.7.9.1 +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 24 Jul 2012 21:22:01 -0000 + +Hello + +Notmuch pick is an emacs view which displays a threaded view of +messages: each message has its own line and the thread structure is +shown with UTF-8 graphics characters (so it looks vaguely similar to +mutt's threaded view): see http://kanelephant.com/screen.png for a screenshot. + +Pick was originally written by David Edmondon and posted on irc and I +have been developing it on and off since. Now that almost all the +backend changes it uses are in I would like to see about getting it +into mainline. + +The code is not of the same standard as mainline code: in particular a +lot of the code is written by me and is working but unidiomatic +lisp. It has also not had widespread testing so I would expect it to +have several bugs. + +We could try getting it into mainline using the normal review type +approach, but the patch is necessarily large (it implements a new view +similar in size to show or search) with the main pick.el file being +nearly 900 lines. + +An alternative approach would be to accept it into contrib and then +reviewers/users could submit fixes for the problems directly. + +This patch series implements the latter approach, but I am definitely +happy to try for the former or some other approach. + +In its current form the user needs to copy (or link) the +notmuch-pick.el from contrib into the emacs directory and then build +notmuch as usual. There are two very small patches to "mainline" code: +one to compile and load the pick file if present and one small tweak +to notmuch-show.el. Then in contrib/notmuch-pick there are three +files: the notmuch-pick.el file itself, a README describing +documenting install and use, and a TODO which contains the main things +I think need doing (and I will try to update this in light of comments +received). + +Any comments on the code or the correct approach, patches etc +gratefully received! + +Best wishes + +Mark + +PS If it is in contrib then I am happy to maintain it (with the aim of +an eventual move to mainline). + + +Mark Walters (5): + emacs: compile and load notmuch-pick.el if present. + emacs: make notmuch-show return its buffer + contrib: add notmuch-pick.el file itself + contrib: Added pick README. + contrib: add pick TODO file + + contrib/notmuch-pick/README | 36 ++ + contrib/notmuch-pick/TODO | 25 + + contrib/notmuch-pick/notmuch-pick.el | 876 ++++++++++++++++++++++++++++++++++ + emacs/Makefile.local | 3 +- + emacs/notmuch-show.el | 3 +- + emacs/notmuch.el | 5 + + 6 files changed, 946 insertions(+), 2 deletions(-) + create mode 100644 contrib/notmuch-pick/README + create mode 100644 contrib/notmuch-pick/TODO + create mode 100644 contrib/notmuch-pick/notmuch-pick.el + +-- +1.7.9.1 +