From: Austin Clements Date: Wed, 25 Apr 2012 13:39:30 +0000 (+2000) Subject: Re: [PATCH 6/7] ruby: Use notmuch_database_destroy instead of notmuch_database_close X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=1e744fce27bffbd7ea3fa14b2c278b10e4424cde;p=notmuch-archives.git Re: [PATCH 6/7] ruby: Use notmuch_database_destroy instead of notmuch_database_close --- diff --git a/40/8abef608e06521aeb533005d99b35c426cd414 b/40/8abef608e06521aeb533005d99b35c426cd414 new file mode 100644 index 000000000..54159986b --- /dev/null +++ b/40/8abef608e06521aeb533005d99b35c426cd414 @@ -0,0 +1,103 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id ECA5F431FB6 + for ; Wed, 25 Apr 2012 06:39:34 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id lIVRXqNIArZ7 for ; + Wed, 25 Apr 2012 06:39:34 -0700 (PDT) +Received: from dmz-mailsec-scanner-4.mit.edu (DMZ-MAILSEC-SCANNER-4.MIT.EDU + [18.9.25.15]) + by olra.theworths.org (Postfix) with ESMTP id 59F9E431FAF + for ; Wed, 25 Apr 2012 06:39:34 -0700 (PDT) +X-AuditID: 1209190f-b7f8a6d000000914-d2-4f97fe95d406 +Received: from mailhub-auth-1.mit.edu ( [18.9.21.35]) + by dmz-mailsec-scanner-4.mit.edu (Symantec Messaging Gateway) with SMTP + id EC.0F.02324.59EF79F4; Wed, 25 Apr 2012 09:39:33 -0400 (EDT) +Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) + by mailhub-auth-1.mit.edu (8.13.8/8.9.2) with ESMTP id q3PDdWej024970; + Wed, 25 Apr 2012 09:39:32 -0400 +Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) + (authenticated bits=0) + (User authenticated as amdragon@ATHENA.MIT.EDU) + by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q3PDdU1F009304 + (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); + Wed, 25 Apr 2012 09:39:31 -0400 (EDT) +Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77) + (envelope-from ) + id 1SN2RO-0001gp-Nr; Wed, 25 Apr 2012 09:39:30 -0400 +From: Austin Clements +To: Justus Winter <4winter@informatik.uni-hamburg.de>, + Felipe Contreras +Subject: Re: [PATCH 6/7] ruby: Use notmuch_database_destroy instead of + notmuch_database_close +In-Reply-To: <20120423124946.31231.53523@thinkbox.jade-hamburg.de> +References: <20120422120620.26225.40778@thinkbox.jade-hamburg.de> + <1335096477-27537-1-git-send-email-4winter@informatik.uni-hamburg.de> + <1335096477-27537-6-git-send-email-4winter@informatik.uni-hamburg.de> + + <20120423124946.31231.53523@thinkbox.jade-hamburg.de> +User-Agent: Notmuch/0.12+132~gf2f390b (http://notmuchmail.org) Emacs/23.3.1 + (i486-pc-linux-gnu) +Date: Wed, 25 Apr 2012 09:39:30 -0400 +Message-ID: <87obqggcbx.fsf@awakening.csail.mit.edu> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Brightmail-Tracker: + H4sIAAAAAAAAA+NgFvrOIsWRmVeSWpSXmKPExsUixCmqrDv133R/gxcrLSxmt/5gsjj4OM/i + +s2ZzA7MHjtn3WX3mHj+NJvHs1W3mAOYo7hsUlJzMstSi/TtErgyFr45wF7wir1i35X3zA2M + i9m6GDk5JARMJCbc/cYCYYtJXLi3HiwuJLCPUWLvxKIuRi4gewOjxMvWL2wQzkkmiSUrvrJC + OEsYJT4tXwXWwiagIbFt/3JGEFtEIFfi6eRWJhCbWUBa4tvvZjBbWCBW4v/lC8wgNqeAk8SO + 9+9YIAadYJKY+W0WWLOoQLzEn97NYENZBFQlOu82gjXzAt365Go/I4QtKHFy5hMWiAVaEjf+ + vWSawCg4C0lqFpLUAkamVYyyKblVurmJmTnFqcm6xcmJeXmpRbomermZJXqpKaWbGMHhK8m/ + g/HbQaVDjAIcjEo8vLP3TvMXYk0sK67MPcQoycGkJMp7+Nd0fyG+pPyUyozE4oz4otKc1OJD + jBIczEoivC9eAuV4UxIrq1KL8mFS0hwsSuK8alrv/IQE0hNLUrNTUwtSi2CyMhwcShK8V/8C + NQoWpaanVqRl5pQgpJk4OEGG8wAN/whSw1tckJhbnJkOkT/FqCglzrsJJCEAksgozYPrhaWX + V4ziQK8I8+4BqeIBpia47ldAg5mABn8LmgYyuCQRISXVwBhy9IuALcOHRcmB124sfD3RksPQ + Ocl1y5wM8cyXR4onJV5Wiz9/ykHT9aFQYK6D/ZMLbcz7l1hVqanb2Nb9vs/7+WqI3JZv17nT + 9RO7nG/lJ36uFsv+UMifX3qU/V2YxBrNhT6MO3qsU0vSFCYHhJk56rYVffJ7PJ3nmlWI1KFF + p9209h4JVWIpzkg01GIuKk4EAO904YcKAwAA +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 25 Apr 2012 13:39:35 -0000 + +On Mon, 23 Apr 2012, Justus Winter <4winter@informatik.uni-hamburg.de> wrote: +> Quoting Felipe Contreras (2012-04-23 14:36:33) +>> I don't think this is the right approach. If database_destroy truly +>> destroys the object, then we would want to do it only at garbage +>> collection, when it's not accessible any more. What if I want to +>> re-use the database from the Ruby code? +>> +>> This would probably be better: +>> +>>[...] +> +> You're probably right, I don't know the ruby bindings at all, I just +> wanted to preserve the old behavior. You are welcome to refine the +> ruby bindings later (or maintain them, I *believe* they are +> unmaintained, the last change was back in october 2011), but let's get +> this patch series in first. + +I just marked this series ready, but I wasn't clear on what the +conclusion here was. Feel free to mark it moreinfo again if it's not +actually ready (maybe mark just this patch? it's a bit confusing since +the patches aren't quite all together.)