From: Tomi Ollila <tomi.ollila@iki.fi>
Date: Mon, 30 Jan 2012 07:59:32 +0000 (+0200)
Subject: Re: [PATCH] emacs: globally replace non-branching "(if COND (progn ..." with "(when... 
X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=1d00b62cd1460196d6fdce11a51294e3b715fc5c;p=notmuch-archives.git

Re: [PATCH] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..."
---

diff --git a/d7/17d527e9e7a314e7bf8392adafa35ce6ae3f82 b/d7/17d527e9e7a314e7bf8392adafa35ce6ae3f82
new file mode 100644
index 000000000..769ecc67f
--- /dev/null
+++ b/d7/17d527e9e7a314e7bf8392adafa35ce6ae3f82
@@ -0,0 +1,102 @@
+Return-Path: <tomi.ollila@iki.fi>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id 31269431E64
+	for <notmuch@notmuchmail.org>; Sun, 29 Jan 2012 23:59:30 -0800 (PST)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 0
+X-Spam-Level: 
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
+	autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id N9OMTtpT0Y1X for <notmuch@notmuchmail.org>;
+	Sun, 29 Jan 2012 23:59:29 -0800 (PST)
+Received: from guru.guru-group.fi (guru-group.fi [87.108.86.66])
+	by olra.theworths.org (Postfix) with ESMTP id 8E0D3431FBC
+	for <notmuch@notmuchmail.org>; Sun, 29 Jan 2012 23:59:29 -0800 (PST)
+Received: by guru.guru-group.fi (Postfix, from userid 501)
+	id 8839E68056; Mon, 30 Jan 2012 09:59:32 +0200 (EET)
+From: Tomi Ollila <tomi.ollila@iki.fi>
+To: Pieter Praet <pieter@praet.org>, David Bremner <david@tethera.net>,
+	David Edmondson <dme@dme.org>, Jani Nikula <jani@nikula.org>
+Subject: Re: [PATCH] emacs: globally replace non-branching "(if COND (progn
+	..." with "(when ..."
+In-Reply-To: <8739ax7jts.fsf@praet.org>
+References: <87k44uprvy.fsf@praet.org>
+	<1326532638-22068-1-git-send-email-pieter@praet.org>
+	<87y5ssxam7.fsf@zancas.localnet> <8739ax7jts.fsf@praet.org>
+User-Agent: Notmuch/0.11+116~g34d80c9 (http://notmuchmail.org) Emacs/23.3.1
+	(x86_64-unknown-linux-gnu)
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
+	$[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
+	!)g;OY^,BjTbr)Np:%c_o'jj,Z
+Date: Mon, 30 Jan 2012 09:59:32 +0200
+Message-ID: <m2zkd5ipsr.fsf@guru.guru-group.fi>
+MIME-Version: 1.0
+Content-Type: text/plain; charset=us-ascii
+Cc: Notmuch Mail <notmuch@notmuchmail.org>
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Mon, 30 Jan 2012 07:59:30 -0000
+
+On Mon, 30 Jan 2012 08:03:59 +0100, Pieter Praet <pieter@praet.org> wrote:
+> On Sat, 28 Jan 2012 08:41:36 -0400, David Bremner <david@tethera.net> wrote:
+> > On Sat, 14 Jan 2012 10:17:18 +0100, Pieter Praet <pieter@praet.org> wrote:
+> > > Less code, same results, without sacrificing readability.
+> > > 
+> > 
+> > This looks OK, although the re-indenting makes these kind of changes
+> > painful to review (not that I'm suggesting we should re-indent, just
+> > some random complaining).
+> > 
+> 
+> You can use `diff-refine-hunk' to see what the actual changes are.
+> 
+> Try this:
+> 
+>   #+begin_src emacs-lisp
+>     (global-set-key (kbd "C-c /")
+>                     (lambda()
+>                       "Refine display of unified diff hunks"
+>                       (interactive)
+>                       (save-excursion
+>                         (goto-char (point-min))
+>                         (while (re-search-forward
+>                                 diff-hunk-header-re-unified
+>                                 nil t)
+>                           (diff-refine-hunk)))))
+>   #+end_src
+> 
+> Work pretty much *anywhere*.
+> 
+> Note: it does NOT work in `notmuch-show-mode' (not even with
+> `notmuch-wash-convert-inline-patch-to-part' disabled), but this is
+> easily solved by first running `notmuch-show-view-raw-message' ("V")
+> and `diff-mode' (to fontify the buffer)...
+
+What we need is 'notmuch-devel' minor mode which can do this, dme's
+notmuch patching tool, nmbug tag changes and everything...
+
+> 
+> > d
+> 
+> 
+> Peace
+> 
+> -- 
+> Pieter
+
+Tomi