From: Neil Date: Sat, 19 Oct 2013 11:52:53 +0000 (-0400) Subject: Prevent a unicode error on UTF-8 in commit metadata. X-Git-Tag: 2.0~14 X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=1c6bc9c11291fffe8de9dbe88c9490ac0e2d4278;p=irker.git Prevent a unicode error on UTF-8 in commit metadata. Having utf-8 in the commit metada (e.g author, commit message, file names) triggered a decoding error: "UnicodeDecodeError: 'ascii' codec can't decode byte 0xd7 in position 42: ordinal not in range(128)" This is because the __unicode__ method of the Commit class, doesn't actually return an object of type 'unicode' although it should. --- diff --git a/irkerhook.py b/irkerhook.py index d09eb17..b622a44 100755 --- a/irkerhook.py +++ b/irkerhook.py @@ -88,7 +88,7 @@ class Commit: self.url = webview except IOError: self.url = "" - return self.template % self.__dict__ + return unicode(self.template % self.__dict__, "utf-8") class GenericExtractor: "Generic class for encapsulating data from a VCS."