From: Mark Walters Date: Thu, 6 Dec 2012 22:35:37 +0000 (+0000) Subject: Re: [PATCH] emacs: add support for stashing the thread id in show view X-Git-Url: http://git.tremily.us/gitweb.cgi?a=commitdiff_plain;h=1acc13767ca0efe3c1ca8534746c30b83523316a;p=notmuch-archives.git Re: [PATCH] emacs: add support for stashing the thread id in show view --- diff --git a/42/70c83ab3e07433a9d05e8e26125f5500d4ef7a b/42/70c83ab3e07433a9d05e8e26125f5500d4ef7a new file mode 100644 index 000000000..fd88c075f --- /dev/null +++ b/42/70c83ab3e07433a9d05e8e26125f5500d4ef7a @@ -0,0 +1,122 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 6341F431FB6 + for ; Thu, 6 Dec 2012 14:35:39 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -1.098 +X-Spam-Level: +X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id nDkv4cGqqt0T for ; + Thu, 6 Dec 2012 14:35:36 -0800 (PST) +Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id E768A431FAE + for ; Thu, 6 Dec 2012 14:35:35 -0800 (PST) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail2.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1Tgk2Y-0003A2-1L; Thu, 06 Dec 2012 22:35:34 +0000 +Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69) + (envelope-from ) + id 1Tgk2X-0007bZ-NV; Thu, 06 Dec 2012 22:35:33 +0000 +From: Mark Walters +To: Jani Nikula , notmuch@notmuchmail.org +Subject: Re: [PATCH] emacs: add support for stashing the thread id in show + view +In-Reply-To: <1354827443-10549-1-git-send-email-jani@nikula.org> +References: <1354827443-10549-1-git-send-email-jani@nikula.org> +User-Agent: Notmuch/0.14+81~g9730584 (http://notmuchmail.org) Emacs/23.4.1 + (x86_64-pc-linux-gnu) +Date: Thu, 06 Dec 2012 22:35:37 +0000 +Message-ID: <87mwxqhkqu.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Sender-Host-Address: 93.97.24.31 +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: 2d8b9fbec95b84747639e893bbb93984 (of first 20000 bytes) +X-SpamAssassin-Score: -1.7 +X-SpamAssassin-SpamBar: - +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored -1.7 points. + Summary of the scoring: + * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, + * medium trust + * [138.37.6.40 listed in list.dnswl.org] + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * 0.6 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 06 Dec 2012 22:35:39 -0000 + + +On Thu, 06 Dec 2012, Jani Nikula wrote: +> Add a prefix argument to notmuch-show-stash-message-id to stash thread +> id instead of message id. +> --- +> emacs/notmuch-show.el | 13 +++++++++---- +> 1 file changed, 9 insertions(+), 4 deletions(-) +> +> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el +> index 4d6c014..2245b4f 100644 +> --- a/emacs/notmuch-show.el +> +++ b/emacs/notmuch-show.el +> @@ -1901,10 +1901,15 @@ thread from search." +> (interactive) +> (notmuch-common-do-stash (notmuch-show-get-from))) +> +> -(defun notmuch-show-stash-message-id () +> - "Copy id: query matching the current message to kill-ring." +> - (interactive) +> - (notmuch-common-do-stash (notmuch-show-get-message-id))) +> +(defun notmuch-show-stash-message-id (&optional thread-id) +> + "Copy id: query matching the current message to kill-ring. +> + +> +If invoked with a prefix argument (or THREAD-ID is non-nil), copy +> +thread: query matching the current thread to kill-ring." +> + (interactive "P") +> + (if thread-id +> + (notmuch-common-do-stash notmuch-show-thread-id) +> + (notmuch-common-do-stash (notmuch-show-get-message-id)))) +> + +Basically this looks good to me. My one criticism is the name of the +argument: thread-id looks like it should be umm, a thread-id. Maybe +thread-id-wanted or something? + +Best wishes + +Mark + + +> (defun notmuch-show-stash-message-id-stripped () +> "Copy message ID of current message (sans `id:' prefix) to kill-ring." +> -- +> 1.7.10.4 +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch